Commit Graph

2302 Commits

Author SHA1 Message Date
Carol (Nichols || Goulding)
d4879ff7fc grumble mumble ordered list bug 2017-10-30 11:13:19 -04:00
Carol (Nichols || Goulding)
7db393dae7 Update theme/index.hbs to make printing work again
From mdBook cd711bfb1ca161e8a834f4527f3936f818a6f50f
2017-10-26 14:36:41 -04:00
Carol (Nichols || Goulding)
0d9d5e0c5a Specify that mdbook version should really match what rust-lang/rust is using 2017-10-26 12:32:51 -04:00
Carol (Nichols || Goulding)
38cc9a8ba6 Capture a snapshot of chapter 3-ish 2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
d4c77666f4 Update output, make everything match page review text 2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
f28e635661 fancy quotes 2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
aee4e404f7 Mention the return keyword
Fixes #885
2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
af912a379d Add forward reference to documentation comments
Fixes #810.
2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
b3382f836a Clarify single quotes go with chars and double go with strings
Fixes #803.
2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
0af1a6559e Clarify which line without the semicolon that we're talking about
Fixes #772.
2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
d5c1e36f07 Save nostarch version with approximately what we just sent them
I don't have a way to generate this markdown from the page review PDF,
but having this snapshot might be useful in case we make changes
upstream in between page reviews.
2017-10-20 15:27:22 -04:00
Carol (Nichols || Goulding)
9b0c65bde6 Merge pull request #973 from j3parker/inconsistency
Fix inconsistency in final code listing
2017-10-20 15:22:35 -04:00
Carol (Nichols || Goulding)
227829cf0b Edits made during page review 2017-10-20 12:04:43 -04:00
Carol (Nichols || Goulding)
d2bccd30b6 return key -> enter key 2017-10-19 18:36:18 -04:00
Carol (Nichols || Goulding)
a0b6dd108a Curly brace -> curly bracket everywhere 2017-10-19 18:29:30 -04:00
Jacob Parker
4d116021eb Fix inconsistency in final code listing
I forgot to apply the change from the penultimate listing of `main()` to
the summary at the end of the chapter.
2017-10-19 15:27:29 -04:00
Carol (Nichols || Goulding)
e0a956754f Merge pull request #965 from j3parker/take
(minor) Use Iterator::take rather than a manual counter
2017-10-19 15:04:51 -04:00
Carol (Nichols || Goulding)
ccb17fc2fb Merge pull request #967 from jtescher/non-negative-examples
Switch from i32 to u32 for shoe size and workout intensity
2017-10-19 15:03:57 -04:00
Carol (Nichols || Goulding)
360f727b2e Merge pull request #962 from chenl/patch-1
update error[E0282]
2017-10-19 14:59:49 -04:00
Jacob Parker
672b533b56 Add "combinator" to dictionary 2017-10-16 17:13:51 -04:00
Jacob Parker
ac8f2b6f0c More exposition for Iterator::take 2017-10-16 10:41:44 -04:00
Julian Tescher
357969bd5e Switch from i32 to u32 for shoe size and workout intensity 2017-10-15 08:37:09 -07:00
Jacob Parker
0a4b820714 Use Iterator::take rather than a manual counter
I feel like this makes Rust look cooler and probably reads better
because it's a smaller/more natural diff from the previous version of
`main()`.
2017-10-14 18:52:10 -04:00
Chen Rotem Levy
040afcbf97 update error[E0282]
Use the message produced by rustc 1.20.0
2017-10-11 22:30:23 +03:00
Steve Klabnik
808f482db9 Merge pull request #960 from rust-lang/ch14-tr
Ch14 tr
2017-10-11 13:10:16 -04:00
Carol (Nichols || Goulding)
f36e8c111c Merge pull request #958 from rust-lang/ch16-edits
Ch16 edits
2017-10-11 10:43:42 -04:00
Carol (Nichols || Goulding)
59a598b783 Propagating changes to src 2017-10-10 19:06:19 -04:00
Carol (Nichols || Goulding)
fc656fc2ab spellingz 2017-10-10 19:04:29 -04:00
Carol (Nichols || Goulding)
b79f10b0bd Propagate improvements made upstream 2017-10-10 19:01:27 -04:00
Carol (Nichols || Goulding)
566070ec9f fancy quotes 2017-10-10 19:01:27 -04:00
Carol (Nichols || Goulding)
aee97cfcf5 Revisions after comments from nostarch 2017-10-10 19:01:27 -04:00
Carol (Nichols || Goulding)
f294fe4007 Propagate edits after tech review to src 2017-10-10 18:59:32 -04:00
Carol (Nichols || Goulding)
b46b6e0805 Add some more filenames 2017-10-10 18:40:16 -04:00
Carol (Nichols || Goulding)
87c637fd0a Redoing the listing numbers 2017-10-10 18:39:36 -04:00
Carol (Nichols || Goulding)
bed7e2514c Propagate changes to markdown 2017-10-10 17:33:12 -04:00
Carol (Nichols || Goulding)
8d77678871 Address the more substantive comments of alex's 2017-10-10 17:05:22 -04:00
Carol (Nichols || Goulding)
91a0bbc582 Small tweaks 2017-10-10 16:46:12 -04:00
Carol (Nichols || Goulding)
2140a1f909 f with small edits 2017-10-10 14:51:12 -04:00
Carol (Nichols || Goulding)
78ab69d072 Remove comments 2017-10-10 14:44:52 -04:00
Carol (Nichols || Goulding)
906887220a Small edits, formatting problems 2017-10-10 14:39:47 -04:00
Carol (Nichols || Goulding)
f8626b210e Chapter 14 received from nostarch after technical review 2017-10-10 14:23:54 -04:00
Carol (Nichols || Goulding)
528b3c3f36 Merge pull request #956 from rust-lang/ch13-again
Ch13 again
2017-10-10 14:17:02 -04:00
Carol (Nichols || Goulding)
e25056deb4 Missed some backticks 2017-10-10 11:19:24 -04:00
Carol (Nichols || Goulding)
edf16cac16 Clarify that functions could be used in this example
Fixes #922.
2017-10-09 13:04:51 -04:00
Carol (Nichols || Goulding)
bba9845a57 Explain the mut keyword in the parameters
This is the first time we've used this syntax, and we actually claim to
be modifying the signature in this listing but the mut keyword magically
appears without explanation at all in the next listing, oops. We should
add it and explain it here.

Fixes #905.
2017-10-09 12:24:14 -04:00
Carol (Nichols || Goulding)
97ceb7cbc0 Propagate changes to src 2017-10-09 12:15:53 -04:00
Carol (Nichols || Goulding)
3a21126ce8 Propagate changes to nostarch md 2017-10-09 11:22:23 -04:00
Carol (Nichols || Goulding)
bd572e986e wingding it up 2017-10-09 11:22:23 -04:00
Carol (Nichols || Goulding)
fd25c913ca The styles are different again, for no reason I can tell 2017-10-05 18:38:56 -04:00
Carol (Nichols || Goulding)
9b82781c85 remove review comments 2017-10-05 17:34:44 -04:00