mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-06 00:47:56 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,309,428 Commits 1 Branch 929 Tags
ce64433cd42247fecf4d039dbcebeab12a3b2fa4
Commit Graph

1309428 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Umang Jain
ce64433cd4 staging: vchiq_core: Move remote_event_signal() vchiq_core 
The function remote_event_signal() is declared in vchiq_core.h while
defined in vchiq_arm.c and used only in vchiq_core.c. Move the
definition to vchiq_core.c as it is only used in this file.

Also convert it to static and drop the function signature from
vchiq_core.h header. BELL2 doorbell macro is also moved from vchiq_arm
to vchiq_core as part of this change.

No functional changes intended in this patch.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240919142130.1331495-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:59:06 +02:00
Umang Jain
f813dac50f staging: vchiq_core: Drop retry loop on -EINTR 
-EINTR is returned by vchiq_queue_message() on receiving a fatal
signal to the process. Since the process is deemed to be terminated
anyway, do not retry queuing with vchiq_queue_message() on -EINTR.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240918163100.870596-7-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:58:47 +02:00
Umang Jain
ec5d292db3 staging: vchiq_arm: Do not retry bulk transfers on -EINTR 
-EINTR is returned by various vchiq bulk transfer code paths
on receiving a fatal signal to the process. Since the process is
deemed to be terminated anyway, do not retry the bulk transfer
on -EINTR.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240918163100.870596-6-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:58:47 +02:00
Umang Jain
80f8ea98e4 staging: vchiq_core: Return -EINTR when bulk transfers are interrupted 
Bulk transfers for various VCHIQ modes use mutex_lock_killable() and
wait_for_completion_killable() variations. Currently, -EAGAIN is
returned if these are interrupted by a fatal signal.

-EAGAIN may mislead the caller into thinking the operation can be
retried, while in reality, the process has received a fatal signal
and is terminating. Therefore, we should update the return value to
align with what these killable functions would return, specifically
-EINTR (Interrupted system call).

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240918163100.870596-5-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:58:47 +02:00
Umang Jain
72925dec88 staging: vchiq_core: Return -EINTR in queue_message() on interrupt 
queue_message() uses mutex_lock_killable() and
wait_for_completion_killable() variations of locking and wait event
completions respectively. These functions return either 0 (on success)
or -EINTR, if interrupted by a fatal signal (as documented in the
kernel).

However, queue_message() is currently returning -EAGAIN if these
killable functions are interrupted by fatal signals. Bubbling up
-EAGAIN might give a sense to the caller, that the code path can
be re-tried however, in actual sense, a fatal signal has been
received by the process and the process is going away.

Hence, we should align the return value with what these killable
versions will return i.e. -EINTR (Interrupted system call).

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240918163100.870596-4-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:58:47 +02:00
Umang Jain
fbd06c751a staging: vchiq_core: Return on all errors from queue_message() 
In vchiq_connect_internal(), a MAKE_CONNECT message is queued
if the connection is disconnected, but only -EAGAIN error is
checked on the error path and returned.

However, queue_message() can fail with other errors as well hence,
vchiq_connect_internal() should return in those cases as well.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240918163100.870596-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:58:47 +02:00
Umang Jain
36022f3ee8 staging: vchiq_core: Use killable wait completions for bulk transfers 
commit f27e47bc6b ("staging: vchiq: use completions instead of
semaphores") introduced completions for events in vchiq interface.
It introduced _interruptible() version of completions for waiting
on events. However, it missed a subtle down_interruptible() macro
override in vchiq_killable.h, which used to mask most of the signals
and only interrupt on fatal ones.

The above issue was fixed in commit a772f11670 ("staging: vchiq: switch
to wait_for_completion_killable"). Given the override logic of
down_interruptible() that existed in vchiq_killable.h, that commit
fixed the completions with the correct variation i.e. killable() family
of functions.

However, commit a772f11670 ("staging: vchiq: switch to
wait_for_completion_killable") later got reverted [1] due to high CPU
load noticed by various downstream and upstream distributions [2].
Reverting the commit solved this problem but the root cause was never
diagonsed and the entire commit was reverted.

This patch brings back killable version of wait events but only for
bulk transfers and queue_message() transfer code paths.

The idea is to bring back killable versions for various event
completions in a phased manner so that we do not re-regress again as
noticed in [2]. Hence, no other wait events are converted from
interruptible -> killable in this patch.

Since the bulk transfers are no longer interruptible (but killable),
drop the "_interruptible" suffix from all vchiq_bulk_xfer_* functions.

[1]: commit 086efbabdc ("staging: vchiq: revert "switch to wait_for_completion_killable"")
[2]: https://patchwork.kernel.org/project/linux-arm-kernel/cover/20190509143137.31254-1-nsaenzjulienne@suse.de/

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240918163100.870596-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:58:46 +02:00
Rodrigo Gobbi
00ea2b0dc6 staging: gdm724x: fix returning -1 with return equivalent errors 
As in the TODO file, use proper error codes from PM callbacks and init.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241007211124.170540-1-rodrigo.gobbi.7@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:57:49 +02:00
Xingquan Liu
b87e5fd558 staging: rtl8712: remove parentheses after & 
Remove parentheses after & to fix checkpatch warning
Unnecessary parentheses.

Signed-off-by: Xingquan Liu <b1n@b1n.io>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241003070353.65998-1-b1n@b1n.io
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:57:40 +02:00
Tudor Gheorghiu
064894731c staging: rtl8712: use kmalloc_array 
Adhere to Linux kernel coding style.

Reported by checkpatch:

WARNING: Prefer kmalloc_array over kmalloc with multiply
+       pxmitpriv->pxmitbuf = kmalloc(NR_XMITBUFF * sizeof(struct xmit_buf), GFP_ATOMIC);

Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/ZvBy2lB_ok_OCmVI@redaops
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:55:51 +02:00
Sergio Paracuellos
c1a5060ec8 staging: Switch back to struct platform_driver::remove() 
After commit 0edb555a65 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all staging drivers to use .remove(), with the eventual goal to
drop struct platform_driver::remove_new(). As .remove() and .remove_new()
have the same prototypes, conversion is done by just changing the structure
member name in the driver initializer.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Link: https://lore.kernel.org/r/20241001085751.282113-1-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:54:53 +02:00
Uwe Kleine-König
d09d348596 staging: olpc_dcon: Drop explicit initialization of struct i2c_device_id::driver_data to 0 
These drivers don't use the driver_data member of struct i2c_device_id,
so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires
either no initialization or named designators. But it's also a nice
cleanup on its own.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20240920153430.503212-16-u.kleine-koenig@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:54:49 +02:00
Uwe Kleine-König
b5b7a2c923 staging: most: i2c: Drop explicit initialization of struct i2c_device_id::driver_data to 0 
These drivers don't use the driver_data member of struct i2c_device_id,
so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires
either no initialization or named designators. But it's also a nice
cleanup on its own.

While touching the initializer, also remove the comma after the sentinel
entry.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20240920153430.503212-15-u.kleine-koenig@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:54:47 +02:00
Dominik Karol Piątkowski
302b4a0f5f staging: vt6655: s_uGetDataDuration: Fix declaration formatting 
This patch fixes formatting of s_uGetDataDuration function declaration.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-15-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
7e471dddda staging: vt6655: s_uGetDataDuration: Rename uNextPktTime variable 
This patch renames uNextPktTime to next_pkt_time in s_uGetDataDuration
function in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-14-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
1b0ab3e5b4 staging: vt6655: s_uGetDataDuration: Rename uAckTime variable 
This patch renames uAckTime to ack_time in s_uGetDataDuration function
in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-13-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
90005d8525 staging: vt6655: s_uGetDataDuration: Rename bLastFrag variable 
This patch renames bLastFrag to last_frag in s_uGetDataDuration function
in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-12-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
99084e9936 staging: vt6655: s_uGetDataDuration: Rename byFBOption parameter 
This patch renames byFBOption to fb_option in s_uGetDataDuration
function in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-11-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
71a63719ea staging: vt6655: s_uGetDataDuration: Rename uMACfragNum parameter 
This patch renames uMACfragNum to mac_frag_num in s_uGetDataDuration
function in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-10-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
b8ba62bfc5 staging: vt6655: s_uGetDataDuration: Rename cbLastFragmentSize parameter 
This patch renames cbLastFragmentSize to last_fragment_size in
s_uGetDataDuration function in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-9-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:44 +02:00
Dominik Karol Piątkowski
2ecc3fe863 staging: vt6655: s_uGetDataDuration: Rename uFragIdx parameter 
This patch renames uFragIdx to frag_idx in s_uGetDataDuration function in
order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-8-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
b15914b713 staging: vt6655: s_uGetDataDuration: Rename bNeedAck parameter 
This patch renames bNeedAck to need_ack in s_uGetDataDuration function
in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-7-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
f47fff8b55 staging: vt6655: s_uGetDataDuration: Rename wRate parameter 
This patch renames wRate to rate in s_uGetDataDuration function in order
to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-6-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
3bea8179a5 staging: vt6655: s_uGetDataDuration: Rename byPktType parameter 
This patch renames byPktType to pkt_type in s_uGetDataDuration function
in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-5-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
d56397f1eb staging: vt6655: s_uGetDataDuration: Rename cbFrameLength parameter 
This patch renames cbFrameLength to frame_length in s_uGetDataDuration
function in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-4-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
0d90f4f792 staging: vt6655: s_uGetDataDuration: Rename byDurType parameter 
This patch renames byDurType to dur_type in s_uGetDataDuration function
in order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-3-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
ad43c5c60c staging: vt6655: s_uGetDataDuration: Rename pDevice parameter 
This patch renames pDevice to priv in s_uGetDataDuration function in
order to avoid using camel case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240918191959.51539-2-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:43 +02:00
Dominik Karol Piątkowski
09b869177b staging: vt6655: rxtx.c: Fix too long lines in get_rtscts_time 
This patch fixes the lines exceeding 100 columns in get_rtscts_time
function.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240918165052.30386-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:39 +02:00
Dominik Karol Piątkowski
95a85744bf staging: vt6656: Update maintainer in TODO 
Commit ed394dbf53 replaced Forest Bond
with Philipp Hortmann as vt665X maintainer in MAINTAINERS, but
drivers/staging/vt6656/TODO was not changed, rendering it stale. This
patch fixes it.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240917171937.22801-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:50:33 +02:00
Manuel Quintero F
41ffdb8faa staging: rtl8723bs: core: rtw_cmd: Missing a blank line after declarations 
Fix checkpatch: WARNING: Missing a blank line after declarations

Signed-off-by: Manuel Quintero F <sakunix@yahoo.com>
Link: https://lore.kernel.org/r/20241005233308.4520-1-sakunix@yahoo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:49:09 +02:00
Philipp Hortmann
d8aa437cb8 staging: rtl8723bs: Remove function pointer disable_interrupt 
Remove function pointer disable_interrupt and use
DisableInterrupt8723BSdio directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/fee97dadc88bbdaebd82c99d0b6106d58315bd85.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
4178941300 staging: rtl8723bs: Remove function pointer enable_interrupt 
Remove function pointer enable_interrupt and use
EnableInterrupt8723BSdio directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/728827e155bdcd9951683e485d789d60bc203815.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
babb045cc3 staging: rtl8723bs: Remove function pointer read_adapter_info 
Remove function pointer read_adapter_info and use
ReadAdapterInfo8723BS directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/24eec4df528051fee3cf850308e009f114e14288.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
f6faa9db0f staging: rtl8723bs: Remove function pointer intf_chip_configure 
Remove function pointer intf_chip_configure and use
rtl8723bs_interface_configure directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/d542f172438c333c015b87376a20645eeeae1b99.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
218fcc250b staging: rtl8723bs: Remove function pointer init_default_value 
Remove function pointer init_default_value and use
rtl8723bs_init_default_value directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/d0bb58235d54d1c7e4806c5ea3a50dbf77c293e7.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
484b521f10 staging: rtl8723bs: Remove function pointer read_chip_version 
Remove function pointer read_chip_version and use
rtl8723b_read_chip_version directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/79b26478a2493a1d7c27f8e88e0bec56a653d082.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
1bc38f0061 staging: rtl8723bs: Remove function pointer dm_deinit 
Remove function pointer dm_deinit as it is not linked to any function.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/bb03b1309e9aa6bae988c5b7003b4f925f5c7027.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
41dc219196 staging: rtl8723bs: Remove function pointer dm_init 
Remove function pointer dm_init and use rtl8723b_init_dm_priv directly to
increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/e25134aacd3f784300f527d7e367b9f0f066254a.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:53 +02:00
Philipp Hortmann
274c26e753 staging: rtl8723bs: Remove function pointer free_recv_priv 
Remove function pointer free_recv_priv and use rtl8723bs_free_recv_priv
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/17f06e3495abea1f6ad2a2f8d4f4ff1f23bef654.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Philipp Hortmann
4d54a33e7a staging: rtl8723bs: Remove function pointer init_recv_priv 
Remove function pointer init_recv_priv and use rtl8723bs_init_recv_priv
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/d9576e47920b045d702069fd3167e38d889412e7.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Philipp Hortmann
d6a5fe6a2f staging: rtl8723bs: Remove function pointer free_xmit_priv 
Remove function pointer free_xmit_priv and use rtl8723bs_free_xmit_priv
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/01ee48c459ddda882c7616e6cf257d96429027c2.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Philipp Hortmann
03afcc9d52 staging: rtl8723bs: Remove function pointer init_xmit_priv 
Remove function pointer init_xmit_priv and use rtl8723bs_init_xmit_priv
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/322d2412d89ae384365ec1d000bb0fc62128a261.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Philipp Hortmann
ac1b9999bf staging: rtl8723bs: Remove function pointer free_hal_data 
Remove function pointer free_hal_data and function rtl8723b_free_hal_data
as it is dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/455b7a4645e6652815020635a7b34e56c2b96423.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Philipp Hortmann
1ce42b5fe4 staging: rtl8723bs: Remove function pointer hal_deinit 
Remove function pointer hal_deinit and use rtl8723bs_hal_deinit directly
to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/b0acbbdc372e01baabd1d98f824bc2a3c6c4c600.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Philipp Hortmann
5e0cadea40 staging: rtl8723bs: Remove function pointer hal_init 
Remove function pointer hal_init and use rtl8723bs_hal_init directly to
increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/5c838981141aad1275cbcbe862ac7885de9bb8e9.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:52 +02:00
Michael Harris
acc5515c7e Staging: rtl8723bs: hal: odm: removed unnecessary braces 
Removed unnecessary braces.

Signed-off-by: Michael Harris <michaelharriscode@gmail.com>
Link: https://lore.kernel.org/r/20240928025336.55940-1-michaelharriscode@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:32 +02:00
Philipp Hortmann
764ddf1855 staging: rtl8723bs: Remove unused enum with first entry IFACE_PORT0 
Remove unused enum with first entry IFACE_PORT0.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/ff820d921ba3e3cd777d76213f39d8a1ad93f7f9.1726339782.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:29 +02:00
Philipp Hortmann
0436a4541a staging: rtl8723bs: Remove constant result macro get_iface_type 
Remove macro get_iface_type that returns always false to shorten code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/d382321bdd67fdce0ec2357920f67b5dd81ef426.1726339782.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:28 +02:00
Philipp Hortmann
862f4fb826 staging: rtl8723bs: Remove constant result macro is_primary_adapter 
Remove macro is_primary_adapter that returns always true to shorten code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/72673acf8b0ada07530b0cb3705cde4cda5e752b.1726339782.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:28 +02:00
Philipp Hortmann
1101343355 staging: rtl8723bs: Remove unused function rtl8723bs_inirp_deinit 
Remove unused function rtl8723bs_inirp_deinit and belonging unused
function pointer in struct hal_ops inirp_deinit.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/dc6d35602d44cc676bebbd6d84733ea5420ac3f3.1726339782.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2024-10-09 11:48:28 +02:00