mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-06 00:47:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

staging: gdm724x: fix returning -1 with return equivalent errors

Browse Source 
As in the TODO file, use proper error codes from PM callbacks and init.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241007211124.170540-1-rodrigo.gobbi.7@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Rodrigo Gobbi
2024-10-07 18:11:24 -03:00
committed by Greg Kroah-Hartman
parent b87e5fd558
commit 00ea2b0dc6
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/gdm724x/TODO
View File

@@ -2,7 +2,6 @@ TODO:
- Clean up coding style to meet kernel standard. (80 line limit, netdev_err)
- Remove test for host endian
- Remove confusing macros (endian, hci_send, sdu_send, rcv_with_cb)
- Fixes for every instances of function returning -1
- Check for skb->len in gdm_lte_emulate_arp()
- Use ALIGN() macro for dummy_cnt in up_to_host()
- Error handling in init_usb()

6
drivers/staging/gdm724x/gdm_mux.c
View File

@@ -47,7 +47,7 @@ static int packet_type_to_tty_index(u16 packet_type)
return i;
}
return -1;
return -ENOENT;
}
static struct mux_tx *alloc_mux_tx(int len)
@@ -594,7 +594,7 @@ static int gdm_mux_suspend(struct usb_interface *intf, pm_message_t pm_msg)
if (mux_dev->usb_state != PM_NORMAL) {
dev_err(intf->usb_dev, "usb suspend - invalid state\n");
return -1;
return -EINVAL;
}
mux_dev->usb_state = PM_SUSPEND;
@@ -622,7 +622,7 @@ static int gdm_mux_resume(struct usb_interface *intf)
if (mux_dev->usb_state != PM_SUSPEND) {
dev_err(intf->usb_dev, "usb resume - invalid state\n");
return -1;
return -EINVAL;
}
mux_dev->usb_state = PM_NORMAL;

10
drivers/staging/gdm724x/gdm_usb.c
View File

@@ -916,7 +916,7 @@ static int gdm_usb_suspend(struct usb_interface *intf, pm_message_t pm_msg)
rx = &udev->rx;
if (udev->usb_state != PM_NORMAL) {
dev_err(intf->usb_dev, "usb suspend - invalid state\n");
return -1;
return -EINVAL;
}
udev->usb_state = PM_SUSPEND;
@@ -952,7 +952,7 @@ static int gdm_usb_resume(struct usb_interface *intf)
if (udev->usb_state != PM_SUSPEND) {
dev_err(intf->usb_dev, "usb resume - invalid state\n");
return -1;
return -EINVAL;
}
udev->usb_state = PM_NORMAL;
@@ -989,9 +989,11 @@ static struct usb_driver gdm_usb_lte_driver = {
static int __init gdm_usb_lte_init(void)
{
if (gdm_lte_event_init() < 0) {
int ret = gdm_lte_event_init();
if (ret < 0) {
pr_err("error creating event\n");
return -1;
return ret;
}
return usb_register(&gdm_usb_lte_driver);