mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-07-21 20:27:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

net: arcnet: com20020-pci: avoid -Wformat-truncation warning

Browse Source 
When compiling the com20020-pci driver with W=1, I received the
following warning:

drivers/net/arcnet/com20020-pci.c:224:71: warning: ‘%d’ directive
output may be truncated writing between 1 and 11 bytes into a region of
size between 10 and 11 [-Wformat-truncation=]
 224 | snprintf(dev->name, sizeof(dev->name), "arc%d-%d", dev->dev_id, i);

In reality, this does not represent a problem, because i is bounded by
the .devcount field in struct com20020_pci_card_info, which is
statically defined for each card and very small. Quiet the invalid
warning by changing the type of i and the .devcount field to be
narrower.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Link: https://patch.msgid.link/20260521001631.45434-8-enelsonmoore@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Ethan Nelson-Moore
2026-05-20 17:16:19 -07:00
committed by Jakub Kicinski
parent 19d554d329
commit eb8ffe14a5
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/arcnet/com20020-pci.c
View File

@@ -127,7 +127,8 @@ static int com20020pci_probe(struct pci_dev *pdev,
struct net_device *dev;
struct arcnet_local *lp;
struct com20020_priv *priv;
int i, ioaddr, ret;
int ioaddr, ret;
u8 i;
struct resource *r;
ret = 0;

2
drivers/net/arcnet/com20020.h
View File

@@ -50,7 +50,7 @@ struct com20020_pci_channel_map {
struct com20020_pci_card_info {
const char *name;
int devcount;
u8 devcount;
struct com20020_pci_channel_map chan_map_tbl[PLX_PCI_MAX_CARDS];
struct com20020_pci_channel_map misc_map;