mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-07 16:17:41 -04:00
tulip: eeprom: use struct_size() in kmalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct foo {
int stuff;
struct boo entry[];
};
instance = kmalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
c49f0ce0b6
commit
6541d02590
@@ -224,9 +224,7 @@ void tulip_parse_eeprom(struct net_device *dev)
|
||||
return;
|
||||
}
|
||||
|
||||
mtable = kmalloc(sizeof(struct mediatable) +
|
||||
count * sizeof(struct medialeaf),
|
||||
GFP_KERNEL);
|
||||
mtable = kmalloc(struct_size(mtable, mleaf, count), GFP_KERNEL);
|
||||
if (mtable == NULL)
|
||||
return; /* Horrible, impossible failure. */
|
||||
last_mediatable = tp->mtable = mtable;
|
||||
|
||||
Reference in New Issue
Block a user