mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-09 10:11:52 -04:00
cxgb4: smt: use struct_size() in kvzalloc()
One of the more common cases of allocation size calculations is
finding the size of a structure that has a zero-sized array at
the end, along with memory for some number of elements for that
array. For example:
struct foo {
int stuff;
struct boo entry[];
};
instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
3ebb18a48c
commit
c49f0ce0b6
@@ -47,8 +47,7 @@ struct smt_data *t4_init_smt(void)
|
||||
|
||||
smt_size = SMT_SIZE;
|
||||
|
||||
s = kvzalloc(sizeof(*s) + smt_size * sizeof(struct smt_entry),
|
||||
GFP_KERNEL);
|
||||
s = kvzalloc(struct_size(s, smtab, smt_size), GFP_KERNEL);
|
||||
if (!s)
|
||||
return NULL;
|
||||
s->smt_size = smt_size;
|
||||
|
||||
Reference in New Issue
Block a user