mirrors/compiler-explorer
1
0
Fork 0
mirror of https://github.com/compiler-explorer/compiler-explorer.git synced 2025-12-27 10:33:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix the embedded iframe buttons. Note to future selves: try and avoid… (#7606)

Browse Source 
… styles as code indicators ... mea culpa
This commit is contained in:
Matt Godbolt
2025-04-24 15:06:45 -05:00
committed by GitHub
parent 82eff66c49
commit e6de1495df
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/TestingTheUi.md
View File

@@ -20,7 +20,7 @@ major UI changes, framework updates, or when implementing significant new featur
- Test the copy button - Test the copy button
- Check that social sharing buttons display correctly - Check that social sharing buttons display correctly
- Verify proper styling in both light and dark themes - Verify proper styling in both light and dark themes
- Check the `<iframe>` of embed is correct HTML - Check the `<iframe>` of embed is correct HTML, including its various options
- Check the inner link of the iframe for embed works still (that is, embed mode) - Check the inner link of the iframe for embed works still (that is, embed mode)
- Test "Copied to clipboard" tooltip functionality - Test "Copied to clipboard" tooltip functionality

2
static/sharing.ts
View File

@@ -387,7 +387,7 @@ export class Sharing {
case LinkType.Embed: { case LinkType.Embed: {
const options: Record<string, boolean> = {}; const options: Record<string, boolean> = {};
$('#sharelinkdialog input:checked').each((i, element) => { $('#sharelinkdialog input:checked').each((i, element) => {
options[$(element).prop('class')] = true; options[$(element).data('option')] = true;
}); });
done(null, Sharing.getEmbeddedHtml(config, root, false, options), false); done(null, Sharing.getEmbeddedHtml(config, root, false, options), false);
return; return;

4
views/popups/sharelinkdialog.pug
View File

@@ -16,10 +16,10 @@
small.form-text.text-muted#share-permalink-help Use this URL to share your code with others small.form-text.text-muted#share-permalink-help Use this URL to share your code with others
#embedsettings.mb-3(role="group") #embedsettings.mb-3(role="group")
.form-check .form-check
input.form-check-input.readOnly(type="checkbox" id="share-checkbox-readonly") input.form-check-input(type="checkbox" id="share-checkbox-readonly" data-option="readOnly")
label.form-check-label(for="share-checkbox-readonly") Read Only label.form-check-label(for="share-checkbox-readonly") Read Only
.form-check .form-check
input.form-check-input.hideEditorToolbars(type="checkbox" id="share-checkbox-hideEditorToolbars") input.form-check-input(type="checkbox" id="share-checkbox-hideEditorToolbars" data-option="hideEditorToolbars")
label.form-check-label(for="share-checkbox-hideEditorToolbars") Hide Editor Toolbars label.form-check-label(for="share-checkbox-hideEditorToolbars") Hide Editor Toolbars
if sharingEnabled if sharingEnabled
.socialsharing.mt-2 .socialsharing.mt-2