From e6de1495df4a0afefa378c497e3fcb39c0525501 Mon Sep 17 00:00:00 2001
From: Matt Godbolt <matt@godbolt.org>
Date: Thu, 24 Apr 2025 15:06:45 -0500
Subject: [PATCH] =?UTF-8?q?Fix=20the=20embedded=20iframe=20buttons.=20Note?=
 =?UTF-8?q?=20to=20future=20selves:=20try=20and=20avoid=E2=80=A6=20(#7606)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

… styles as code indicators ... mea culpa
---
 docs/TestingTheUi.md             | 2 +-
 static/sharing.ts                | 2 +-
 views/popups/sharelinkdialog.pug | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/TestingTheUi.md b/docs/TestingTheUi.md
index cbc29714e..7e9461a72 100644
--- a/docs/TestingTheUi.md
+++ b/docs/TestingTheUi.md
@@ -20,7 +20,7 @@ major UI changes, framework updates, or when implementing significant new featur
 - Test the copy button
 - Check that social sharing buttons display correctly
 - Verify proper styling in both light and dark themes
-- Check the `<iframe>` of embed is correct HTML
+- Check the `<iframe>` of embed is correct HTML, including its various options
 - Check the inner link of the iframe for embed works still (that is, embed mode)
 - Test "Copied to clipboard" tooltip functionality
 
diff --git a/static/sharing.ts b/static/sharing.ts
index bd11f06d2..fe4f38056 100644
--- a/static/sharing.ts
+++ b/static/sharing.ts
@@ -387,7 +387,7 @@ export class Sharing {
             case LinkType.Embed: {
                 const options: Record<string, boolean> = {};
                 $('#sharelinkdialog input:checked').each((i, element) => {
-                    options[$(element).prop('class')] = true;
+                    options[$(element).data('option')] = true;
                 });
                 done(null, Sharing.getEmbeddedHtml(config, root, false, options), false);
                 return;
diff --git a/views/popups/sharelinkdialog.pug b/views/popups/sharelinkdialog.pug
index 672d69fe2..4114b4cc2 100644
--- a/views/popups/sharelinkdialog.pug
+++ b/views/popups/sharelinkdialog.pug
@@ -16,10 +16,10 @@
               small.form-text.text-muted#share-permalink-help Use this URL to share your code with others
               #embedsettings.mb-3(role="group")
                 .form-check
-                  input.form-check-input.readOnly(type="checkbox" id="share-checkbox-readonly")
+                  input.form-check-input(type="checkbox" id="share-checkbox-readonly" data-option="readOnly")
                   label.form-check-label(for="share-checkbox-readonly") Read Only
                 .form-check
-                  input.form-check-input.hideEditorToolbars(type="checkbox" id="share-checkbox-hideEditorToolbars")
+                  input.form-check-input(type="checkbox" id="share-checkbox-hideEditorToolbars" data-option="hideEditorToolbars")
                   label.form-check-label(for="share-checkbox-hideEditorToolbars") Hide Editor Toolbars
               if sharingEnabled
                 .socialsharing.mt-2