Fix the embedded iframe buttons. Note to future selves: try and avoid… (#7606)

… styles as code indicators ... mea culpa

docs/TestingTheUi.md

@@ -20,7 +20,7 @@ major UI changes, framework updates, or when implementing significant new featur
 - Test the copy button
 - Check that social sharing buttons display correctly
 - Verify proper styling in both light and dark themes
-- Check the `<iframe>` of embed is correct HTML
+- Check the `<iframe>` of embed is correct HTML, including its various options
 - Check the inner link of the iframe for embed works still (that is, embed mode)
 - Test "Copied to clipboard" tooltip functionality
 

static/sharing.ts

@@ -387,7 +387,7 @@ export class Sharing {
             case LinkType.Embed: {
                 const options: Record<string, boolean> = {};
                 $('#sharelinkdialog input:checked').each((i, element) => {
-                    options[$(element).prop('class')] = true;
+                    options[$(element).data('option')] = true;
                 });
                 done(null, Sharing.getEmbeddedHtml(config, root, false, options), false);
                 return;

views/popups/sharelinkdialog.pug

@@ -16,10 +16,10 @@
               small.form-text.text-muted#share-permalink-help Use this URL to share your code with others
               #embedsettings.mb-3(role="group")
                 .form-check
-                  input.form-check-input.readOnly(type="checkbox" id="share-checkbox-readonly")
+                  input.form-check-input(type="checkbox" id="share-checkbox-readonly" data-option="readOnly")
                   label.form-check-label(for="share-checkbox-readonly") Read Only
                 .form-check
-                  input.form-check-input.hideEditorToolbars(type="checkbox" id="share-checkbox-hideEditorToolbars")
+                  input.form-check-input(type="checkbox" id="share-checkbox-hideEditorToolbars" data-option="hideEditorToolbars")
                   label.form-check-label(for="share-checkbox-hideEditorToolbars") Hide Editor Toolbars
               if sharingEnabled
                 .socialsharing.mt-2