Commit Graph

2507 Commits

Author SHA1 Message Date
ritiek
d5ce6fbdb0 Remove chapter title to prevent duplicate 2018-01-07 20:37:06 +05:30
Carol (Nichols || Goulding)
83896fa600 Merge pull request #1097 from guzzlefry/patch-1
Annotate variable type rather than using turbofish
2018-01-05 14:06:15 -05:00
Gus
3e79fb6f3f Annotate variable type rather than using turbofish
Turbofish, as far as I know, hasn't been introduced yet. Throwing unknown syntax at readers can be confusing. It might be more prudent to explain Turbofish in the explanation following the code example or just explain in the next chapter (see: #385)
2018-01-05 07:09:52 -05:00
Carol (Nichols || Goulding)
a28f03e26e Merge pull request #1094 from rust-lang/ch19-edits
ch 19 edits
2018-01-03 15:28:07 -05:00
Carol (Nichols || Goulding)
89a2631cb5 Fix inside/outside safe/unsafe meaning that got backwards 2018-01-03 15:05:33 -05:00
Carol (Nichols || Goulding)
9d5b9a573d Fix listing numbers throughout ch 19
Fixes #1067.
2018-01-03 15:05:33 -05:00
Carol (Nichols || Goulding)
7c8dc6f619 Edits to the rest of ch 19 2018-01-02 21:16:29 -05:00
Carol (Nichols || Goulding)
425b24cc54 Cut problematic example of associated types and trait objects
Fixes #915.
2018-01-02 20:12:36 -05:00
Carol (Nichols || Goulding)
62ca2eeb44 Edits to associated types 2018-01-02 20:12:36 -05:00
Carol (Nichols || Goulding)
f7f5e4835c Add missing word "same"
Fixes #1078.
2018-01-02 20:12:35 -05:00
Carol (Nichols || Goulding)
0cc22f2ca2 Clarify lifetimes + trait objects section
Fixes #624.
2018-01-02 20:12:35 -05:00
Carol (Nichols || Goulding)
a1e9d3fede Clarify lifetime subtyping and lifetime bounds sections
Fixes #944.
2018-01-02 20:12:35 -05:00
Carol (Nichols || Goulding)
9f03d42e2f 19 00, 01 2018-01-02 20:12:21 -05:00
Carol (Nichols || Goulding)
1b0eac20ba Propagate changes made in upstream to nostarch 2018-01-02 14:41:34 -05:00
Steve Klabnik
4932802233 Merge pull request #1065 from chenl/patch-21
Compile error of Listing 17-10 have `rust_gui::`
2017-12-31 17:31:35 -05:00
Steve Klabnik
50e57e04f4 Merge pull request #1064 from chenl/patch-20
Listing 17-10: should use Screen not Draw
2017-12-31 17:31:09 -05:00
Steve Klabnik
3368af2ac8 Merge pull request #1088 from passcod/improve-redirects
Improve redirects
2017-12-31 17:29:40 -05:00
Carol (Nichols || Goulding)
6e27fb314b Merge pull request #1080 from MarcManiez/correct-typo-in-ch15-01
Correct typo
2017-12-31 14:38:40 -05:00
Félix Saparelli
0ed0eef71a Highlight recommended path and lowlight the rest
Instead of placing the link to the recommended resource i.e. the second
edition in second place, push it up to the top of the list. In fact,
push the link to the first edition always at the bottom.

To emphasise even more that's where new visitors should go, bolden the
first link, and make the first-ed link smaller.

All this as well as a slight edit and simplification of the copy is
designed to make the new and recommended resources the primary path
readers take, without hiding the old resource completely.
2017-12-31 18:12:49 +13:00
Félix Saparelli
6454576fe4 Add blurb and code example
To improve immediate value and reduce discard-because-not-useful factor
upon arriving at a page which does not contain the content you were
expecting, add a small blurb taken/adapted from the newer source,
optionally accompanied by a code sample describing the feature.

However, due to the transitive nature of this resource, there must be no
content here that isn't available elsewhere.
2017-12-31 16:15:12 +13:00
Félix Saparelli
fb9f9805ed Add the title of the link into its text
To make it clearer where links are going, eliminate entirely the
language of "Related" or the long verbose book titles. Instead, simply
prefix with "In the first/second edition" as needed, and in similar
style for other resources like the reference or the Unsafe book.

Add the target's title, i.e. chapter number, name, and sometimes
subsection, directly to the link copy.
2017-12-31 12:20:58 +13:00
Félix Saparelli
e1381afbce Always go somewhere
Unless it is the correct place to go, never link to the index of the
second edition as fallback. Point instead to different books, to the
reference, to the API documentation, etc.
2017-12-31 12:20:58 +13:00
Félix Saparelli
ebbdd0132f Put the chapter title as the title
And reword the blurb to include what was previously in the title.

This makes it easier to see that one has arrived to the right place:
beforehand, the only indication was through the link target for the
first edition; it was nowhere in the copy itself for most pages.
2017-12-31 12:20:58 +13:00
Carol (Nichols || Goulding)
1fe78a83f3 Small tweaks to ch 12 noticed in page review 2017-12-30 15:20:22 -05:00
Steve Klabnik
194eb8d5f1 Merge pull request #1083 from sebug/patch-1
Removing unnecessary semicolon
2017-12-28 12:38:10 -05:00
Sebastian Gfeller
ae4c690935 Removing unnecessary semicolon
Just stumbled over it while reading, there was a trailing semicolon in the code example for "Validating the request and selectively responding".
2017-12-28 17:56:48 +01:00
Steve Klabnik
3de9a19015 Merge pull request #1082 from StevenBlack/master
ch01-01: prefer “distrust” over “disapprove”
2017-12-27 09:07:29 -05:00
Steven Black
b6dcc87f2b ch01-01: prefer “distrust” over “disapprove”
Hello!  First-time contributor here.

If merged, this PR will change two things in a very important section of the installation instructions.

I “disapprove” of useing “curl | sh” but I trust you, so this is what I did.  Therefore I propose that “distrust” is a more appropriate noun here.

Second, I feel `curl URL | sh` is more apt.

Thank you for this opportunity to contribute to Rust documentation, which I am just starting to explore.
2017-12-26 17:00:24 -05:00
MarcManiez
0905e41f73 Correct typo. 2017-12-24 22:28:45 -05:00
Carol (Nichols || Goulding)
4464eab089 Making small tweaks noticed in page review 2017-12-20 15:23:51 -05:00
Steve Klabnik
30115e3860 Merge pull request #1055 from wizarrc/patch-1
rustc is outputting pdb file on windows
2017-12-20 08:17:10 -05:00
Carol (Nichols || Goulding)
1b4993e5f2 more words more problems 2017-12-19 21:56:38 -05:00
Carol (Nichols || Goulding)
a764530433 Make a few tweaks noticed in page review 2017-12-19 16:15:07 -05:00
Carol (Nichols || Goulding)
2040d6abb6 Merge pull request #1059 from wizarrc/patch-2
Fix grammer
2017-12-19 15:50:33 -05:00
Carol (Nichols || Goulding)
b3bb2f383d Merge pull request #1051 from chenl/patch-19
Caption of Listing 16-11 should differ from 16-10
2017-12-19 15:38:59 -05:00
Chen Rotem Levy
d1260e1933 Compile error of Listing 17-10 have rust_gui::
Not sure if this was intentional to make the lines shorter, and the text more didactic, but just in the case it was an oversight...
2017-12-11 20:40:41 +02:00
Chen Rotem Levy
0cc4a56ed0 Listing 17-10: should use Screen not Draw
Even though this example should not compile, in its current form it will give the wrong compile error.
2017-12-11 20:35:02 +02:00
Thomas J. Crowe
18fd30d70f Fix grammer 2017-12-09 22:49:58 -05:00
Thomas J. Crowe
c21a4e7b31 rustc is outputting pdb file on windows
I am going though the book and noticed debug symbols are emitted but not mentioned at this point in the book. A mention of this might be helpful. Any thoughts
2017-12-08 15:51:12 -05:00
Carol (Nichols || Goulding)
2c942dc094 Merge pull request #997 from rust-lang/appendices
Draft of last two appendices: custom derive and macros.
2017-12-08 11:05:11 -05:00
Carol (Nichols || Goulding)
550c8ea6f7 fancy quotes 2017-12-08 10:53:25 -05:00
Carol (Nichols || Goulding)
643d4af370 Snapshot of appendices A-D for nostarch 2017-12-08 10:51:16 -05:00
Carol (Nichols || Goulding)
5518ffb071 Fixing text highlighting and a link 2017-12-08 10:51:11 -05:00
Carol (Nichols || Goulding)
364349a261 Copy isn't ever really required 2017-12-08 10:05:02 -05:00
Carol (Nichols || Goulding)
9c8d606310 Add a note about using struct update syntax with Default
Fixes #666.
2017-12-08 10:00:53 -05:00
Carol (Nichols || Goulding)
3769a964e8 Detail on Clone using Copy 2017-12-08 10:00:53 -05:00
Carol (Nichols || Goulding)
f1f1442aba More edits to derivable traits and macros 2017-12-08 10:00:53 -05:00
Carol (Nichols || Goulding)
dfe51e7249 Fleshing out derivable traits appendix more 2017-12-08 10:00:53 -05:00
Carol (Nichols || Goulding)
efd6a64e4a Start of derivable traits edits 2017-12-08 10:00:53 -05:00
Carol (Nichols || Goulding)
cde72e7181 even more spellingz 2017-12-08 10:00:53 -05:00