Alex Hung
e561531f2f
drm/amd/display: Fix incorrect logic in CRC source handling
...
[WHAT]
Fix three issues amdgpu_dm_crc.c:
- Use cur_crc_src instead of source when deciding whether to call
drm_dp_stop_crc() in the disable path of set_crc_source(). When
disabling CRC, source is always NONE so dm_is_crc_source_dprx(source)
was always false, meaning drm_dp_stop_crc() was never called when
stopping a DPRX CRC source. Use cur_crc_src to check what was
previously active instead.
- Replace fragile 'source < 0' comparisons in verify_crc_source() and
set_crc_source() with AMDGPU_DM_PIPE_CRC_SOURCE_INVALID.
and avoiding signed/unsigned enum comparison concerns.
- Remove redundant NULL initializations for drm_dev and acrtc in
handle_crc_irq(). Both variables are unconditionally assigned right
after.
Assisted-by: Copilot:Claude-Sonnet-4.6
Reviewed-by: Bhawanpreet Lakha <bhawanpreet.lakha@amd.com >
Signed-off-by: Alex Hung <alex.hung@amd.com >
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com >
Tested-by: Dan Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2026-06-17 16:10:09 -04:00
..
2026-06-09 23:22:33 -07:00
2026-05-19 23:06:09 +02:00
2026-04-30 23:21:31 +02:00
2026-05-18 12:26:51 +02:00
2026-04-23 12:21:14 -07:00
2026-03-27 09:54:31 +01:00
2026-05-29 00:53:14 +02:00
2026-05-20 22:09:08 +02:00
2026-05-20 16:35:47 -04:00
2026-04-24 13:23:50 -07:00
2026-04-27 15:52:51 -06:00
2026-06-08 09:58:48 +02:00
2026-04-28 20:55:53 -07:00
2026-03-20 13:36:32 +01:00
2026-04-24 13:23:50 -07:00
2026-04-06 09:04:53 +02:00
2026-05-29 00:53:14 +02:00
2026-04-14 17:10:15 -07:00
2026-04-16 17:37:03 +08:00
2026-04-17 15:52:58 -07:00
2026-04-21 14:12:01 -07:00
2026-04-04 03:15:39 +09:00
2026-03-04 18:48:15 -08:00
2026-04-17 10:29:01 -07:00
2026-06-11 20:21:44 +05:30
2026-05-20 19:02:01 -07:00
2026-05-05 14:49:48 +02:00
2026-03-20 11:20:43 +09:00
2026-03-16 19:29:45 -07:00
2026-05-23 09:13:00 -07:00
2026-03-25 14:57:26 +08:00
2026-05-19 10:44:32 -03:00
2026-04-06 09:04:53 +02:00
2026-05-21 14:36:07 +02:00
2026-06-17 16:10:09 -04:00
2026-04-02 15:55:09 +02:00
2026-05-18 13:05:41 -07:00
2026-04-02 22:33:44 +02:00
2026-04-12 23:29:31 -07:00
2026-04-24 11:44:52 -07:00
2026-05-21 07:00:39 -07:00
2026-04-06 09:43:18 -05:00
2026-04-24 13:23:50 -07:00
2026-05-19 12:43:08 +02:00
2026-04-12 22:06:02 +02:00
2026-03-11 12:52:00 +01:00
2026-04-24 13:23:50 -07:00
2026-05-23 07:17:27 -07:00
2026-04-22 18:36:40 -07:00
2026-04-07 10:06:50 +02:00
2026-05-15 07:29:16 +02:00
2026-05-21 20:11:29 +02:00
2026-04-09 13:49:19 +01:00
2026-04-18 13:10:14 -05:00
2026-05-01 11:26:15 -07:00
2026-05-04 08:33:39 +02:00
2026-04-17 11:12:42 -07:00
2026-04-20 11:31:01 -07:00
2026-04-24 13:23:50 -07:00
2026-04-10 10:29:58 +02:00
2026-04-02 17:06:09 +02:00
2026-04-27 15:08:04 +02:00
2026-04-24 13:23:50 -07:00
2026-05-21 11:03:58 -07:00
2026-04-27 18:00:43 -07:00
2026-04-15 14:41:21 -07:00
2026-04-13 10:40:26 -07:00
2026-05-21 07:49:05 -07:00
2026-04-06 09:04:53 +02:00
2026-04-18 11:29:14 -07:00
2026-05-04 11:48:12 +02:00
2026-04-02 17:05:56 +02:00
2026-05-21 15:02:12 -07:00
2026-04-23 11:22:16 -07:00
2026-04-14 16:48:56 -07:00
2026-05-19 15:42:11 +05:30
2026-05-13 09:34:55 +02:00
2026-05-22 15:45:26 -07:00
2026-04-27 14:53:30 +02:00
2026-04-19 08:47:40 -07:00
2026-04-01 16:03:05 +02:00
2026-04-02 16:33:00 +02:00
2026-03-17 19:06:19 -07:00
2026-05-27 16:24:28 +02:00
2026-05-18 10:52:24 +01:00
2026-04-17 14:18:55 -07:00
2026-05-14 09:52:05 +01:00
2026-04-28 19:03:50 -07:00
2026-04-06 09:37:51 -05:00
2026-04-25 16:39:03 -07:00
2026-05-11 16:27:25 +02:00
2026-05-22 16:08:06 -07:00
2026-03-17 20:30:57 +01:00
2026-04-17 14:18:55 -07:00
2026-04-17 10:16:53 -07:00
2026-05-22 13:19:41 -07:00
2026-05-14 14:30:01 -07:00
2026-05-14 22:21:01 -04:00
2026-04-16 20:34:34 -07:00
2026-04-14 08:55:18 -07:00
2026-04-10 13:10:28 +02:00
2026-04-19 08:44:41 -07:00
2026-04-21 20:58:06 -04:00
2026-04-05 13:53:44 -07:00
2026-05-08 17:18:43 +02:00
2026-04-04 00:47:50 +02:00
2026-05-14 11:39:03 -06:00
2026-04-23 16:50:42 -07:00
2026-05-04 10:35:55 +02:00
2026-05-20 18:03:17 -07:00
2026-04-15 12:59:16 -07:00
2026-04-03 10:55:12 +02:00
2026-04-07 21:06:59 +02:00
2026-05-12 19:01:37 +02:00
2026-04-23 10:24:02 -07:00
2026-04-23 10:24:02 -07:00