Nicolai Buchwitz d85f521a9a
net: macb: exclude software FCS from TX byte statistics ...
Frames for which macb_pad_and_fcs() supplies the FCS have four FCS
bytes appended, and TX completion then accounts the grown skb->len.
tx_bytes is defined to exclude the FCS, so these frames are reported
four bytes too large.
Track only the number of FCS bytes appended in software, 0 or
ETH_FCS_LEN, and subtract that from skb->len at completion. skb->len
already reflects the padded length by then, so there is nothing else
to store. macb_pad_and_fcs() already returns 0 on every non-error
path. Return the FCS length from there instead, rather than
recomputing the same check in the caller. BQL stays on the padded
skb->len that netdev_tx_sent_queue() saw.
Fixes: 653e92a917nb@tipi-net.de >
Link: https://patch.msgid.link/20260831113128.1678674-1-nb@tipi-net.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2026-09-02 19:22:53 -07:00
2026-08-21 08:41:00 -07:00
2026-08-26 14:06:08 -07:00
2026-08-25 09:38:50 -07:00
2026-08-23 12:44:10 -07:00
2026-08-24 08:15:59 -07:00
2026-08-27 09:17:06 -07:00
2026-08-27 09:17:06 -07:00
2026-08-31 14:05:27 -04:00
2026-08-25 09:38:50 -07:00
2026-08-25 09:38:50 -07:00
2026-08-27 10:45:08 -07:00
2026-08-26 16:47:40 -07:00
2026-08-25 09:38:50 -07:00
2026-08-26 14:13:26 -07:00
2026-08-27 10:45:08 -07:00
2026-08-24 12:21:15 -07:00
2026-08-20 18:17:08 -07:00
2026-08-12 17:08:05 -07:00
2026-08-24 12:21:15 -07:00
2026-08-20 10:58:44 +10:00
2026-08-18 10:42:41 -07:00
2026-08-18 14:02:15 -07:00
2026-08-22 08:41:28 -07:00
2026-08-25 14:03:31 -07:00
2026-08-25 09:38:50 -07:00
2026-08-14 19:21:17 -03:00
2026-08-25 09:38:50 -07:00
2026-08-19 09:10:07 -07:00
2026-08-27 09:17:06 -07:00
2026-08-24 10:16:35 -07:00
2026-08-21 12:01:23 -07:00
2026-08-26 16:47:40 -07:00
2026-08-25 09:38:50 -07:00
2026-08-25 09:38:50 -07:00
2026-08-24 09:07:15 -07:00
2026-08-19 09:28:33 +02:00
2026-08-07 21:22:50 +02:00
2026-08-26 14:21:30 -07:00
2026-08-27 13:53:43 -07:00
2026-08-25 09:38:50 -07:00
2026-08-19 09:55:37 +02:00
2026-08-24 11:35:46 -07:00
2026-08-25 09:38:50 -07:00
2026-08-23 12:44:10 -07:00
2026-08-27 11:05:51 -07:00
2026-08-23 15:41:13 -05:00
2026-08-20 13:55:16 -07:00
2026-08-25 10:44:46 -07:00
2026-08-23 09:11:21 -07:00
2026-08-27 10:45:08 -07:00
2026-08-25 09:38:50 -07:00
2026-08-21 11:58:08 -07:00
2026-08-23 09:11:21 -07:00
2026-09-02 19:22:53 -07:00
2026-08-18 10:42:41 -07:00
2026-08-20 13:43:24 -07:00
2026-08-20 17:07:50 -07:00
2026-08-24 12:21:15 -07:00
2026-08-25 09:38:50 -07:00
2026-08-27 12:53:43 -07:00
2026-08-06 11:54:14 +05:30
2026-08-18 11:43:05 +02:00
2026-08-26 16:47:40 -07:00
2026-08-20 14:53:54 -07:00
2026-08-26 11:14:30 -07:00
2026-08-24 08:46:03 -07:00
2026-08-27 10:45:08 -07:00
2026-08-26 11:14:30 -07:00
2026-08-07 20:01:31 +02:00
2026-08-26 08:45:09 -07:00
2026-08-26 14:13:26 -07:00
2026-08-22 12:34:39 -07:00
2026-08-19 10:42:18 -07:00
2026-08-27 12:21:56 -07:00
2026-08-18 11:57:17 -07:00
2026-08-26 11:14:30 -07:00
2026-09-01 16:55:04 -07:00
2026-08-26 16:47:40 -07:00
2026-08-25 14:03:31 -07:00
2026-08-24 12:16:16 -07:00
2026-08-27 12:38:05 -07:00
2026-08-25 10:16:19 -07:00
2026-08-25 10:44:46 -07:00
2026-08-18 19:40:29 -07:00
2026-08-27 10:45:08 -07:00
2026-08-19 10:01:59 +02:00
2026-08-25 10:59:12 -07:00
2026-08-21 11:23:20 -07:00
2026-08-27 13:53:43 -07:00
2026-08-19 06:38:48 -04:00
2026-08-20 18:17:08 -07:00
2026-08-20 17:07:50 -07:00
2026-08-27 11:16:39 -07:00
2026-08-18 11:57:17 -07:00
2026-08-19 06:38:47 -04:00
2026-08-06 11:08:37 +02:00
2026-08-27 10:45:08 -07:00
2026-08-24 11:35:46 -07:00
d85f521a9a