Files
linux/include/linux
Toke Høiland-Jørgensen 95920c2ed0 page_pool: Fix PP_MAGIC_MASK to avoid crashing on some 32-bit arches
Helge reported that the introduction of PP_MAGIC_MASK let to crashes on
boot on his 32-bit parisc machine. The cause of this is the mask is set
too wide, so the page_pool_page_is_pp() incurs false positives which
crashes the machine.

Just disabling the check in page_pool_is_pp() will lead to the page_pool
code itself malfunctioning; so instead of doing this, this patch changes
the define for PP_DMA_INDEX_BITS to avoid mistaking arbitrary kernel
pointers for page_pool-tagged pages.

The fix relies on the kernel pointers that alias with the pp_magic field
always being above PAGE_OFFSET. With this assumption, we can use the
lowest bit of the value of PAGE_OFFSET as the upper bound of the
PP_DMA_INDEX_MASK, which should avoid the false positives.

Because we cannot rely on PAGE_OFFSET always being a compile-time
constant, nor on it always being >0, we fall back to disabling the
dma_index storage when there are not enough bits available. This leaves
us in the situation we were in before the patch in the Fixes tag, but
only on a subset of architecture configurations. This seems to be the
best we can do until the transition to page types in complete for
page_pool pages.

v2:
- Make sure there's at least 8 bits available and that the PAGE_OFFSET
  bit calculation doesn't wrap

Link: https://lore.kernel.org/all/aMNJMFa5fDalFmtn@p100/
Fixes: ee62ce7a1d ("page_pool: Track DMA-mapped pages and unmap them when destroying the pool")
Cc: stable@vger.kernel.org # 6.15+
Tested-by: Helge Deller <deller@gmx.de>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Tested-by: Helge Deller <deller@gmx.de>
Link: https://patch.msgid.link/20250930114331.675412-1-toke@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-10-06 12:14:04 -07:00
..
2025-09-24 17:09:47 +02:00
2025-04-03 21:35:32 +02:00
2025-06-15 21:19:08 +05:30
2025-07-21 18:18:51 +01:00
2025-04-21 10:27:59 +02:00
2025-04-29 15:58:38 -04:00
2025-07-31 11:28:03 -04:00
2025-09-10 05:23:45 -06:00
2025-09-24 02:48:05 -07:00
2025-03-08 14:37:39 +01:00
2025-05-21 13:41:03 +02:00
2025-05-21 13:39:45 +02:00
2025-08-14 10:37:33 -07:00
2025-06-11 13:39:52 -04:00
2025-04-11 18:58:10 -07:00
2025-09-23 11:13:22 +02:00
2025-04-17 10:56:11 +02:00
2025-09-19 14:26:16 +02:00
2025-07-22 15:57:02 +00:00
2025-04-10 10:39:14 +01:00
2025-08-21 13:58:07 +02:00
2025-07-16 14:28:21 +02:00
2025-07-19 18:59:51 -07:00
2025-07-24 19:12:32 -07:00
2025-05-22 11:07:05 +02:00
2025-08-29 13:39:53 -07:00
2025-08-02 12:06:10 -07:00
2025-09-18 10:17:09 +02:00
2025-09-23 11:13:22 +02:00
2025-06-11 11:57:14 -07:00
2025-03-08 12:13:25 +01:00
2025-07-02 17:18:01 +01:00
2025-09-02 11:38:29 +02:00
2025-07-17 06:01:16 -06:00
2025-07-13 16:38:24 -07:00
2025-07-09 22:41:56 -07:00
2025-06-17 18:18:46 -07:00
2025-03-17 13:54:50 +00:00
2025-07-14 15:20:02 -07:00
2025-07-14 15:20:02 -07:00
2025-07-08 19:11:57 -04:00
2025-09-19 14:26:16 +02:00
2025-09-25 09:23:47 +02:00
2025-07-31 16:11:43 -05:00
2025-05-21 16:46:37 +02:00
2025-10-03 10:24:14 -07:00
2025-06-19 14:28:24 +02:00
2025-06-19 14:28:24 +02:00
2025-03-10 08:53:40 +01:00
2025-07-22 18:07:11 +02:00
2025-03-12 20:41:14 +01:00
2025-08-24 11:41:11 -06:00
2025-07-01 12:29:29 +02:00
2025-05-03 12:02:04 +02:00
2025-05-11 17:54:09 -07:00
2025-05-06 11:11:45 -06:00
2025-03-17 11:52:25 +01:00
2025-04-25 15:53:59 +02:00
2025-08-28 13:14:50 +02:00
2025-04-10 18:34:05 -07:00
2025-07-19 10:17:56 +05:30
2025-09-19 17:19:45 -07:00
2025-07-23 11:56:02 +02:00
2025-03-20 08:00:50 -07:00
2025-06-26 09:44:45 -07:00
2025-09-09 10:27:01 -06:00
2025-07-17 11:26:56 +02:00
2025-08-02 12:01:37 -07:00
2025-03-13 13:25:58 -07:00
2025-03-13 13:25:58 -07:00
2025-03-13 13:25:58 -07:00