Umang Jain
fbaf8bf6cb
staging: vchiq_core: Simplify vchiq_bulk_transfer()
...
Factor out core logic for preparing bulk data transfer(mutex locking,
waits on vchiq_bulk_queue wait-queue, initialising the bulk transfer)
out of the vchiq_bulk_transfer(). This simplifies the existing
vchiq_bulk_transfer() and makes it more readable since all the core
logic is handled in vchiq_bulk_xfer_queue_msg_interruptible(). It
will also help us to refactor vchiq_bulk_transfer() easily for different
vchiq bulk transfer modes.
No functional changes intended in this patch.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Tested-by: Stefan Wahren <wahrenst@gmx.net >
Link: https://lore.kernel.org/r/20240910051007.297227-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-11 15:54:04 +02:00
Umang Jain
27056fef61
staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITING
...
The bulk transfer is VCHIQ_BULK_MODE_WAITING is used by VCHIQ ioctl
interface. It is factored out to a separate function from
vchiq_bulk_transfer() to bulk_xfer_waiting_interruptible().
This is a part of vchiq_bulk_transfer refactoring. Each bulk mode
will have their dedicated functions to execute bulk transfers.
Each mode will be handled separately in subsequent patches.
bulk_xfer_waiting_interruptible() is suffixed with "_interruptible"
to denote that it can be interrupted when a signal is received.
-EAGAIN maybe returned in those cases, similar to what
vchiq_bulk_transfer() does.
Adjust the vchiq_irq_queue_bulk_tx_rx() in the vchiq-dev.c to call
bulk_xfer_waiting_interruptible() for waiting mode. A temporary
goto label has been introduced to jump the call execution over
vchiq_bulk_transfer() for waiting mode only. When all dedicated bulk
transfer calls are introduced, this label shall be dropped.
No function changes intended in this patch.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Tested-by: Stefan Wahren <wahrenst@gmx.net >
Link: https://lore.kernel.org/r/20240910051007.297227-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-11 15:54:04 +02:00
Riyan Dhiman
fa42410edb
staging: vme_user: changed geoid data type from int to u32
...
Geoid is a module parameter which is set by root user.
Its valid values are between 0 and VME_MAX_SLOTS. So, changing data type
of geoid from int to u32 since it will always be positive.
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com >
Link: https://lore.kernel.org/r/20240903114849.4953-3-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-05 16:45:01 +02:00
vivek t s
59e574141f
Staging: rtl8723bs: Rename function SelectChannel()
...
Rename function SelectChannel() to r8723bs_select_channel(), to avoid
CamelCase and to improve cleanliness of the global namespace.
Signed-off-by: vivek t s <vivek6429.ts@gmail.com >
Link: https://lore.kernel.org/r/ZtmD8i7YZLRIcaI9@victor-IdeaPad-Gaming-3-16IAH7
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-05 16:44:59 +02:00
Roshan Khatri
5159b05a43
staging: rtl8723bs: include: Fix spelling mistake in rtw_event.h
...
This patch fixes spelling mistake to increase code readability
and searching.
Signed-off-by: Roshan Khatri <topofeverest8848@gmail.com >
Link: https://lore.kernel.org/r/20240905134536.4364-1-topofeverest8848@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-05 16:44:21 +02:00
Roshan Khatri
43d9821c60
staging: rtl8723bs: include: Fix spelling mistake in rtl8723b_hal.h
...
This patch fixes spelling mistake to increase code readability
and searching.
Signed-off-by: Roshan Khatri <topofeverest8848@gmail.com >
Link: https://lore.kernel.org/r/20240905112720.3141-1-topofeverest8848@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-05 16:43:33 +02:00
Qianqiang Liu
cd0920ebab
staging: rtl8723bs: Remove an unused struct in rtw_cmd.h
...
struct getcountjudge_rsp is not used, just remove it.
Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com >
Link: https://lore.kernel.org/r/20240903014402.170750-1-qianqiang.liu@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:36:10 +02:00
Steven Davis
30db8460f9
staging: greybus: Fix capitalization and punctuation inconsistencies
...
There were a lot of inconsistencies in outputs and
comments, some were properly formatted and
capitalized, and some weren't. This patch resolves
this by properly formatting the inconsistent comments
and outputs.
Signed-off-by: Steven Davis <goldside000@outlook.com >
Link: https://lore.kernel.org/r/SJ2P223MB102660087EA9382BE5287FDBF7912@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COM
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:36:03 +02:00
Colin Ian King
fde40290ed
staging: rtl8723bs: Remove trailing space after \n newline
...
There is a extraneous space after a newline in a netdev_dbg message.
Remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com >
Link: https://lore.kernel.org/r/20240901161534.143887-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:35:47 +02:00
Riyan Dhiman
ae26a4cc10
staging: rtl8192e: Constify struct pci_device_id
...
static variable struct pci_device_id rtl8192_pci_id_tbl is not modified
in file rtl_core.c.
Constifying this structure moves some data to a read-only section, so
increase overall security.
Before
======
text data bss dec hex filename
17838 893 1 18732 492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o
After
=====
text data bss dec hex filename
18006 725 1 18732 492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240831160831.121720-1-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:34:51 +02:00
Tree Davies
f48404522f
Staging: rtl8192e: Add spaces around operators.
...
Add spaces around arithmetic and bitwise operators to improve
readability of the code.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20240830020508.532945-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:34:25 +02:00
Tree Davies
6c14d5ddc6
Staging: rtl8192e: Rename variable bHwError
...
Rename variable bHwError to hw_error
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240830020508.532945-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:34:24 +02:00
Tree Davies
9d21254c94
Staging: rtl8192e: Rename variable pNetwork
...
Rename variable pNetwork to network
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240830020508.532945-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:34:24 +02:00
Gabriel Tassinari
37d1e01a61
staging: rtl8192e: Fix parenthesis alignment in rtl_core.c
...
fix parenthesis alignment in _rtl92e_qos_handle_probe_response to
silence checkpatch warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Gabriel Tassinari <gabrieldtassinari@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240829214031.4893-1-gabrieldtassinari@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:33:35 +02:00
Alien Wesley
eea0007f6a
staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c
...
Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.
CHECK: Assignment operator '=' should be on the previous line.
Signed-off-by: Alien Wesley <alienwesley51@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240829123251.83574-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:33:26 +02:00
Alien Wesley
35c75ce7a7
staging: rtl8192e: Fix multiple assignments in rtl_wx.c
...
Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.
CHECK: multiple assignments should be avoided.
Signed-off-by: Alien Wesley <alienwesley51@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240829113606.76645-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:33:23 +02:00
Yang Yingliang
0348e117d9
staging: greybus: spi: switch to use spi_alloc_host()
...
Switch to use modern name function spi_alloc_host().
No functional changed.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com >
Link: https://lore.kernel.org/r/20240902125947.1368-7-yangyingliang@huaweicloud.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:32:50 +02:00
Michael Straube
357c468552
staging: rtl8192e: adjust size of RxMIMOSignalStrength
...
The array RxMIMOSignalStrength in struct rtllib_rx_stats is always accessed
with indices in the range i = 0; i < 2. We can reduce the size from 4 to 2.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240831100809.29173-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:31:56 +02:00
Michael Straube
ad796f708d
staging: rtl8192e: adjust size of brfpath_rxenable for new RF90_PATH_MAX
...
The array brfpath_rxenable in struct r8192_priv is always accessed by
indices in the range i = 0; i < RF90_PATH_MAX. A previous patch changed the
value of RF90_PATH_MAX from 4 to 2, so we can reduce the size of
brfpath_rxenable to 2. Use RF90_PATH_MAX instead of a hard-coded size.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240831100809.29173-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:31:56 +02:00
Michael Straube
12ce200da9
staging: rtl8192e: adjust size of trsw_gain_X for new RF90_PATH_MAX
...
The array trsw_gain_X in struct phy_sts_ofdm_819xpci is always accessed by
indices in the range i = 0; i < RF90_PATH_MAX. A previous patch changed the
value of RF90_PATH_MAX from 4 to 2, so we can reduce the size of
trsw_gain_X to 2. Use RF90_PATH_MAX instead of a hard-coded size.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240831100809.29173-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:31:56 +02:00
Michael Straube
24f7977e83
staging: rtl8192e: adjust size of rx_pwr for new RF90_PATH_MAX
...
The local array rx_pwr in the function _rtl92e_query_rxphystatus() is
always accessed by indices in the range i = 0; i < RF90_PATH_MAX.
A previous patch changed the value of RF90_PATH_MAX from 4 to 2, so we can
reduce the size of rx_pwr to 2. Use RF90_PATH_MAX instead of a hard-coded
size.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240831100809.29173-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:31:56 +02:00
Michael Straube
a5d1b523ad
staging: rtl8192e: remove RF90_PATH_{C,D} from enum rf90_radio_path
...
RF90_PATH_C and RF90_PATH_D are unused in this driver. Remove them
from enum rf90_radio_path.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240831100809.29173-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-09-03 10:31:56 +02:00
Manisha Singh
b7059df44f
staging: rtl8712: Calculate size from pointer
...
Calculate the size from the pointer instead of struct to adhere to kernel
coding style.
Signed-off-by: Manisha Singh <masingh.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240828222153.68062-4-masingh.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:56:16 +02:00
Manisha Singh
399763befd
staging: rtl8712: Fix style issues in rtl871x_io.c
...
Refactor the _init_intf_hdl() function to avoid multiple
assignments in a single statement. This change improves code readability
and adheres to kernel coding style guidelines.
Signed-off-by: Manisha Singh <masingh.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240828222153.68062-2-masingh.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:56:16 +02:00
Dorine Tipo
218683bcfb
staging: rtl8712: Align parenthesis in usb_ops_linux.c
...
Fix the parenthesis alignment in r8712_read_port() function to match
the opening parenthesis.
This improves code readability and adheres to the kernel coding style.
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240828082935.GA3815@ubuntu-focal
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:56:12 +02:00
Dominik Karol Piątkowski
7b6ff621e8
staging: vt6655: Fix block comment alignment
...
This patch fixes the "Block comments should align the * on each line"
warning detected by checkpatch.pl.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com >
Link: https://lore.kernel.org/r/20240828145923.78004-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:56:07 +02:00
Dominik Karol Piątkowski
091dbb7e5d
staging: vt6655: Update maintainer in TODO
...
Commit ed394dbf53 replaced Forest Bond
with Philipp Hortmann as vt665X maintainer in MAINTAINERS, but
drivers/staging/vt6655/TODO was not changed, rendering it stale. This
patch fixes it.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com >
Link: https://lore.kernel.org/r/20240828144545.76022-1-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:56:04 +02:00
Riyan Dhiman
a8a8b54350
staging: vme_user: added bound check to geoid
...
The geoid is a module parameter that allows users to hardcode the slot number.
A bound check for geoid was added in the probe function because only values
between 0 and less than VME_MAX_SLOT are valid.
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org >
Link: https://lore.kernel.org/r/20240827125604.42771-2-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:55 +02:00
Tree Davies
c692c1b77b
Staging: rtl8192e: Rename variable bCmdOrInit
...
Rename variable bCmdOrInit to cmd_or_init
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240826001724.274811-7-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:21 +02:00
Tree Davies
56c3350b01
Staging: rtl8192e: Rename variable msDelay
...
Rename variable msDelay to ms_delay
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240826001724.274811-6-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:21 +02:00
Tree Davies
966ae15a9b
Staging: rtl8192e: Rename variable CmdID
...
Rename variable CmdID to cmd_id
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240826001724.274811-5-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:20 +02:00
Tree Davies
0b5b0dd078
Staging: rtl8192e: Rename variable CmdID_RF_WriteReg
...
Rename variable CmdID_RF_WriteReg to cmd_id_rf_write_reg
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240826001724.274811-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:20 +02:00
Tree Davies
b3a13ff885
Staging: rtl8192e: Rename variable bLastIniPkt
...
Rename variable bLastIniPkt to last_ini_pkt
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240826001724.274811-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:20 +02:00
Tree Davies
fc16bd7950
Staging: rtl8192e: Rename variable CurPsLevel
...
Rename variable CurPsLevel to cur_ps_level
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20240826001724.274811-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-29 11:55:20 +02:00
Simon Horman
b0b79119ce
staging: rtl8192e: remove set but otherwise unused local variable iv16
...
Since the commit 5f1a6826ea ("staging: rtl8192e: remove set but
otherwise unused local variable iv32"), the local variable iv16 is set
but otherwise unused. So remove it.
Compile tested only.
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202408232049.UJef268y-lkp@intel.com/
Signed-off-by: Simon Horman <horms@kernel.org >
Link: https://lore.kernel.org/r/20240823-rtl8192e-iv16-v1-1-000702673065@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-24 13:42:44 +08:00
Gabriel Maciel Raad
5315266844
Staging: rtl8192e: Remove unnecessary blank line
...
Remove unneeded blank line in rtl92e_leisure_ps_enter to silence the
folowing checkpatch.pl warning:
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Gabriel Maciel Raad <ffunctor@gmail.com >
Link: https://lore.kernel.org/r/20240823000838.8207-3-ffunctor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-23 09:17:33 +08:00
Gabriel Maciel Raad
4626eb9ad8
Staging: rtl8192e: Fix parenthesis alignment
...
Fix parenthesis alingment in rtl92e_leisure_ps_enter to silence the
following checkpatch.pl warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Gabriel Maciel Raad <ffunctor@gmail.com >
Link: https://lore.kernel.org/r/20240823000838.8207-2-ffunctor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-23 09:17:33 +08:00
Ana Carolina Hernandes
2b05e9c6be
Staging: rtl8192e: Fix arguments alignment
...
Fix the alignment of arguments in function _rtl92e_query_rxphystatus in
order to silence the following checkpatch warning:
CHECK: Lines should not end with a '('
Signed-off-by: Ana Carolina Hernandes <anachan.01h@gmail.com >
Link: https://lore.kernel.org/r/20240822202727.18882-1-anachan.01h@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-23 09:17:26 +08:00
Alien Wesley
0c0b453c6e
staging: rtl8192e: Fix Assignment operator '=' in rtl_dm.c:1488
...
Removed enter before operator '=' in rtl_dm.c:1488 in order to silence the
following checkpatch warning.
CHECK: Assignment operator '=' should be on the previous line
Signed-off-by: Alien Wesley <alienwesley51@gmail.com >
Link: https://lore.kernel.org/r/20240822163057.14114-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-23 09:17:00 +08:00
Colin Ian King
1eff40c209
staging: rtl8723bs: make read-only array dot11_rate_table static const
...
Don't populate the read-only array dot11_rate_table on the stack at
run time, instead make it static const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com >
Link: https://lore.kernel.org/r/20240822163052.636570-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-23 09:16:45 +08:00
Hans Buss
5e24979acf
staging: rtl8192e: Insert spaces around '|'
...
Insert spaces around '|' to adhre to Linux kernel coding style.
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Hans Buss <hans.buss@mailfence.com >
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org >
Link: https://lore.kernel.org/r/20240822143837.37768-1-hansbh123@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-23 09:16:32 +08:00
Alien Wesley
1a88217a19
staging: rtl8192e: Fix blank line
...
Removed blank line in r8192E_dev.c in order to silence the
following checkpatch warning.
CHECK: Please don't use multiple blank lines
Signed-off-by: Alien Wesley <alienwesley51@gmail.com >
Link: https://lore.kernel.org/r/20240822010456.20186-1-alienwesley51@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:53:54 +08:00
Túlio Fernandes
6673f43370
staging: rtl8192e: Fix parenthesis alignment
...
Fix parenthesis alignment in rtl92e_set_rf_state in order to rid
the following warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Túlio Fernandes <tuliomf09@gmail.com >
Link: https://lore.kernel.org/r/20240822004558.14638-1-tuliomf09@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:53:49 +08:00
Pedro Orlando
22ea3a4b30
staging: rtl8192e: Fix parenthesis alignment
...
Fix parenthesis alignment in _rtl92e_wx_set_encode_ext to fix
checkpatch warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Pedro Orlando <scramblerdoodle@gmail.com >
Link: https://lore.kernel.org/r/20240822002658.33672-1-scramblerdoodle@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:51:35 +08:00
Christian S Lima
e79bb28bf7
staging: rtl8192e: fix parenthesis alignment
...
fix line 1326 in order to silence warning
CHECK: Alignment should match open parenthesis
Signed-off-by: Christian S Lima <christiansantoslima21@gmail.com >
Link: https://lore.kernel.org/r/20240822002620.63732-1-christiansantoslima21@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:51:14 +08:00
João Pedro Leôncio
fca7bee615
staging: rtl8192e: Fix line ended with '('
...
Fix line ended with '(' in _rtl92e_update_received_rate_histogram_stats
in order to silence the following checkpat warning:
CHECK: Lines should not end with a '('
Signed-off-by: João Pedro Leôncio <aljpleoncio@gmail.com >
Link: https://lore.kernel.org/r/20240822002502.92583-1-aljpleoncio@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:50:08 +08:00
thdecamargoj
a59907219b
staging: rtl8192e: change logical continuation to previous line on file r8192E_dev.c
...
Change logical continuation to previous line to silence checkpatch
warning:
CHECK: Logical continuations should be on the previous line
Signed-off-by: thdecamargoj <thdecamargoj@gmail.com >
Link: https://lore.kernel.org/r/20240822002403.268452-1-thdecamargoj@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:50:01 +08:00
Vinicius Peixoto
cfb05827ef
staging: rtl8192e: Fix parenthesis alignment
...
Fix parenthesis alignment in rtl92e_init_gain in order to silence the
following checkpatch warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Vinicius Peixoto <vpeixoto@lkcamp.dev >
Link: https://lore.kernel.org/r/20240822002346.94433-1-vpeixoto@lkcamp.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:49:45 +08:00
Leonardo Kenji
8a07f476bd
staging: rtl8192e: Fix parenthesis alignment
...
Fix parenthesis alignment in _rtl92e_read_eeprom_info in order to
silence the following checkpatch warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Leonardo Kenji <leokk06@gmail.com >
Link: https://lore.kernel.org/r/20240822002543.44835-1-leokk06@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:49:41 +08:00
Yuesong Li
94f7f4b90d
staging: vme: vme_user: Remove NULL check of list_entry()
...
list_entry() will never return a NULL pointer, thus remove the
check.
Signed-off-by: Yuesong Li <liyuesong@vivo.com >
Link: https://lore.kernel.org/r/20240822025736.1208339-1-liyuesong@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-08-22 15:48:05 +08:00