Michael Straube
f606b319ef
staging: r8188eu: remove unused fields from struct hal_data_8188e
...
Remove unused fields from struct hal_data_8188e.
Acked-by: Martin Kaiser <martin@kaiser.cx >
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220101084937.3411-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-03 14:30:36 +01:00
Michael Straube
cfd060fe2e
staging: r8188eu: bAPKThermalMeterIgnore is set but never used
...
The field bAPKThermalMeterIgnore of struct hal_data_8188e is set but
never used. Remove it.
Acked-by: Martin Kaiser <martin@kaiser.cx >
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220101084937.3411-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-03 14:30:36 +01:00
Michael Straube
a056e41a09
staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used
...
The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set
but never used. Remove it.
Acked-by: Martin Kaiser <martin@kaiser.cx >
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220101084937.3411-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-03 14:30:36 +01:00
Michael Straube
ffcdb1b194
staging: r8188eu: UsbRxHighSpeedMode is set but never used
...
The field UsbRxHighSpeedMode of struct hal_data_8188e is set but
never used. Remove it.
Acked-by: Martin Kaiser <martin@kaiser.cx >
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220101084937.3411-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-03 14:30:36 +01:00
Michael Straube
b376bd6377
staging: r8188eu: bRDGEnable is always false
...
The field bRDGEnable in struct hal_data_8188e is never set. It stays
at its default value 0. Remove bRDGEnable and related dead code.
Acked-by: Martin Kaiser <martin@kaiser.cx >
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220101084937.3411-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-03 14:30:36 +01:00
Paulo Miguel Almeida
a0c43a4692
staging: pi433: add docs to packet_format and tx_start_condition enum
...
While pi433 driver deals with the nuances of the different possible
config combinations, it's hard (at first) to understand the rationale
for some of the tx/rx-related source code unless you're fairly familiar
with the rf69's inner workings.
This patch documents the expected behaviour and limits of both
packet_format and tx_start_condition enum fields.
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com >
Link: https://lore.kernel.org/r/20211231001933.GA6779@mail.google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-03 14:30:01 +01:00
Gaston Gonzalez
12b31d07b0
staging: vc04_services: update TODO file
...
There are no struct typedef remaining inside vc04_services/. Hence, remove the
task from the TODO file.
While at it, fix the items sequential numbering.
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com >
Link: https://lore.kernel.org/r/3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 14:19:53 +01:00
Gaston Gonzalez
072590cc4f
staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers
...
Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to
better align with the linux kernel coding style.
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com >
Link: https://lore.kernel.org/r/0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 14:19:53 +01:00
Gaston Gonzalez
95b47a0467
staging: vc04_services: bcm2835-audio: avoid the use of typedef for function pointers
...
Replace typedefs bcm2835_audio_newpcm_func and bcm2835_audio_newctl_func
with equivalent declarations to better align with the linux kernel
coding style.
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com >
Link: https://lore.kernel.org/r/b53a77682994bbc3ccb9b89d617dec23d0785059.1640776340.git.gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 14:19:53 +01:00
Michael Straube
512cdc60e6
staging: r8188eu: remove header odm_precomp.h
...
After previous cleanups the header odm_precomp.h only contains
includes and one unused define now. Remove the header and adjust
the includes in affected files.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-33-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:27 +01:00
Michael Straube
489257e683
staging: r8188eu: remove unnecessary comments
...
Remove some unnecessary comments in odm.c.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-32-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:27 +01:00
Michael Straube
dc481cb55b
staging: r8188eu: make odm_EdcaTurboCheck() static
...
Function odm_EdcaTurboCheck() is only used in odm.c. Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-31-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:27 +01:00
Michael Straube
f24eec9cd6
staging: r8188eu: make ODM_EdcaTurboInit() static
...
Function ODM_EdcaTurboInit() is only used in odm.c. Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-30-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:27 +01:00
Michael Straube
bccd2be784
staging: r8188eu: make odm_HwAntDiv() static
...
Function odm_HwAntDiv() is only used in odm.c. Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-29-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:27 +01:00
Michael Straube
42f88b7927
staging: r8188eu: make odm_InitHybridAntDiv() static
...
Function odm_InitHybridAntDiv() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-28-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:27 +01:00
Michael Straube
0956ab4d36
staging: r8188eu: make odm_TXPowerTrackingThermalMeterInit() static
...
Function odm_TXPowerTrackingThermalMeterInit() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-27-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
52a4ccac8a
staging: r8188eu: remove odm_TXPowerTrackingInit()
...
odm_TXPowerTrackingInit() is just a wrapper around
odm_TXPowerTrackingThermalMeterInit(). Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-26-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
b0515ff422
staging: r8188eu: make odm_RSSIMonitorCheck() static
...
Function odm_RSSIMonitorCheck() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-25-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
9afafc05a7
staging: r8188eu: make odm_CCKPacketDetectionThresh() static
...
Function odm_CCKPacketDetectionThresh() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-24-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
86f0bea75f
staging: r8188eu: make odm_FalseAlarmCounterStatistics() static
...
Function odm_FalseAlarmCounterStatistics() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-23-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
e6b5ad5eeb
staging: r8188eu: make odm_DynamicBBPowerSavingInit() static
...
Function odm_DynamicBBPowerSavingInit() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-22-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
78865587d0
staging: r8188eu: make odm_RefreshRateAdaptiveMask() static
...
Function odm_RefreshRateAdaptiveMask() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-21-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
b82d0bc677
staging: r8188eu: make odm_RateAdaptiveMaskInit() static
...
Function odm_RateAdaptiveMaskInit() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-20-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
5ab68d92cd
staging: r8188eu: make odm_CommonInfoSelfUpdate() static
...
Function odm_CommonInfoSelfUpdate() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-19-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
7d3cbea175
staging: r8188eu: make odm_CommonInfoSelfInit() static
...
Function odm_CommonInfoSelfInit() is only used in odm.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-18-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
8badd69b53
staging: r8188eu: make odm_DIG() static
...
Function odm_DIG() is used only in odm.c. Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-17-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
51d260d242
staging: r8188eu: make odm_DIGInit() static
...
Function odm_DIGInit() is used only in odm.c. Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-16-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:26 +01:00
Michael Straube
b1be5b8ff9
staging: r8188eu: remove unused prototypes
...
Remove some unused function prototypes.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-15-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
106a28479d
staging: r8188eu: make odm_ConfigRFReg_8188E() static
...
Function odm_ConfigRFReg_8188E() is only used in odm_RegConfig8188E.c.
Make it static.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-14-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
1bcf699d22
staging: r8188eu: remove odm_interface
...
After previous cleanups the file odm_interface.c is emtpy now
and the header odm_interface.h just contains an unused typedef.
Remove both files.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-13-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
85dbc7e3ab
staging: r8188eu: remove ODM_CompareMemory()
...
ODM_CompareMemory() is just a wrapper around memcmp().
Remove ODM_CompareMemory() and call memcmp() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-12-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
fec9f472fb
staging: r8188eu: remove ODM_delay_ms()
...
ODM_delay_ms() is just a wrapper around mdelay().
Remove ODM_delay_ms() and call mdelay() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-11-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
2e0ed5adb9
staging: r8188eu: remove ODM_delay_us()
...
ODM_delay_us() is just a wrapper around udelay().
Remove ODM_delay_us() and call udelay() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-10-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
182861b149
staging: r8188eu: remove ODM_sleep_ms()
...
ODM_sleep_ms() is just a wrapper around msleep().
Remove ODM_sleep_ms() and call msleep() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-9-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
420108ef3b
staging: r8188eu: clean up coding style issues
...
Clean up coding style issues in odm_ConfigRFReg_8188E() reported by
checkpatch.
WARNING: please, no spaces at the start of a line
WARNING: suspect code indent for conditional statements (4, 16)
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
502ddefa50
staging: r8188eu: remove ODM_SetBBReg()
...
ODM_SetBBReg() is just a wrapper around rtl8188e_PHY_SetBBReg().
Remove ODM_SetBBReg() and call rtl8188e_PHY_SetBBReg() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
8aedc08edf
staging: r8188eu: remove ODM_GetBBReg()
...
ODM_GetBBReg() is just a wrapper around rtl8188e_PHY_QueryBBReg().
Remove ODM_GetBBReg() and call rtl8188e_PHY_QueryBBReg() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
4c4ab3f449
staging: r8188eu: remove ODM_SetRFReg()
...
ODM_SetRFReg() is just a wrapper around rtl8188e_PHY_SetRFReg().
Remove ODM_SetRFReg() and call rtl8188e_PHY_SetRFReg() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
e83545b1ae
staging: r8188eu: remove ODM_GetRFReg()
...
ODM_GetRFReg() is just a wrapper around rtl8188e_PHY_QueryRFReg().
Remove ODM_GetRFReg() and call rtl8188e_PHY_QueryRFReg() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
0575b39908
staging: r8188eu: remove ODM_GetMACReg()
...
ODM_GetMACReg() is just a wrapper around rtl8188e_PHY_QueryBBReg().
Remove ODM_GetMACReg() and call rtl8188e_PHY_QueryBBReg() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:25 +01:00
Michael Straube
9d68ce358c
staging: r8188eu: remove ODM_SetMACReg()
...
ODM_SetMACReg() is just a wrapper around rtl8188e_PHY_SetBBReg().
Remove ODM_SetMACReg() and call rtl8188e_PHY_SetBBReg() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211229205108.26373-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 12:02:24 +01:00
Lad Prabhakar
790ada0e6e
staging: axis-fifo: Use platform_get_irq() to get the interrupt
...
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.
In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com >
Link: https://lore.kernel.org/r/20211224161334.31123-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 11:54:56 +01:00
Greg Kroah-Hartman
683fade1a2
staging: greybus: auto_manager: use default_groups in kobj_type
...
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field. Move the greybus audio code to use default_groups field which
has been the preferred way since aa30f47cf6 ("kobject: Add support for
default attribute groups to kobj_type") so that we can soon get rid of
the obsolete default_attrs field.
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com >
Cc: Johan Hovold <johan@kernel.org >
Reviewed-by: Alex Elder <elder@linaro.org >
Acked-by: Mark Greer <mgreer@animalcreek.com >
Link: https://lore.kernel.org/r/20211228135541.380275-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-30 11:54:26 +01:00
Michael Straube
20a77667bb
staging: r8188eu: merge _ReadLEDSetting() into ReadAdapterInfo8188EU()
...
Function _ReadLEDSetting() sets only a single variable and the only
user is ReadAdapterInfo8188EU(). Remove _ReadLEDSetting() and set the
variable in ReadAdapterInfo8188EU() directly.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-11-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:29 +01:00
Michael Straube
6a3631bdac
staging: r8188eu: RSSI_test is always false
...
The field RSSI_test of struct odm_dm_struct is never set. It stays
at the default value 0. Remove it and remove a related if test that
is always true.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-10-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:29 +01:00
Michael Straube
f4b1b1f333
staging: r8188eu: TrainIdx is set but never used
...
The field TrainIdx of struct fast_ant_train is set but never used.
Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-9-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:29 +01:00
Michael Straube
6afdd3ca9c
staging: r8188eu: FAT_State is set but never used
...
The field FAT_State of struct fast_ant_train is set but never used.
Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:29 +01:00
Michael Straube
a4a44a1c15
staging: r8188eu: FAT_State is always FAT_NORMAL_STATE
...
In this driver pDM_FatTable->FAT_State is always FAT_NORMAL_STATE.
So the check 'if (pDM_FatTable->FAT_State == FAT_TRAINING_STATE)'
is always false. Remove dead code that is executed only if that
check is true.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:29 +01:00
Michael Straube
9e357d4c8f
staging: r8188eu: remove write-only fields from struct rtl_ps
...
The fields pre_cca_state, cur_cca_state and rssi_val_min of struct
rtl_ps are set but never used. Remove them.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:28 +01:00
Michael Straube
f795060dd4
staging: r8188eu: remove ODM_CMNINFO_ABILITY from ODM_CmnInfoInit()
...
ODM_CmnInfoInit() is never called with ODM_CMNINFO_ABILITY.
Remove that unused case from ODM_CmnInfoInit().
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211228101120.9120-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-12-28 17:14:28 +01:00