Deepak R Varma
f54df47919
staging: fbtft: Avoid potential precedence issues
...
Put parentheses around uses of macro parameters to avoid possible
precedence issues. Problem detected by checkpatch.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/5c8520a5c3da453460608deee9a25232d52f4513.1584314604.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:47:24 +01:00
Deepak R Varma
f19234ca8b
staging: fbtft: simplify array index computation
...
An array index is being computed by mathematical calculation on the
Lvalue side of the expression. This also further results in the statement
exceeding 80 character statement length.
A local variable can store the value of the array index computation. The
variable can then be used as array index. This improves readability of
the code and also address 80 character warning raised by checkpatch.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/4bf407e1b3e05745f767b2bad6218c9fb836d869.1584314604.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:47:24 +01:00
Deepak R Varma
b32d2fb2be
staging: fbtft: Reformat long macro definitions
...
Multiple macro definitions crossing 80 character line length makes them
hard to understand. Reformatting the these lines makes the code more
readable and easier to understand. Issue flagged by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/b8d2fc0f55339830694ee51860cc970ce1b9cae4.1584314604.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:47:24 +01:00
Deepak R Varma
1293b4aa0e
staging: fbtft: Reformat line over 80 characters
...
A long variable name beyond 80 characters extends into the next
line. Reformatting the line makes it more readable. Also adding an extra
line for the next instruction following current if block helps
understand it better.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/027ccfa893feafc25da273b4b4de444d7a466cfd.1584314603.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:47:24 +01:00
Shreeya Patel
9a27592d16
Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions
...
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Link: https://lore.kernel.org/r/20200313104920.19974-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:39:40 +01:00
Shreeya Patel
af68516eb9
Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions
...
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Also, remove the unnecessary else-if condition since it does nothing.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200313102912.17218-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:39:40 +01:00
Deepak R Varma
b01e01351c
staging: comedi: dt3000: Reformat multiple line dereference
...
Reformat multiple line dereferences for &cmd->scan_begin_arg. Problem
detected by checkpatch.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200314135852.GA6336@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:04 +01:00
Deepak R Varma
6f0c6989d7
staging: comedi: ni_atmio16d: remove commented code blocks
...
Remove two if# 0 directive code blocks. Problem detected by
checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200314174316.GA10615@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:04 +01:00
Deepak R Varma
f80ac69d32
staging: comedi: ni_mio_common: Code reformat and re-indentation
...
Resolve general code indentation problems as detected by checkpatch script.
Implement code reformat and re-indentation as per coding style to
improve readability.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200314210749.GA3393@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:03 +01:00
Deepak R Varma
073e0be325
staging: comedi: s626: Reformat function arguments
...
Reformat function call arguments to comedi_check_trigger_arg_min
as per coding style guideline. Problem detected by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200314213856.GA3874@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:03 +01:00
Deepak R Varma
df42b8f493
staging: comedi: rtd520: Resolve multiline dereference
...
Reformat multi-line dereferencing of function arguments
&cmd->scan_begin_arg. Problem detected by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200314214154.GA3904@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:03 +01:00
Deepak R Varma
45621fc9dd
staging: comedi: ni_tio: Reformat function call arguments
...
Reformat function call arguments so that the function call is clearly
visible. Issue detected by checkpatch.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200314214254.GA3941@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:03 +01:00
Oscar Carter
d8dd36459d
staging: vt6656: Use BIT_ULL() macro instead of bit shift operation
...
Replace the bit left shift operation with the BIT_ULL() macro and remove
the unnecessary mask off operation against the bit_nr variable.
This mask is only there for legacy reasons. Originally it was 31 (0x1f)
and the bit_nr variable spread across an mc_filter array with two u32
elements. Now, this mask is not needed because its value is 0x3f and the
mc_filter variable is an u64 type.
In this situation, the 26 bit right shift operation against the value
returned by the ether_crc function set the bit_nr variable to the
following value:
bit 31 to bit 6 -> All 0 (due to the bit shift operation happens over an
unsigned type).
bit 5 to bit 0 -> The 6 msb bits of the value returned by the ether_crc
function.
The purpose of the 0x3f mask against the bit_nr variable is to reset
(set to 0) the 26 msb bits (bit 31 to bit 6), but these bits are yet 0.
So, the mask off operation is now unnecessary.
Signed-off-by: Oscar Carter <oscar.carter@gmx.com >
Link: https://lore.kernel.org/r/20200314161441.4870-1-oscar.carter@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-17 12:28:03 +01:00
R Veera Kumar
c15e7f0722
staging: rtl8712: Fixes for simple typos in C comments
...
Fixes for simple typos in C comments.
Found using checkpatch.pl.
Signed-off-by: R Veera Kumar <vkor@vkten.in >
Link: https://lore.kernel.org/r/20200312091042.GA4246@tulip.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 12:54:34 +01:00
Shreeya Patel
6e436169a7
Staging: rtl8188eu: rtw_mlme: Add space around operators
...
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200311131742.31068-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:27:46 +01:00
Takashi Iwai
038341dc5f
staging: rtl8723bs: Use scnprintf() for avoiding potential buffer overflow
...
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://lore.kernel.org/r/20200311092451.23933-4-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:59 +01:00
Takashi Iwai
39ddadf14d
staging: rtl8192e: Use scnprintf() for avoiding potential buffer overflow
...
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://lore.kernel.org/r/20200311092451.23933-3-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:59 +01:00
Takashi Iwai
72e7375caf
staging: rtl8188eu: Use scnprintf() for avoiding potential buffer overflow
...
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://lore.kernel.org/r/20200311092451.23933-2-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:59 +01:00
Takashi Iwai
234ff54287
staging: most: core: Use scnprintf() for avoiding potential buffer overflow
...
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://lore.kernel.org/r/20200311091944.23185-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:59 +01:00
Ajay Singh
1693a2fa4b
staging: wilc1000: updated DT binding documentation
...
Merged the DT binding documentation of SDIO and SPI into a single file.
Removed documentation for some of the properties which are not required
and handled review comments received in [1] & [2].
[1]. https://lore.kernel.org/linux-wireless/20200303020230.GA15543@bogus
[2]. https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogus
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20200307085523.7320-4-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:58 +01:00
Ajay Singh
9aa4e8de3b
staging: wilc1000: modified 'clock-names' and 'compatible' property
...
Modified the 'clock-names' property by removing '_clk' from its name and
remove '_spi/sdio' from 'compatible' string.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20200307085523.7320-3-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:58 +01:00
Ajay Singh
3ee72c0888
staging: wilc1000: use 'interrupts' property instead of 'irq-gpio'
...
Make use of 'interrupts' property instead of using gpio for handling
the interrupt as suggested in [1].
[1]. https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogus
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20200307085523.7320-2-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-12 09:23:58 +01:00
Carlos Henrique Lima Melara
7d50888090
staging: qlge: Fix WARNING: Missing a blank line after declarations
...
Fixed WARNING: Missing a blank line after declarations in qlge_mpi.c to
the following lines:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:94:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:240:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:258:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:356:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:915:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:1099:
Signed-off-by: Carlos Henrique Lima Melara <charlesmelara@outlook.com >
Link: https://lore.kernel.org/r/CP2PR80MB434086A44A1ED5BB662B9D70A8FC0@CP2PR80MB4340.lamprd80.prod.outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Andre Pinto
3394cf0779
staging: rtl8188eu: fix typo s/informations/information
...
Fix checkpatch check: 'informations' may be misspelled - perhaps
'information'? in rtw_mlme_ext.c:1151.
Signed-off-by: Andre Pinto <andrealmeidap1996@gmail.com >
Link: https://lore.kernel.org/r/20200311012638.18889-1-andrealmeidap1996@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Lourdes Pedrajas
d154c0a968
staging: vt6655: power.c: code reformatting for improved readability
...
Improve line grouping for better understanding the course of action and where
every comment belongs to.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/3fada7fe76047ecf06d0345c0ab9216424a126f2.1583848946.git.lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Lourdes Pedrajas
3cd8958935
staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()
...
Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but
this feature it is marked TODO in 2014 and did go untouched since 2015.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/d9b8e434e09cb8885026a71441bf3a6919dba3da.1583848946.git.lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Sergio Paracuellos
5ca61dffc7
staging: mt7621-pci: enable clock bit for each port
...
The clock related code concerns me from the very beginning because
there are some set ups got from legacy driver that are not documented
anywhere. According to the programming guide 0x7c is 'CPE_ROSC_SEL1'
register and 0x80 is 'CPU_CPE_CN'. I do think this set up is not needed
at all and the proper thing to do is just enable the clock bit for each
pcie port. Hence remove useless code and do the right thing which is
setting up the clock bit for each port enabled.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20200310113459.30539-1-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:48 +01:00
Deepak R Varma
05ffb11ca7
staging: comedi: dt282x: remove old unused code
...
There are two #if 0 blocks that have no recent history of any change.
Remove those code blocks for improved readability of the code.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200310212545.GA8914@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:54 +01:00
Kaaira Gupta
c9edd29754
staging: wfx: remove unused structure
...
struct hif_cnf_reset is not used anywhere in wfx. It's parent file
hif_api_cmd.h is imported form some other driver, hence some functions
in it are not used. This is one of them. Hence remove it.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-7-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:54 +01:00
Kaaira Gupta
02a33f8e06
staging: wfx: remove variable declaration
...
int ret is uneccessarily declared and 0 assigned to it. Return o
directly instead.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-6-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
3f716acc27
staging: wfx: data_tx.h: remove space after cast
...
remove extra space after a cast in file data_tx.h
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-5-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
df69646bf2
staging: wfx: dat_tx.c: remove space after a cast
...
remove extra spaces after casts in file data_tx.c
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-4-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
c67dc09fac
staging: wfx: change 1 to bool
...
policies[i].uploaded is a bool. 1 is assigned to it. Change it to bool.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-3-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
98c386c264
staging: wfx: data_rx.c: remove space after cast
...
remove an unesseccary space after a cast in file data_rx.c
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-2-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Greg Kroah-Hartman
590a95e418
staging: exfat: remove staging version of exfat filesystem
...
Now that there is a "real" solution for exfat in the vfs tree queued up
to be merged in 5.7-rc1 the "old" exfat code in staging can be removed.
Many thanks to Valdis for doing the work to get this into the tree in
the first place, it was greatly appreciated.
Acked-by: Valdis Kletnieks <valdis.kletnieks@vt.edu >
Cc: Pali Rohár <pali@kernel.org >
Cc: Stephen Rothwell <sfr@canb.auug.org.au >
Cc: Al Viro <viro@ZenIV.linux.org.uk >
Cc: Namjae Jeon <namjae.jeon@samsung.com >
Cc: Sungjong Seo <sj1557.seo@samsung.com >
Cc: Christoph Hellwig <hch@lst.de >
Link: https://lore.kernel.org/r/20200310105421.GA2810679@kroah.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 12:30:34 +01:00
Sergio Paracuellos
9a5e71a68d
staging: mt7621-pci: simplify 'mt7621_pcie_init_virtual_bridges' function
...
Function 'mt7621_pcie_init_virtual_bridges' is a bit mess and can be
refactorized properly in a cleaner way. Introduce new 'pcie_rmw' inline
function helper to do clear and set the correct bits this function needs
to work.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20200308091928.17177-1-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:52:27 +01:00
Zhenzhong Duan
8080b0f537
staging: speakup: Fix a typo error print for softsynthu device
...
When softsynthu device fails the register, "/dev/softsynthu" should be
printed instead of "/dev/softsynth".
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com >
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org >
Cc: William Hubbs <w.d.hubbs@gmail.com >
Cc: Chris Brannon <chris@the-brannons.com >
Cc: Kirk Reiser <kirk@reisers.ca >
Link: https://lore.kernel.org/r/20200305072151.403-1-zhenzhong.duan@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Malcolm Priestley
696089de8e
staging: vt6656: struct vnt_rcb remove unused in_use.
...
The variable merely toggles true to false and is unused.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/130a4078-2502-a381-46c4-b473815e153b@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Malcolm Priestley
d1ec124246
staging: vt6656: Remove vnt_interrupt_buffer in_use flag.
...
mac80211 is the only user of in_use to start it and should
not be true when so.
So internal toggling of this variable is not relevant.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/69585034-4318-4bec-7d9b-f64a167df237@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Sergiu Cuciurean
b26b1391df
staging: wilc1000: spi: Use new structure for SPI transfer delays
...
In a recent change to the SPI subsystem in commit <bebcfd272df6>
("spi: introduce `delay` field for `spi_transfer` +
spi_transfer_delay_exec()"), a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.
The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com >
Link: https://lore.kernel.org/r/20200304074319.22107-1-sergiu.cuciurean@analog.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Sergiu Cuciurean
19a91ec87a
staging: kpc2000: kpc2000_spi: Use new structure for SPI transfer delays
...
In a recent change to the SPI subsystem in commit <bebcfd272df6>
("spi: introduce `delay` field for `spi_transfer` +
spi_transfer_delay_exec()"), a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.
The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com >
Link: https://lore.kernel.org/r/20200304073746.19664-1-sergiu.cuciurean@analog.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Shreeya Patel
d2ac333d2e
Staging: rtl8188eu: Add space around operator
...
Add space around & operator for improving the code
readability.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Acked-by: Julia Lawall <julia.lawall@inria.fr >
Link: https://lore.kernel.org/r/20200308192152.26403-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:50 +01:00
Lourdes Pedrajas
c12b19af4a
staging: hp: remove commented out code
...
Remove unused code.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Link: https://lore.kernel.org/r/20200308225400.17267-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:49 +01:00
Payal Kshirsagar
1657f11c7c
staging: exfat: alignment should match open parenthesis
...
Align code to match open parenthesis.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309165138.5313-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:49 +01:00
Lourdes Pedrajas
b92a047b2e
staging: exfat: exfat_super.c: remove commented out function
...
Remove function ffsSetAttr() which is unused.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Link: https://lore.kernel.org/r/20200309165801.4827-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:49 +01:00
Shreeya Patel
9eafa2b71a
Staging: rtl8723bs: Remove comparison to true
...
Remove comparison to "true" from if statement to
maintain the kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Link: https://lore.kernel.org/r/20200308201703.31709-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:23 +01:00
Payal Kshirsagar
a5e7d27e2d
staging: ks7010: remove line over 80 characters
...
Remove line over 80 characters.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200308123834.3377-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:23 +01:00
Payal Kshirsagar
95f67ef3d2
staging: wfx: remove blank line
...
Blank line is not necessary before a close brace '}', remove it.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com >
Link: https://lore.kernel.org/r/20200309165528.5721-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Payal Kshirsagar
bcfb8b05a9
staging: wfx: alignment should match open parenthesis
...
Align code to open parenthesis.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309164515.4880-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Thomas Gleixner
66d93d7ff9
staging: greybus: Fix the irq API abuse
...
Nothing outside of low level architecture code is supposed to look up
interrupt descriptors and fiddle with them.
Replace the open coded abuse by calling generic_handle_irq().
This still does not explain why and in which context this connection
magic is injecting interrupts in the first place and why this is correct
and safe, but at least the API abuse is gone.
Fixes: 036aad9d02 ("greybus: gpio: add interrupt handling support")
Fixes: 2611ebef83 ("greybus: gpio: don't call irq-flow handler directly")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Acked-by: Johan Hovold <johan@kernel.org >
Link: https://lore.kernel.org/r/87o8t9boqq.fsf@nanos.tec.linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00