Takashi Iwai
f16a4e960a
ALSA: ice1712: More constifications
...
Apply const prefix to each possible place: the EEPROM tables, the
static string arrays, the init verb tables, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-17-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:41 +01:00
Takashi Iwai
bf6f3d74c9
ALSA: riptide: More constifications
...
Apply const prefix to each lbus path table definition and its
callers.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-16-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:40 +01:00
Takashi Iwai
6fddce26f8
ALSA: emu10k1: More constifications
...
Apply const prefix to the remaining possible places: the static tables
for init verbs and registers, the string arrays, the conversion
tables, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-15-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:39 +01:00
Takashi Iwai
eafcdbdb4f
ALSA: au88x0: More constifications
...
Apply const prefix to each possible place: the static register tables,
the coef tables, the string arrays, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-14-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:38 +01:00
Takashi Iwai
56d7058e12
ALSA: caiaq: More constifications
...
Apply const prefix to each possible place: the rate table, the
controller tables, and the key tables.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-13-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:37 +01:00
Takashi Iwai
a01df925d1
ALSA: usb-audio: More constifications
...
Apply const prefix to the remaining places: the static table for the
unit information, the mixer maps, the validator tables, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-12-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:34 +01:00
Takashi Iwai
1675bfc0fb
ALSA: ac97: More constifications
...
Apply const prefix to each possible place: the static tables for
registers and bits, the quirk tables, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-11-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:34 +01:00
Takashi Iwai
bf82326fce
ALSA: hda: More constifications
...
Apply const prefix to the remaining possible places: the string
tables, the rate tables, the verb tables, the index tables, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-10-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:32 +01:00
Takashi Iwai
f729f88a04
ALSA: intel8x0: More constifications
...
Apply const prefix to more places: the static tables for PCM
definitions, the register tables, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-9-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:31 +01:00
Takashi Iwai
c09482455c
ALSA: vx: More constifications
...
Apply const prefix to every possible place: the static tables for DSP
commands, the string tables, and register/offset tables.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-8-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:30 +01:00
Takashi Iwai
731922a593
ALSA: seq: More constifications
...
Apply const prefix to the remaining sequencer code: the static tables
for MIDI macros, RPN/NRPN, and some strings.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-7-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:29 +01:00
Takashi Iwai
d03af9b8ea
ALSA: pcm: More constifications
...
Apply const prefix to more possible places: the string tables for PCM
format and co, the table for the PCM type helpers, etc.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-6-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:29 +01:00
Takashi Iwai
d64e7f7c9e
ALSA: dummy: More constifications
...
Apply const prefix to every possible place: mostly for declaring the
dummy hardware models.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-5-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:28 +01:00
Takashi Iwai
6b0f95c49d
ALSA: hda/realtek - More constifications
...
Apply const prefix to each coef table array.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-4-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:27 +01:00
Takashi Iwai
fa35aa4607
ALSA: aoa: More constifications
...
Apply const prefix at every place where appropriate: the static
register tables, the volume tables and the callback tables.
Just for minor optimization and no functional changes.
Link: https://lore.kernel.org/r/20200105144823.29547-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:27 +01:00
Takashi Iwai
f5f87abfb7
ALSA: Allow const arrays for legacy resource management helpers
...
Declare the arrays passed to the helper functions for legacy resources
(mostly for ISA drivers) as const, so that each caller can make its
static data as const for minor optimizations, too.
Link: https://lore.kernel.org/r/20200105144823.29547-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 16:14:26 +01:00
Takashi Iwai
8be03a7177
ALSA: usb-audio: Use lower hex numbers for IDs
...
For consistency reason, make all hex numbers with lower alphabets for
USB ID entries. It improves grep-ability and reduces careless
mistakes.
Link: https://lore.kernel.org/r/20200105081900.21870-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 09:20:44 +01:00
Takashi Iwai
5d8398aa59
Merge branch 'for-linus' into for-next
...
Merge 5.5-rc devel branch back for applying the conflicting USB-audio
fix.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 09:19:34 +01:00
Takashi Iwai
5fab582967
ALSA: hda/realtek - Apply mic mute LED quirk for Dell E7xx laptops, too
...
Dell E7xx laptops have also mic mute LED that is driven by the
dell-laptop platform driver. Bind it with the capture control as
already done for other models.
A caveat is that the fixup hook for the mic mute LED has to be applied
at last, otherwise it results in the invalid override of the callback.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205529
Link: https://lore.kernel.org/r/20200105081119.21396-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-05 09:12:11 +01:00
Takashi Iwai
51d4efab78
ALSA: usb-audio: Apply the sample rate quirk for Bose Companion 5
...
Bose Companion 5 (with USB ID 05a7:1020) doesn't seem supporting
reading back the sample rate, so the existing quirk is needed.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206063
Cc: <stable@vger.kernel.org >
Link: https://lore.kernel.org/r/20200104110936.14288-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-04 12:16:04 +01:00
Takashi Iwai
5da116f164
ALSA: sh: Fix unused variable warnings
...
Remove unused variables that are left over after the conversion of new
PCM ops:
sound/sh/sh_dac_audio.c:166:26: warning: unused variable 'runtime'
sound/sh/sh_dac_audio.c:186:26: warning: unused variable 'runtime'
sound/sh/sh_dac_audio.c:205:26: warning: unused variable 'runtime'
Fixes: 1cc2f8ba0b ("ALSA: sh: Convert to the new PCM ops")
Link: https://lore.kernel.org/r/20200104110057.13875-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-04 12:02:32 +01:00
Takashi Iwai
fbd3eb7f66
ALSA: control: Add verification for kctl accesses
...
The current implementation of ALSA control API fully relies on the
callbacks of each driver, and there is no verification of the values
passed via API. This patch is an attempt to improve the situation
slightly by adding the validation code for the values stored via info
and get callbacks.
The patch adds a new kconfig, CONFIG_SND_CTL_VALIDATION. It depends
on CONFIG_SND_DEBUG and off as default since the validation would
require a slight overhead including the additional call of info
callback at each get callback invocation.
When this config is enabled, the values stored by each info callback
invocation are verified, namely:
- Whether the info type is valid
- Whether the number of enum items is non-zero
- Whether the given info count is within the allowed boundary
Similarly, the values stored at each get callback are verified as
well:
- Whether the values are within the given range
- Whether the values are aligned with the given step
- Whether any further changes are seen in the data array over the
given info count
The last point helps identifying a possibly invalid data type access,
typically a case where the info callback declares the type being
SNDRV_CTL_ELEM_TYPE_ENUMERATED while the get/put callbacks store
the values in value.integer.value[] array.
When a validation fails, the ALSA core logs an error message including
the device and the control ID, and the API call also returns an
error. So, with the new validation turned on, the driver behavior
difference may be visible on user-space, too -- it's intentional,
though, so that we can catch an error more clearly.
The patch also introduces a new ctl access type,
SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK. A driver may pass this flag with
other access bits to indicate that the ctl element won't be verified.
It's useful when a driver code is specially written to access the data
greater than info->count size by some reason. For example, this flag
is actually set now in HD-audio HDMI codec driver which needs to clear
the data array in the case of the disconnected monitor.
Also, the PCM channel-map helper code is slightly modified to avoid
the false-positive hit by this validation code, too.
Link: https://lore.kernel.org/r/20200104083556.27789-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-04 09:37:59 +01:00
Kailang Yang
6d9ffcff64
ALSA: hda/realtek - Add new codec supported for ALCS1200A
...
Add ALCS1200A supported.
It was similar as ALC900.
Signed-off-by: Kailang Yang <kailang@realtek.com >
Cc: <stable@vger.kernel.org >
Link: https://lore.kernel.org/r/a9bd3cdaa02d4fa197623448d5c51e50@realtek.com
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-04 09:22:34 +01:00
Michał Mirosław
caf3c0437a
ALSA: hda - constify and cleanup static NodeID tables
...
Make hda_nid_t tables static const, as they are not intended to be
modified by callees.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl >
Link: https://lore.kernel.org/r/5150c94101c9534f4c8e987324f6912c16d459f6.1578043216.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 10:38:38 +01:00
Takashi Iwai
88e540a876
ALSA: pci: Constify snd_pci_quirk tables
...
The snd_pci_quirk tables are referred as read-only, hence they can be
declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-59-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:45 +01:00
Takashi Iwai
a5dc05e466
ALSA: hda: Constify snd_pci_quirk tables
...
The snd_pci_quirk tables are referred as read-only, hence they can be
declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-58-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:44 +01:00
Takashi Iwai
fb537cd008
ALSA: fm801: Constify snd_fm801_tea575x_gpios
...
The snd_fm801_tea575x_gpios table is referred as read-only, hence it
can be declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-57-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:44 +01:00
Takashi Iwai
cd6e03122b
ALSA: es1968: Constify snd_es1968_tea575x_gpios
...
The snd_es1968_tea575x_gpios table is referred as read-only, hence it
can be declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-56-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:43 +01:00
Takashi Iwai
c274d967ce
ALSA: emu10k1: Constify snd_emu_chip_details
...
The snd_emu_chip_details definitions are referred as read-only, hence
they can be declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-55-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:43 +01:00
Takashi Iwai
baa9df207a
ALSA: bt87x: Constify snd_bt87x_boards
...
The snd_bt87x_boards array is referred as read-only, hence it can be
declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-54-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:42 +01:00
Takashi Iwai
87065d3d94
ALSA: seq: oss: Constify snd_seq_oss_callback definitions
...
The snd_seq_oss_callback items are just copied to another struct
as-is, hence they can be declared as const.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-53-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:41 +01:00
Takashi Iwai
49624472a9
ALSA: usx2y: Constify struct snd_usb_audio_quirk entries
...
The quirk entries used in us122l and usx2y drivers can be declared as
const as they are read-only.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-52-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:41 +01:00
Takashi Iwai
37cc306b72
ALSA: line6: Constify snd_ratden definitions
...
The snd_ratden definitions used in line6 drivers are all read-only, so
they can be marked as const.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-51-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:40 +01:00
Takashi Iwai
4f8ce9821e
ALSA: ice1712: Constify wm-specific tables
...
The tables defined in wm8766.c and wm8776.c are referred as read-only,
hence they can be declared as const gracefully.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-50-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:39 +01:00
Takashi Iwai
aeb0215c76
ALSA: ice17xx: Constify snd_ice1712_card_info
...
The snd_ice1712_card_info objects are referred only as read-only.
Let's make them const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-49-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:39 +01:00
Takashi Iwai
dc6ffaf828
ALSA: ca0106: Constify snd_ca0106_details
...
The snd_ca0106_details table entries are referred only as read-only.
Let's make them const.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-48-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:38 +01:00
Takashi Iwai
311840d96f
ALSA: ca0106: Constify snd_ca0106_category_str items
...
snd_ca0106_con_category array is read-only and can be marked as const.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-47-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:37 +01:00
Takashi Iwai
c0476b980d
ALSA: ac97: Constify snd_ac97_res_table definition
...
One snd_ac97_res_table definition remains forgotten without const.
Let's add it for a bit of optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-46-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:37 +01:00
Takashi Iwai
fe27463ad8
ALSA: opl3: Constify snd_opl3_drum_voice definitions
...
The snd_opl3_drum_voice items are all read-only, hence they can be
declared as const.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-45-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:36 +01:00
Takashi Iwai
1da7f0c570
ALSA: dummy: Constify snd_pcm_ops definitions
...
The snd_pcm_ops items defined in snd-dummy driver can be gracefully
declared as const. Let's mark them for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-44-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:36 +01:00
Takashi Iwai
46708e626d
ALSA: parisc: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-43-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:35 +01:00
Takashi Iwai
195727e8b6
ALSA: usb: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-42-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:34 +01:00
Takashi Iwai
1aeb1c7f28
ALSA: spi: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-41-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:34 +01:00
Takashi Iwai
f8a32d94f3
ALSA: sparc: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-40-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:33 +01:00
Takashi Iwai
c031b0cc77
ALSA: ppc: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-39-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:32 +01:00
Takashi Iwai
b4e5e70775
ALSA: pci: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-38-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:28 +01:00
Takashi Iwai
35ace5e841
ALSA: hda: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-37-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:27 +01:00
Takashi Iwai
fdd1f6fd32
ALSA: isa: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-36-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:25 +01:00
Takashi Iwai
0da2c47a95
ALSA: i2c: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-35-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:24 +01:00
Takashi Iwai
2eccd40803
ALSA: drivers: Constify snd_kcontrol_new items
...
Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.
Constify snd_kcontrol_new items
There should be no functional changes by this patch.
Link: https://lore.kernel.org/r/20200103081714.9560-34-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2020-01-03 09:24:23 +01:00