H Hartley Sweeten
ee68d168cb
staging: comedi: ni_atmio: remove printk noise in ni_isapnp_find_board()
...
The printk() messages in this function a just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
9d3e5ab5e8
staging: comedi: hwdrv_apci3200: remove disabled PRINT_INFO debug
...
Remove all the PRINT_INFO debug.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
5ee226306c
staging: comedi: comedi_fops: remove commented out debug messages
...
Remove the commented out printk() debug.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
bbedf943f2
staging: comedi: das1800: tidy up das1800_probe()
...
The (*attach) of driver calls this function to probe the 'id' of the
hardware to verify that a valid boardinfo has been selected by the
user.
The dev_dbg() messages when the boardinfo is valid is just added
noise. The printk messages when the id does not match the boardinfo
does have some value.
Refactor the function to remove the noise and use a common message
for the "(probed, not recommended)" message.
Convert the printk() messages to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
bc0640a795
staging: comedi: ni_at_a2150: convert printk to dev_err
...
Convert the printk() message to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
b252ebfccf
staging: comedi: ni_atmio: convert printk to dev_err in ni_getboardtype()
...
Convert these printk() messages to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
221fa08c53
staging: comedi: ni_atmio: remove board attach noise
...
Remove the printk messages in the (*attach) of this driver. These are
just added noise.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
07e6b2e2a8
staging: comedi: ni_mio_common: consolidate call to ni_mseries_get_pll_parameters()
...
All cases of the switch call ni_mseries_get_pll_parameters() with the same
parameters. Move the call out of the switch.
Also, move the printk from ni_mseries_get_pll_parameters() so that it can
be converted into a dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
H Hartley Sweeten
89c4695efd
staging: comedi: ni_mio_common: convert printk messages to dev_err
...
Where possible, convert the printk() messages in this file to dev_err().
Remove a couple commented out printk() messages.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:08:01 -07:00
Malcolm Priestley
f7e4a8f45c
staging: vt6656: struct vnt_private rename apTD to tx_context
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
8577011c7a
staging: vt6656: struct vnt_private rename apRCB to rcb
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
3d582487be
staging: vt6656: struct vnt_private pInterruptURB rename to interrupt_urb
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
421ce4e58e
staging: vt6656: struct vnt_private remove dead variables
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
7b6914c84f
staging: vt6656: remove dead structure struct vnt_tx_pkt_info
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
325de98424
staging: vt6656: struct vnt_rcb remove camel case
...
Camel case changes
pDevice -> priv
pUrb -> urb
bBoolInUse -> in_use
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
23dbf877b1
staging: vt6656: struct vnt_rcb remove unused members
...
Remove Next and Ref
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
1b6953dde4
staging: vt6656: fix module_param_named tx_buffers variable
...
Should point to vnt_tx_buffers
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Malcolm Priestley
76d382fc80
staging: vt6656: usb_device_reset remove camel case
...
Camel case change
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-18 16:06:23 -07:00
Khoa Mai
dfcd909227
staging: bcm: Qos.c: Fix coding style
...
Switch and case should be in same indent level
Signed-off-by: Khoa Mai <mdk194@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:51:27 -07:00
Khoa Mai
9d1e0d094b
staging: bcm: Qos.c: Fix coding style
...
Fix C99 comment
Signed-off-by: Khoa Mai <mdk194@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:51:27 -07:00
Greg Kroah-Hartman
75533a0386
staging: gdm72xx: fix build errors
...
This fixes the build errors in the dev_dbg() fixes in a previous patch.
Reported-by: kbuild test robot <fengguang.wu@intel.com >
To: Michalis Pappas <mpappas@fastmail.fm >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:33:02 -07:00
Himangi Saraogi
75f2a4ead5
devres: Add devm_kasprintf and devm_kvasprintf API
...
devm_kasprintf() and devm_kvasprintf() are the managed counterparts
for kasprintf() and kvasprintf().
Signed-off-by: Himangi Saraogi <himangi774@gmail.com >
Acked-by: Julia Lawall <julia.lawall@lip6.fr >
Acked-by: Tejun Heo <tj@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:26:44 -07:00
Josep Puigdemont
871379dc0f
staging: lustre: plain interger was used as NULL pointer
...
This patch fixes the following warnings found when running sparse:
.../lproc_echo.c:43:11: warning: Using plain integer as NULL pointer
.../lproc_echo.c:49:11: warning: Using plain integer as NULL pointer
Signed-off-by: Josep Puigdemont <josep.puigdemont@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:25:47 -07:00
Benjamin Romer
8a1182eb34
staging: unisys: detect controlvm channel on module load
...
The controlvm channel is not removable from a guest after the guest starts,
so it makes no sense to constantly check for it. Move the channel address
discovery to visorchipset_init(), and remove all of the checks for the channel
address from the rest of the module, as the module will not load if the
channel pointer is not valid.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:11:33 -07:00
Benjamin Romer
524b0b63a1
staging: unisys: simplify controlvm channel address function
...
There is no reason to have controlvm_get_channel_address() defined in a
separate file. Move it to visorchipset_main.c, remove the no-op functions
controlvm_init() and controlvm_deinit() from visorchipset_main.c, and remove
the controlvm.h and controlvm_direct.c files from the module.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:11:33 -07:00
Andrey Utkin
ea702e76af
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c: drop incorrect checks
...
Dropped some "< 0" and ">= 0" checks on unsigned int values.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80501
Reported-by: David Binderman <dcb314@hotmail.com >
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:08:31 -07:00
Michalis Pappas
f5439c612e
staging: gdm72xx: replace print_hex_dump_debug() with dev_dbg()
...
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:07:30 -07:00
Michalis Pappas
a01a56bdb3
staging: gdm72xx: remove debug code
...
Removed dump_eth_packet() and helper functions called upon packet tx/rx.
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:07:30 -07:00
Sachin Kamat
657b8dbc49
staging: ion: Remove left over comment
...
Commit 2bb9f5034e ("gpu: ion: Remove heapmask from client")
removed the heap_type_mask parameter. Remove the associated
kernel-doc comment too.
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com >
Cc: Rebecca Schultz Zavin <rebecca@android.com >
Cc: John Stultz <john.stultz@linaro.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:07:30 -07:00
Kiran Padwal
f4ef08f0c1
Staging: gdm724x: gdm_tty.c: fix missing blank line after variable declaration
...
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:05:47 -07:00
Larry Finger
7da8d6a015
staging: rtl8192ee: Fix setting highest n rate
...
Commit 4fb6a37c3f by Andrey Utkin
<andrey.krieger.utkin@gmail.com > and entitled "staging: rtl8192ee:
"Correct bitmask in comparsion" fixed what appeared to be a typo. After
consultation with the Realtek engineers, merely testing for a 2T2R device
is sufficient to ensure that the TX MCS map will equal 0x0c, thus the second
test can be ignored.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:04:07 -07:00
Malcolm Priestley
b5726cb8b2
staging: vt6656: Remove commented out long frequency_list
...
These frequencies are already defined in new tables channel.c
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
968a9225f7
staging: vt6656: main_usb remove static function declarations.
...
All these functions are in visibility order.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
71503b3ed6
staging: vt6656: main_usb remove dead module params macros
...
All these macros relate to module parameters already removed
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
eb734a6aaa
staging: vt6656: remove dead code DEVICE_PARAM
...
All these module parameters are dead
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
3220e3a43d
staging: vt6656: main_usb.c Replace DEVICE_PARAM TxDescriptors0
...
Replace with vnt_tx_buffers using module_param_named and
MODULE_PARM_DESC
Check user doe not set tx_buffer beyond the define limits of driver
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
2f020ebcda
staging: vt6656: main_usb.c Replace DEVICE_PARAM RxDescriptors0
...
Replace with vnt_rx_buffers using module_param_named and
MODULE_PARM_DESC
Check user doe not set rx_buffer beyond the define limits of driver
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
bccf114046
staging: vt6656: remove DBG_PRT kernel messages macro and enums
...
All dead code and nolonger used by driver.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:53 -07:00
Malcolm Priestley
752b7dafdb
staging: vt6656: power.c replace DBG_PRT debug messages
...
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
b4ae135e7c
staging: vt6656: replace DBG_PRT error messages
...
replace with dev_err
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
4e62dcc900
staging: vt6656: main_usb replace DBG_PRT debug messages
...
replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
3ce54934df
staging: vt6656: device_init_registers remove camel case
...
camel case changes
pDevice -> priv
byAntenna -> antenna
ntStatus -> status
byTmp-> tmp
byCalibTXIQ -> calib_tx_iq
byCalibTXDC -> calib_tx_dc
byCalibRXIQ -> calib_rx_iq
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
da3b67b343
staging: vt6656: device_set_options remove camel case
...
Camel case changes
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
28e067f4ff
staging: vt6656: device_set_options fix opening function bracket
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
80dcc0aeb9
staging: vt6656: rename BBvUpdatePreEDThreshold to vnt_update_pre_ed_threshold
...
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
0e951753dc
staging: vt6656: rename BBvExitDeepSleep to vnt_exit_deep_sleep
...
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
e8e072da88
staging: vt6656: rename BBvSetDeepSleep to vnt_set_deep_sleep
...
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
de8690a2e3
staging: vt6656: rename BBvSetVGAGainOffset to vnt_set_vga_gain_offset
...
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
3c956cc025
staging: vt6656: rename BBvSetShortSlotTime to vnt_set_short_slot_time
...
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00
Malcolm Priestley
7534180cf9
staging: vt6656: rename BBbVT3184Init to vnt_vt3184_init
...
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 18:01:52 -07:00