Commit Graph

442411 Commits

Author SHA1 Message Date
Jes Sorensen
db20a02baf staging: rtl8723au: We love wrappers!
Get rid of pointless wrapper around a simple kfree()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:24 -07:00
Jes Sorensen
1aaa37613f staging: rtl8723au: Remove HAL wrappers about USB init/deinit
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:24 -07:00
Jes Sorensen
44e621c7a6 staging: rtl8723au: Remove HAL wrappers around read_chip_version
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:23 -07:00
Jes Sorensen
5d9edb5663 staging: rtl8723au: Remove unused HAL wrappers around PHY register read/write calls
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:23 -07:00
Jes Sorensen
369074f071 staging: rtl8723au: Remove HAL notch_filter wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:23 -07:00
Jes Sorensen
a7a983ca20 staging: rtl8723au: Remove unused hal_reset_security_engine code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:23 -07:00
Jes Sorensen
b7c19c276a staging: rtl8723au: Get rid of sreset related HAL clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:22 -07:00
Jes Sorensen
8289d35730 staging: rtl8723au: Get rid of rtw_hal_dm_* clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:22 -07:00
Jes Sorensen
1f4746f1c5 staging: rtl8723au: Remove some more HAL clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:22 -07:00
Jes Sorensen
03722621d2 staging: rtl8723au: Call rtl8723a_init_default_value_directly()
We really don't need two layers of silly indirection to call this
function.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:22 -07:00
Jes Sorensen
d87283ff9b staging: rtl8723au: Remove unused hal_data_sz from struct rtw_adapter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:22 -07:00
Jes Sorensen
f207b02db8 staging: rtl8723au: Remove unused rtl8723a_clone_haldata()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:21 -07:00
Jes Sorensen
cf3d7b940b staging: rtl8723au: Remove unused bBTFWReady from struct rtw_adapter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:21 -07:00
Jes Sorensen
f7f332bd83 staging: rtl8723au: osdep_service.h: Reduce excessive header inclusion
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:21 -07:00
Jes Sorensen
ebf2ccf69b staging: rtl8723au: Remove obsolete BITx #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:21 -07:00
Jes Sorensen
f061c1b1e3 staging: rtl8723au: odm_HWConfig.c: Use BIT() consistently
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:21 -07:00
Jes Sorensen
fc8b7c8cac staging: rtl8723au: odm.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:21 -07:00
Jes Sorensen
bc0d10cb1e staging: rtl8723au: rtl8723a_hal_init.c: Use BIT() consistently
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
8f7654c18a staging: rtl8723au: rtl8723a_phycfg.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
a3f214622d staging: rtl8723au: HalDMOutSrt8723A_CE.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
d66ecc271c staging: rtl8723au: hal_com.c: Use BIT() consistently instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
8952e08d4a staging: rtl8723au: rtl8723a_bt-coexist.c: Be consistent in use of BIT()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
05f07e7d4d staging: rtl8723au: usb_halinit.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
f8c41a92fb staging: rtl8723au: rtl8723au_led.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
68c9da90fe staging: rtl8723au: rtw_sreset.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:20 -07:00
Jes Sorensen
e478c1f52d staging: rtl8723au: odm_reg.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:19 -07:00
Jes Sorensen
c04d002ac2 staging: rtl8723au: odm_debug.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:19 -07:00
Jes Sorensen
93748447fe staging: rtl8723au: odm.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:19 -07:00
Jes Sorensen
f709b1824e staging: rtl8723au: hal_intf.h: Be consistent and use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:19 -07:00
Jes Sorensen
750c8434fe staging: rtl8723au: Hal8723PwrSeq.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:19 -07:00
Jes Sorensen
db6ec57ba0 staging: rtl8723au: Hal8723APhyCfg.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:18 -07:00
Jes Sorensen
1c3b6e7d1b staging: rtl8723au: rtl8723a_bt-coexist.h: Be consistent and use BIT()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:18 -07:00
Jes Sorensen
9c45c20da2 staging: rtl8723au: rtl8723a_spec.h: Use BIT() instead of BITx macros
Be consistent and stick to BIT()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:18 -07:00
Octavian Purdila
f4e131dc38 goldfish: pipe: fix warnings for 32bit builds
drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_cmd_status':
drivers/platform/goldfish/goldfish_pipe.c:164:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL);
                 ^
drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_cmd':
drivers/platform/goldfish/goldfish_pipe.c:180:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL);
                 ^
drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_pipe_read_write':
drivers/platform/goldfish/goldfish_pipe.c:337:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL);

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jun Tian <jun.j.tian@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:32:51 -07:00
Octavian Purdila
f2dbdf625d goldfish: bus: fix warnings for 32bit builds
drivers/platform/goldfish/pdev_bus.c: In function 'goldfish_new_pdev':
drivers/platform/goldfish/pdev_bus.c:136:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  writel((u32)(u64)name, pdev_bus_base + PDEV_BUS_GET_NAME);

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jun Tian <jun.j.tian@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:32:51 -07:00
Geert Uytterhoeven
0f18a27787 staging: rts5139: Make variables inside #ifdef CONFIG_PM
If CONFIG_PM=n:

drivers/staging/rts5139/rts51x_transport.c:649: warning: ‘media_not_present’ defined but not used
drivers/staging/rts5139/rts51x_transport.c:651: warning: ‘invalid_cmd_field’ defined but not used

Move the variables inside the #ifdef CONFIG_PM, and make them const while
we're at it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:30:53 -07:00
Neil Armstrong
dbdb85221a staging: rts5139: fix bad symbol declaration
With sparse, the following error appears :
  CHECK   drivers/staging/rts5139/ms_mg.c
drivers/staging/rts5139/ms_mg.c:82:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static?

Rename function with correct prefix and move declaration to coherent internal header file.

Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:30:52 -07:00
Thomas Tanaka
10f9f4aefa staging: rts5139: fixed coding style
Fixed checkpatch warnings > 80 lines

Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:30:52 -07:00
Fabio Falzoi
ba8f073281 Staging: rts5139: More appropriate use of sizeof operand
Use the pointer rts51x to get the size of the struct.

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:20:51 -07:00
Fabio Falzoi
c606525d76 Staging: rts5139: Removed OOM messages
All allocation Out Of Memory messages removed.
We rely on the generic OOM message in dump_stack().

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:20:51 -07:00
Fabio Falzoi
4b3ef391c3 Staging: rts5139: Use standard pr_<level> prefixing
Define pr_fmt macro to prefix every pr_<level> function in standard way.

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:20:51 -07:00
Fabio Falzoi
7cb6193011 Staging: rts5139: Splitted one-line multiple assignment
Splitted a multiple assignment on two separate lines.

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:20:51 -07:00
Fabio Falzoi
307a433e3d Staging: rts5139: Fixed multi-line code alignment
Multi-line code aligned with open parenthesis.

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:20:51 -07:00
Fabio Falzoi
fd09d1de70 Staging: rts5139: Camel case labels replaced
Replace camel case labels with linux coding style compliant names.

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:20:50 -07:00
Camille Bordignon
2787b99fd6 staging: sep: Fix coding style
Fix coding style warning "Missing a blank line after declarations"

Signed-off-by: Camille Bordignon <camille.bordignon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:04:45 -07:00
Malcolm Priestley
3136b5fee2 staging: vt6656: Remove PIPEnsControlOutAsyn/CONTROLnsRequestOutAsyn
This now the same as PIPEnsControlOut.

Replace with PIPEnsControlOut/CONTROLnsRequestOut.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:02:20 -07:00
Malcolm Priestley
0fb2af353f staging: vt6656: PIPEnsControlIn use usb_control_msg
Now that this function is nolonger atomic useusb_control_msg.

Return STATUS_FAILURE if ntStatus less than wLength

Remove the old struct urb and struct usb_ctrlrequest structures.

Remove fMP_CONTROL_READS flag.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:02:20 -07:00
Malcolm Priestley
7021b684eb staging: vt6656: usbpipe.c PIPEnsControlOut use usb_control_msg
Now that this fucntion is nolonger atomic change to usb_control_msg

Return STATUS_FAILURE if ntStatus less than wLength.

Remove fMP_CONTROL_WRITES flag

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:02:20 -07:00
Malcolm Priestley
3c647642f6 staging: vt6656: lock changes device_xmit
Replace locks with the spin_lock_irqsave and spin_unlock_irqrestore

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:02:20 -07:00
Malcolm Priestley
29b02373f4 staging: vt6656: lock changes: s_nsBulkInUsbIoCompleteRead.
Use spin_lock_irqsave/spin_unlock_irqrestore

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15 15:02:19 -07:00