Ovidiu Toader
c4d6b8fbea
drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse
...
This minor patch motivated by eudyptula challenge fixes the following warnings issued
by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c:
.../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static?
.../r8192U_wx.c:961:22: warning: symbol 'r8192_get_wireless_stats' was not declared. Should it be static?
.../r8192U_wx.c:990:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static?
Signed-off-by: Ovidiu Toader <ovi@phas.ubc.ca >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:20 -07:00
Matthias Beyer
fe77316521
Staging: bcm: Bcmchar.c: Renamed variable "uiOperation" -> "operation"
...
Renamed variable "uiOperation" -> "operation" in
bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:20 -07:00
Matthias Beyer
198d73daac
Staging: bcm: Bcmchar.c: Renamed variable "uiBit" -> "bit"
...
Renamed variable "uiBit" -> "bit" in bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:20 -07:00
Matthias Beyer
80c329ad0c
Staging: bcm: Bcmchar.c: Renamed variable "ucResetValue" -> "reset_val"
...
Renamed variable "ucResetValue" -> "reset_val" in
bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:20 -07:00
Matthias Beyer
41e7081094
Staging: bcm: Bcmchar.c: Renamed variable "uiTempVar" -> "tmp"
...
Renamed variable "uiTempVar" -> "tmp" in
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:20 -07:00
Matthias Beyer
95123f22a1
Staging: bcm: Bcmchar.c: Renamed variable "sWrmBuffer" -> "wrm_buff"
...
Renamed variable "sWrmBuffer" -> "wrm_buff" in
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:20 -07:00
Matthias Beyer
343fae7474
Staging: bcm: Bcmchar.c: Renamed variable "Bufflen" -> "buff_len"
...
Renamed variable "Bufflen" -> "buff_len" in
bcm_char_ioctl_reg_read_private().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
00c6fbcdab
Staging: bcm: Bcmchar.c: Renamed variable "IoBuffer" -> "io_buff"
...
Renamed variable "IoBuffer" -> "io_buff" in
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
201893bc51
Staging: bcm: Bcmchar.c: Renamed variable "sRdmBuffer" -> "rdm_buff"
...
Renamed variable "sRdmBuffer" -> "rdm_buff" in
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
aafec40c30
Staging: bcm: Bcmchar.c: Renamed variable "Packet" -> "packet"
...
Renamed variable "Packet" -> "packet" in bcm_char_read().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
dab41a0ea8
Staging: bcm: Bcmchar.c: Renamed variable "PktLen" -> "pkt_len"
...
Renamed variable "PktLen" -> "pkt_len" in bcm_char_read().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
f90a8a25f5
Staging: bcm: Bcmchar.c: Renamed variable "pTarang" -> "tarang"
...
Renamed variable "pTarang" -> "tarang" in
bcm_char_open()
bcm_char_release()
bcm_char_read()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
900025a3bd
Staging: bcm: Bcmchar.c: Renamed variable "ulDSDMagicNumInUsrBuff" -> "dsd_magic_num_in_usr_buff"
...
Renamed variable "ulDSDMagicNumInUsrBuff" ->
"dsd_magic_num_in_usr_buff" in handle_flash2x_adapter().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
bd9a40788d
Staging: bcm: Bcmchar.c: Renamed variable "Status" -> "status"
...
Renamed variable "Status" -> "status" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
9dc535b57a
Staging: bcm: Bcmchar.c: Renamed variable "stNVMReadWrite" -> "nvm_rw"
...
Renamed variable "stNVMReadWrite" -> "nvm_rw" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
e17219af18
Staging: bcm: Bcmchar.c: Renamed variable "pReadData" -> "read_data"
...
Renamed variable "pReadData" -> "read_data" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
5a7add1cc7
Staging: bcm: Bcmchar.c: Renamed variable "Adapter" -> "ad"
...
Renamed variable "Adapter" -> "ad" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
bcm_char_open()
bcm_char_release()
bcm_char_read()
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:19 -07:00
Matthias Beyer
bf8fa21cb7
Staging: bcm: Bcmchar.c: Fixed indentation of function arguments
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Hema Prathaban
3901270b15
staging: lustre: lustre: ptlrpc: Donot initialise null
...
This patch fixes the following error using checkpatch.pl
Error: Do not initialise statics to 0 or NULL
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Hema Prathaban
0028d585b4
staging: lustre: lustre: ptlrpc: Fix pointer declaration
...
This patch fixes the following checkpatch.pl issue in client.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Hema Prathaban
0ae015be95
staging: lustre: lustre: ptlrpc: Fix requires space
...
Fix checkpatch.pl issues spaces required.
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Oleg Drokin
459d3236ad
staging/lustre/lnet: Fix potential uninitialized variable warning
...
Greg reports that with one of the patches in his queue
there's now an unused variable warning in lnet_parse_ip2nets
for ipaddrs variable.
Apparently the warning is a false positive as in all cases where
lnet_ipaddr_enumerate can return without setting ipaddrs to something
a negative return value is returned that is then checked
before we actually use ipaddrs.
Assign ipaddrs to NULL to quiet this.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Srikrishan Malik
ab909585b8
staging: lustre: Cleanup variable declarations in mdc_enqueue()
...
Changes:
- move const union vars to the top
- move rc to bottom
- do not initialize req
- set lvb_type to enum member instead of 0
- change __u64 to u64
- fix inconsistant columnization
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Srikrishan Malik
eb44520b3a
staging: lustre: remove parentheses usage with return
...
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Srikrishan Malik
78dd07983b
staging: lustre: move else on the same line as closing brace
...
Fix the following checkpatch error:
ERROR: else should follow close brace '}'
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Srikrishan Malik
1a4cd3e9d5
staging: lustre: Fix misplaced opening brace warnings
...
Fixes the following checkpatch error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Srikrishan Malik
c35e01ff08
staging: lustre: Added space between type name and *
...
Fixes the following checkpatch error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:18 -07:00
Srikrishan Malik
ee990b3368
] staging: lustre: fix multi line strings
...
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
7436d0704f
staging: lustre: add blank lines after declarations
...
Fixes the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
125ffec0bd
staging: lustre: replace c99 style comments with C89
...
Fixes the following checkpatch error:
ERROR: do not use C99 // comments
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
301af9068d
staging: lustre: Add missing spaces around operators and braces.
...
Fixes the following checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that close brace '}'
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
e5e663ae7a
staging: lustre: fix lines over 80 chars
...
Fixes the following checkpatch warning:
WARNING: line over 80 characters
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
982ec91f50
staging: lustre: move open brace to next line after functions
...
Fixes the following checkpatch error:
ERROR: open brace '{' following function declarations go on the next line
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
444014d6f5
staging: lustre: remove spaces from start of line
...
Fixes the following checkpatch warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Srikrishan Malik
ffdac6ce36
staging: lustre: remove space between function name and and open parenthesis
...
Fixes following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Junien Fridrick
139cc6aed5
staging: lustre: fix coding style issue: missing space after 'if'
...
Coding style issue reported by checkpatch.pl
Signed-off-by: Junien Fridrick <linux.kernel@junien.fridrick.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Ragnar B. Johannsson
76be25ba31
staging: vt6656: add blank line after declaration
...
Adds a blank line after declaration to comply with coding style.
Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:17 -07:00
Ragnar B. Johannsson
de657d59f2
staging: vt6656: fix incorrect indentation
...
Use tabs, not spaces.
Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Ragnar B. Johannsson
86140346ad
staging: vt6656: remove unnecessary braces
...
Removes unnecessary braces to comply with coding style.
Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
80f598ae8a
staging: vt6655: remove typedef from struct vnt_private
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
1bd6375760
staging: vt6655: device_main Replace DEVICE_INFO with size of pointer
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
6af4336e64
staging: vt6655: rf/wpactl/wroute use struct vnt_private
...
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
8f335dd136
staging: vt6655: hostap/ioctl/iwctl use struct vnt_private
...
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
cf76dc4b85
staging: vt6655: bssdb/datarate/dpc/power/rxtx use struct vnt_private
...
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
0ffc58742d
staging: vt6655: channel/wcmd/wctl/wmgr use struct vnt_private *
...
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
d052270b43
staging: vt6655: card change PSDevice to struct vnt_private
...
Repacing void *pDeviceHandler
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
582d6c220b
staging: vt6655: baseband replace PSDevice
...
Coverting all functions to struct vnt_private.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:16 -07:00
Malcolm Priestley
3f8597f4e4
staging: vt6655: device.h use change __device_info to vnt_private
...
Coverting all functions to struct vnt_private in device.h and device_main.c
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:15 -07:00
Malcolm Priestley
965d017f49
staging: vt6655: upc.h replace read and write memory functions
...
Update to the newer memory functions
readb -> ioread8
readw -> ioread16
readl -> ioread32
writeb -> iowrite8
writew -> iowrite16
writel -> iowrite32
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:15 -07:00
Malcolm Priestley
3e66a2aadd
staging: vt6655: upc.h: Remove unused macros
...
PCBv* are not used
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-08-16 12:23:15 -07:00