Stefan Hajnoczi
bf83e30ec6
staging: line6: drop unused CONFIG_LINE6_USB_DEBUG
...
The CONFIG_LINE6_USB_DEBUG option is no longer relevant since dyndbg
dev_dbg() is now used instead of a compile-time decision whether to
enable debug messages or not.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 15:05:04 -08:00
Stefan Hajnoczi
60fb08b38e
staging: line6: drop unused DEBUG_MESSAGES() macro
...
The DEBUG_MESSAGES() macro is no longer needed since dev_dbg() is now
used for debug messages.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 15:05:03 -08:00
Stefan Hajnoczi
e00d33cb5d
staging: line6: replace DEBUG_MESSAGES() with dev_dbg()
...
The dyndbg feature allows dev_dbg() calls to be enabled/disabled at
runtime and is therefore more convenient than static debug log messages.
Use dev_dbg() instead of the line6-specific DEBUG_MESSAGES() macro.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 15:05:03 -08:00
Stefan Hajnoczi
e5603cbd7f
staging: line6: wrap comment to 80 chars in variax.c
...
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:41 -08:00
Stefan Hajnoczi
4391bb982b
staging: line6: wrap lines to 80 chars in usbdefs.h
...
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
Stefan Hajnoczi
b07d945227
staging: line6: replace deprecated strict_strtol() in toneport.c
...
The LED value is an int, so replace strict_strtol() with kstrtoint().
It's safe to pass in the actual variable instead of a local temporary
because strto*() doesn't write to the result unless the function returns
success.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
Stefan Hajnoczi
6a8ec8769d
staging: line6: wrap lines to 80 chars in playback.c
...
There are a few instances of 80+ character lines in playback.c. Two
instances are just because of a useless comment "this is somewhat
paranoid", so drop the comment. Other instances are straightforward
line wrapping.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
Stefan Hajnoczi
b957e0ceb6
staging: line6: drop trailing whitespace in pcm.h
...
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
Stefan Hajnoczi
928f25ee43
staging: line6: shorten comment below 80 chars in pcm.c
...
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
Stefan Hajnoczi
b3a24fc4e2
staging: line6: fix quoted string across lines in midibuf.c
...
Checkpatch warns when quoted strings are split across lines. The
rationale is that quoted strings should be left on a single line so that
grep works. (The 80 character line limit does not apply to quoted
strings.)
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
Stefan Hajnoczi
a71cac2a4c
staging: line6: wrap >80 char lines in capture.c
...
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:17:40 -08:00
YAMANE Toshiaki
7028035d51
staging/serqt_usb2: refactor qt_unthrottle() in serqt_usb2.c
...
Modified to eliminate the deep nesting.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:15:25 -08:00
YAMANE Toshiaki
04e9d11beb
staging/serqt_usb2: refactor qt_open() in serqt_usb2.c
...
Modified to eliminate the deep nesting.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:15:25 -08:00
YAMANE Toshiaki
bbbd527b4f
staging/serqt_usb2: refactor qt_read_bulk_callback() in serqt_usb2.c
...
Modified to eliminate the deep nesting and redundant description.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:15:25 -08:00
YAMANE Toshiaki
0129544891
staging/serqt_usb2: fixed line over issue in serqt_usb2.c
...
Fixed a description of the procedure call dev_dbg().
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:15:24 -08:00
YAMANE Toshiaki
0093e5f8b3
staging/vme: Use dev_ or pr_ printks in devices/vme_user.c
...
fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
and add pr_fmt.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:13:12 -08:00
Adil Mujeeb
3d20e8e8f9
Staging: winbond: wb35rx_s: Fixed coding style issue
...
Fixed checpatch.pl reported ERRORs (excluding WARNING of line over 80 characters)
Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com >
Acked-by: Pavel Machek <pavel@ucw.cz >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:11:57 -08:00
Adil Mujeeb
2820663c6f
Staging: winbond: mds: Fixed coding style issues
...
Removed printk tracing call
Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com >
Acked-by: Pavel Machek <pavel@ucw.cz >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:11:57 -08:00
Adil Mujeeb
746f0c5a3e
Staging: winbond: wb35rx_f: Fixed coding style issues
...
Fixed checkpatch.pl reported ERRORs
Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com >
Acked-by: Pavel Machek <pavel@ucw.cz >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:11:57 -08:00
Adil Mujeeb
c299647f0c
Staging: winbond: wbusb: Fixed coding style issue
...
Removed unnecessary printk and pr_debug tracing calls
Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com >
Acked-by: Pavel Machek <pavel@ucw.cz >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:11:57 -08:00
Kumar Amit Mehta
466cd9f530
staging: tidspbridge: dynload: reloc.c: checkpatch.pl cleanup
...
fix for few error messages as reported by checkpatch.pl
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:10:39 -08:00
Kumar Amit Mehta
8ee271f63a
staging: tidspbridge: dynload: dload_internal.h: fix for coding style issue
...
fixed few error messages as reported by checkpatch.pl
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:10:39 -08:00
Harvey Yang
695bcb1c0a
staging: usbip: put usb_device and kill event handler thread in error cleanups.
...
If probe returns with error, the kthread is still alive even when all
usbip modules unloaded. So do cleanups in error handler.
Signed-off-by: harvey.yang <harvey.huawei.yang@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 13:08:48 -08:00
Aaro Koskinen
a68292fce1
staging: xgifb: make remaining data tables const
...
Remaining vb_table.h data can be trivially made const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:30 -08:00
Aaro Koskinen
1cccd9e41d
staging: xgifb: constify Tap4 data
...
Make Tap4 data const and adjust functions accordingly.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:30 -08:00
Aaro Koskinen
ea12b4e077
staging: xgifb: eliminate pVBInfo->AGPReg
...
Access XGI340_AGPReg directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:30 -08:00
Aaro Koskinen
0904f7f315
staging: xgifb: eliminate pVBInfo->SR16
...
Inline constant values that are used only once.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:30 -08:00
Aaro Koskinen
5ce24760f6
staging: xgifb: eliminate pVBInfo->CR6B
...
Access XGI340_CR6B directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:30 -08:00
Aaro Koskinen
38c09652a0
staging: xgifb: eliminate pVBInfo->SR21/22/25
...
In-line constants that are used only once.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:29 -08:00
Aaro Koskinen
c705ea8165
staging: xgifb: eliminate pVBInfo->StResInfo
...
Delete unused data.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:29 -08:00
Aaro Koskinen
e8e6c754e5
staging: xgifb: eliminate pVBInfo->ModeResInfo
...
Access XGI330_ModeResInfo directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:24 -08:00
Aaro Koskinen
224114c788
staging: xgifb: eliminate pVBInfo->ScreenOffset
...
Access XGI330_ScreenOffset directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:21 -08:00
Aaro Koskinen
acfe093e82
staging: xgifb: eliminate pVBInfo->VCLKData/VBVCLKData
...
Access XGI_VCLKData and XGI_VBVCLKData directly and make them const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:20 -08:00
Aaro Koskinen
9b04745816
staging: xgifb: eliminate pVBInfo->ECLKData
...
Access XGI340_ECLKData directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:20 -08:00
Aaro Koskinen
7e29d632f3
staging: xgifb: eliminate pVBInfo->CR6E/6F/89
...
Eliminate dummy zero read-only global data.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:20 -08:00
Aaro Koskinen
7c5c07a611
staging: xgifb: eliminate pVBInfo->UpdateCRT1
...
Access XGI_UpdateCRT1Table directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:20 -08:00
Aaro Koskinen
7853bced96
staging: xgifb: eliminate pVBInfo->XGINEWUB_CRT1Table
...
Access XGI_CRT1Table directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:20 -08:00
Aaro Koskinen
a39325d24f
staging: xgifb: eliminate pVBInfo->RefIndex
...
Access XGI330_RefIndex directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:20 -08:00
Aaro Koskinen
b397992e88
staging: xgifb: eliminate pVBInfo->EModeIDTable
...
Access XGI330_EModeIDTable directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:19 -08:00
Aaro Koskinen
3625c9a782
staging: xgifb: eliminate pVBInfo->StandTable
...
Access XGI330_StandTable directly and make it const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:19 -08:00
Aaro Koskinen
6154e7f48a
staging: xgifb: eliminate global TimingV/TimingH data
...
Use private data instead of global variables for timing data. Also,
get rid of the single element arrays.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:19 -08:00
Aaro Koskinen
6008f87765
staging: xgifb: refactor XGI_GetLVDSData()
...
Refactor XGI_GetLVDSData() to avoid nesting and redundant ifs.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:19 -08:00
Aaro Koskinen
bdb381ec74
staging: xgifb: vb_init.h: delete redundant declaration
...
XGI21_LCDCapList does not exist.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:19 -08:00
Aaro Koskinen
bdc9eb142c
staging: xgifb: constify LCD data
...
Make read-only LCD data tables const.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:19 -08:00
Aaro Koskinen
9d1c629925
staging: xgifb: XGI_GetLcdPtr: pass the table pointer directly
...
Let the caller pass the table pointer directly instead of using a magic
number to indicate which table to use.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:18 -08:00
Aaro Koskinen
6c27b37091
staging: xgifb: XGI_GetLcdPtr: delete redundant code
...
tempal is a write-only stack variable, and code touching it can be
deleted.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:18 -08:00
Aaro Koskinen
4736783cca
staging: xgifb: XGI_GetLcdPtr: use real pointers for data tables
...
Use real pointers for LCD data tables to simplify the code.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:18 -08:00
Aaro Koskinen
515e9a603f
staging: xgifb: XGI_GetLcdPtr: replace xgifb_epllcd_crt1
...
Replace xgifb_epllcd_crt1 with two different tables to make further
cleanups easier.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:18 -08:00
Aaro Koskinen
3e779fc949
staging: xgifb: XGI_GetLcdPtr: add separate table for VB_SIS301LV/VB_SIS302LV
...
Add a separate data table for VB_SIS301LV/VB_SIS302LV to avoid branching
and to make further cleanups easier.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:54:18 -08:00
Malcolm Priestley
f1426fd7cc
staging: vt6656: Remove WPA_SUPPLICANT_DRIVER_WEXT_SUPPORT macro
...
Already removed in parts of driver.
Removed in remainder.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-13 12:52:58 -08:00