H Hartley Sweeten
bda230cf25
staging: comedi: ni_670x: fix compile on ARCH=arm
...
The kbuild test robot reported a build error on ARCH=arm about
implicit declaration of the functions 'kmalloc' and 'kfree'.
On ARCH=x86 the slab.h header is indirectly included by pci.h,
this does not occur on ARCH=arm.
Include slab.h directly instead of relying on some other header
to include it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: kbuild test robot <fengguang.wu@intel.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:57:12 -07:00
Jes Sorensen
2e8d47e039
staging: rtl8723au: Remove pointless IS_STA_VALID() macro
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
bc919b0e59
staging: rtl8723au: Remove unused odm_RegDefine11AC.h
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
344af82c94
staging: rtl8723au: ODM_IC_11N_SERIES is always true for SupportICType
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
b3ee999e0b
staging: rtl8723au: rtl8723a_InitBeaconParameters(): Remove unused variable
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
2a3bc8aa4f
staging: rtl8723au: Use proper name REG_CAMCMD and remove wrapper invalidate_cam_all23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
e4d480b012
staging: rtl8723au: Remove RegBcnCtrlVal
...
The value saved in RegBcnCtrlVal was never used. In addition the code
was highly endian broken, declaring it as a u32, then accessing it via
a u8 * later.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
a2c379ce26
staging: rtl8723au: Remove no-op _InitOperation_mode() function
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
120036acec
staging: rtl8723au: Remove no-op usb_AggSetting*()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
ef03600cae
staging: rtl8723au: Remove write-only variable UsbRxHighSpeedMode
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Raphael Silva
1d69fe84f3
staging: rtl8723au: Corrections in the coding style
...
Some corrections were made to the code in order to conform to the
Kernel Coding Style.
Jes: Fix build problem
Signed-off-by: Raphael Silva <rapphil@gmail.com >
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
df72ac93ee
staging: rtl8723au: Use rtl8723au_set_media_status() to replace _InitNetworkType()
...
Reduce yet another duplicate implementation of set_media_status()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
6ec262733e
staging: rtl8723au: Reduce number of duplicate defines for link state
...
We use the MSR bits to define link state anyway, so no point having an
additional two sets of defines for the same thing.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Jes Sorensen
ee225f0f19
staging: rtl8723au: Eliminate Set_MSR() wrapper call
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:54:08 -07:00
Eli Billauer
44909e658e
staging: xillybus: Removed outdated part in README
...
The dedicated memory management routines have been replaced with devres API,
so the related part is removed from the doc.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:18:44 -07:00
Eli Billauer
84590b1aa9
staging: xillybus: Fix if-else coding style errors
...
According to Documentation/CodingStyle, when one branch of an if-else
statement has multiple statements, both branches should be enclosed in curly
brackets.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-17 17:18:44 -07:00
H Hartley Sweeten
736221ef1f
staging: comedi: ni_labpc.h: checkpatch.pl cleanup (unnecessary space)
...
Fix the checkpatch.pl warning:
WARNING: Unnecessary space before function pointer arguments
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:38:00 -07:00
H Hartley Sweeten
2b28a540de
staging: comedi: ni_tio: checkpatch.pl cleanup (braces not necessary)
...
Fix the checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:38:00 -07:00
H Hartley Sweeten
a62669775f
staging: comedi: ni_mio_common: checkpatch.pl cleanup (braces not necessary)
...
Fix the checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:38:00 -07:00
H Hartley Sweeten
56e9bef541
staging: comedi: ni_660x: checkpatch.pl cleanup (space prohibited)
...
Fix the checkpatch.pl warning:
WARNING: space prohibited before semicolon
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:38:00 -07:00
H Hartley Sweeten
c8c8ff887c
staging: comedi: ni_660x: checkpatch.pl cleanup (trailing whitespace)
...
Fix the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:38:00 -07:00
H Hartley Sweeten
f14b622633
staging: comedi: pcl724: checkpatch.pl cleanup (foo*/foo *)
...
Fix the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
205781b746
staging: comedi: serial2000: checkpatch.pl cleanup (kmalloc_array)
...
Fix the checkpatch.pl warning:
WARNING: Prefer kmalloc_array over kmalloc with multiply
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
e685d726c6
staging: comedi: me4000: checkpatch.pl cleanup (complex macro)
...
Fix the checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parenthesis
This define is not used in the driver. Just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
04a4da61a1
staging: comedi: das1800: remove 'volatile' from private data
...
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
e3ebc55f5e
staging: comedi: das16m1: remove 'volatile' from private data
...
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
6691844c6f
staging: comedi: daqboard2000: checkpatch.pl cleanup (space before tab)
...
Fix these checkpatch.pl warnings:
WARNING: please, no space before tabs
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
350a327641
staging: comedi: cb_pcidas64: remove 'volatile' from set_dac_range_bits() param
...
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The 'bits' parameter to this function does not need to
be volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
0f99981a6d
staging: comedi: cb_pcidas64: remove 'volatile' from private data
...
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
931a9c7325
staging: comedi: amcc_s5933.h: checkpatch.pl cleanup (space prohibited)
...
Fix this checkpatch.pl warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:59 -07:00
H Hartley Sweeten
de33276b59
staging: comedi: adv_pci_dio: checkpatch.pl cleanup (fallthrough)
...
Fix these checkpatch.pl warnings:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:58 -07:00
H Hartley Sweeten
11828ce9aa
staging: comedi: adv_pci_dio: checkpatch.pl cleanup (missing blank line)
...
Fix this checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:58 -07:00
H Hartley Sweeten
4318d1d3cd
staging: comedi: ni_tio: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
9a7c5693ca
staging: comedi: mite: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
f740197959
staging: comedi: ni_mio_common: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
fd28703c76
staging: comedi: ni_pcidio: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
c4c2c67a7a
staging: comedi: ni_660x: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
385aea358f
staging: comedi: multiq3: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
c1f946a240
staging: comedi: pcmuio: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:20 -07:00
H Hartley Sweeten
a95b7ccf59
staging: comedi: ni_at_a2150: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
624e6446da
staging: comedi: serial2000: reduce indent level of serial2002_setup_subdevs()
...
Tidy up this function a bit to reduce the indent level.
This also fixex the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
96afd186f0
staging: comedi: serial2000: checkpatch.pl cleanup (missing blank line)
...
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
f06d145f8b
staging: comedi: comedi_test: checkpatch.pl cleanup (break is not useful)
...
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
cd9da6178a
staging: comedi: jr3_pci: checkpatch.pl cleanup (missing blank line)
...
Fix checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
98039f8ac2
staging: comedi: dt9812: checkpatch.pl cleanup (missing blank line)
...
Fix checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
f61b57a40d
staging: comedi: dt2815: checkpatch.pl cleanup (missing blank line)
...
Fix checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
bb905ab1f8
staging: comedi: das1800: checkpatch.pl cleanup (void function return)
...
Fix the checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
d7e31e5661
staging: comedi: das16: checkpatch.pl cleanup (missing blank line)
...
Fix thess checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
a8fa9200a5
staging: comedi: cd_pcidas64: checkpatch.pl cleanup (void function return)
...
Fix the checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:19 -07:00
H Hartley Sweeten
43358ed094
staging: comedi: cb_pcidas64: checkpatch.pl cleanup (missing blank line)
...
Fix this checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Cc: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-07-16 13:37:18 -07:00