Bart Van Assche
bbfa8d7d12
scsi: stex: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-45-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
ec808ef9b8
scsi: snic: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-44-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
12db0f9347
scsi: smartpqi: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-43-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
a6e76e6f2c
scsi: scsi_debug: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-42-bvanassche@acm.org
Acked-by: Douglas Gilbert <dgilbert@interlog.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
ba4baf0951
scsi: qlogicpti: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-41-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
924b3d7a3a
scsi: qla4xxx: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-40-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
c7d6b2c2cd
scsi: qla2xxx: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-39-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
3f5e62c5e0
scsi: qla1280: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. Remove the unused CMD_REQUEST() macro. This patch does not change
any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-38-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:41 -04:00
Bart Van Assche
44656cfb01
scsi: qedi: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-37-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
d995da6122
scsi: qedf: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-36-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
0f8f3ea84a
scsi: ncr53c8xx: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-35-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
43b2d1b14e
scsi: myrs: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-34-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
2fd8f23aae
scsi: myrb: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-33-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
ce425dd7db
scsi: mvumi: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-32-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
24b3c922bc
scsi: mpt3sas: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-31-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
69868c3b69
scsi: mpi3mr: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-30-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:40 -04:00
Bart Van Assche
4bccecf1c9
scsi: megaraid: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-29-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
4221c8a4bd
scsi: lpfc: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-28-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
cad1a780e0
scsi: libsas: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-27-bvanassche@acm.org
Reviewed-by: John Garry <john.garry@huawei.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
240ec11977
scsi: ips: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-26-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
0cd7510201
scsi: ibmvscsi: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-25-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
e9ddad785e
scsi: ibmvfc: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-24-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
84090d42c4
scsi: hpsa: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-23-bvanassche@acm.org
Acked-by: Don Brace <don.brace@microchip.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
1effbface9
scsi: hisi_sas: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-22-bvanassche@acm.org
Acked-by: John Garry <john.garry@huawei.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
e1c9f0cfac
scsi: fnic: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-21-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:39 -04:00
Bart Van Assche
3ada9c791b
scsi: dpt_i2o: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-20-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
d3e16aecea
scsi: cxlflash: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-19-bvanassche@acm.org
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
c14f1fee18
scsi: csiostor: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-18-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
4bfb9809b8
scsi: bnx2i: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-17-bvanassche@acm.org
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
11bf4ec580
scsi: aha1542: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-16-bvanassche@acm.org
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
40e16ce7b6
scsi: advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-15-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
8779b4bdbc
scsi: aacraid: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-14-bvanassche@acm.org
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
2e4b231ac1
scsi: NCR5380: Use sc_data_direction instead of rq_data_dir()
...
This patch prepares for the removal of the request pointer from struct
scsi_cmnd and does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-13-bvanassche@acm.org
Cc: Michael Schmitz <schmitzmic@gmail.com >
Suggested-by: Finn Thain <fthain@linux-m68k.org >
Acked-by: Finn Thain <fthain@linux-m68k.org >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
cd4b46cdb4
scsi: 53c700: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-12-bvanassche@acm.org
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:38 -04:00
Bart Van Assche
d78f31ce7e
scsi: zfcp: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-11-bvanassche@acm.org
Acked-by: Benjamin Block <bblock@linux.ibm.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
9c5274eec7
scsi: RDMA/srp: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-10-bvanassche@acm.org
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
99247108c0
scsi: RDMA/iser: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-9-bvanassche@acm.org
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com >
Reviewed-by: Sagi Grimberg <sagi@grimberg.me >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
c8329cd55b
scsi: ata: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-8-bvanassche@acm.org
Cc: Jens Axboe <axboe@kernel.dk >
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
eb43d41de2
scsi: scsi_transport_spi: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-7-bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
3b4720fc8d
scsi: scsi_transport_fc: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-6-bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
c4deb5b5dd
scsi: sr: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-5-bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
5999ccff0f
scsi: sd: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-4-bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
aa8e25e500
scsi: core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
...
Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. Cast away constness where necessary when passing a SCSI command
pointer to scsi_cmd_to_rq(). This patch does not change any functionality.
Link: https://lore.kernel.org/r/20210809230355.8186-3-bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:37 -04:00
Bart Van Assche
51f3a47889
scsi: core: Introduce the scsi_cmd_to_rq() function
...
The 'request' member of struct scsi_cmnd is superfluous. The struct request
and struct scsi_cmnd data structures are adjacent and hence the request
pointer can be derived easily from a scsi_cmnd pointer. Introduce a helper
function that performs that conversion in a type-safe way. This patch is
the first step towards removing the request member from struct
scsi_cmnd. Making that change has the following advantages:
- This is a performance optimization since adding an offset to a pointer
takes less time than dereferencing a pointer.
- struct scsi_cmnd becomes smaller.
Link: https://lore.kernel.org/r/20210809230355.8186-2-bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de >
Cc: Hannes Reinecke <hare@suse.de >
Cc: Ming Lei <ming.lei@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:36 -04:00
Avri Altman
10163cee1f
scsi: ufs: ufshpb: Do not report victim error in HCM
...
In host control mode, eviction is perceived as an extreme measure. There
are several conditions that both the entering and exiting regions should
meet, so that eviction will take place.
The common case however, is that those conditions are rarely met, so it is
normal that the act of eviction fails. Therefore, do not report an error
in host control mode if eviction fails.
Link: https://lore.kernel.org/r/20210808090024.21721-5-avri.altman@wdc.com
Fixes: 6c59cb501b (scsi: ufs: ufshpb: Make eviction depend on region's reads)
Signed-off-by: Avri Altman <avri.altman@wdc.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:36 -04:00
Avri Altman
22aede9f48
scsi: ufs: ufshpb: Verify that 'num_inflight_map_req' is non-negative
...
'num_inflight_map_req' should not be negative. It is incremented and
decremented without any protection, allowing it theoretically to be
negative, should some weird unbalanced count occur.
Verify that the those calls are properly serialized.
Link: https://lore.kernel.org/r/20210808090024.21721-4-avri.altman@wdc.com
Fixes: 33845a2d84 (scsi: ufs: ufshpb: Limit the number of in-flight map requests)
Signed-off-by: Avri Altman <avri.altman@wdc.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:36 -04:00
Avri Altman
07106f86ae
scsi: ufs: ufshpb: Use a correct max multi chunk
...
In HPB2.0, if pre_req_min_tr_len < transfer_len < pre_req_max_tr_len, the
driver is expected to send a HPB-WRITE-BUFFER companion to HPB-READ.
The upper bound should fit into a single byte, regardless of bMAX_
DATA_SIZE_FOR_HPB_SINGLE_CMD which being an attribute (u32) can be
significantly larger.
To further illustrate the issue, consider the following scenario:
- SCSI_DEFAULT_MAX_SECTORS is 1024 limiting the I/O chunks to 512KB
- The OEM changes scsi_host_template .max_sectors to be 2048 which allows
for 1MB requests: transfer_len = 256
- pre_req_max_tr_len = HPB_MULTI_CHUNK_HIGH = 256
- ufshpb_is_supported_chunk() returns true (256 <= 256)
- WARN_ON_ONCE(256 > 256) doesn't warn
- ufshpb_set_hpb_read_to_upiu() casts transfer_len to u8: transfer_len = 0
- The command is failing with ILLEGAL REQUEST
Link: https://lore.kernel.org/r/20210808090024.21721-3-avri.altman@wdc.com
Fixes: 41d8a9333c (scsi: ufs: ufshpb: Add HPB 2.0 support)
Signed-off-by: Avri Altman <avri.altman@wdc.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:36 -04:00
Avri Altman
283e61c5a9
scsi: ufs: ufshpb: Rewind the read timeout on every read
...
The purpose of the "cold"-timer is not to hang-on to active regions with no
reads. Therefore the read timeout should be rewound on every read, and not
just when the region is activated.
Link: https://lore.kernel.org/r/20210808090024.21721-2-avri.altman@wdc.com
Fixes: 13c044e916 (scsi: ufs: ufshpb: Add "cold" regions timer)
Signed-off-by: Avri Altman <avri.altman@wdc.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2021-08-11 22:25:36 -04:00
Colin Ian King
83da6ad6f9
scsi: pm8001: Remove redundant initialization of variable 'rv'
...
The variable 'rv' is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.
Link: https://lore.kernel.org/r/20210804143319.115340-1-colin.king@canonical.com
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
Addresses-Coverity: ("Unused value")
2021-08-09 23:47:28 -04:00
Colin Ian King
102851fc9a
scsi: ufs: ufshpb: Remove redundant initialization of variable 'lba'
...
The variable 'lba' is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.
Link: https://lore.kernel.org/r/20210804133241.113509-1-colin.king@canonical.com
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
Addresses-Coverity: ("Unused value")
2021-08-09 23:43:05 -04:00