Martin Kaiser
b11ded5e84
staging: r8188eu: remove a constant variable
...
The eRFPath variable in phy_RF6052_Config_ParaFile is always 0.
Remove the variable and use 0 directly. (enum rf_radio_path)eRFPath can
be replaced with RF_PATH_A, which is defined as 0.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220110124638.6909-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:42 +01:00
Martin Kaiser
9922c11a50
staging: r8188eu: fix phy_RF6052_Config_ParaFile error handling
...
Fix the error handling in phy_RF6052_Config_ParaFile.
We can simply return rtStatus.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220110124638.6909-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:42 +01:00
Martin Kaiser
c87c2b0d3e
staging: r8188eu: we always enqueue in rtw_set_chplan_cmd
...
The only caller of rtw_set_chplan_cmd requests that the message be
enqueued and not sent directly.
Remove the enqueue parameter and the code for direct sending.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-13-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:15 +01:00
Martin Kaiser
5495a7ea92
staging: r8188eu: remove HAL_*_ENABLE defines
...
HAL_(MAC|BB|RF)_ENABLE are always set. Remove the defines and the
checks where they are used.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-12-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:15 +01:00
Martin Kaiser
df14a12a2d
staging: r8188eu: HW_VAR_MEDIA_STATUS1 is never set
...
The HW_VAR_MEDIA_STATUS1 hal variable is never set. Remove its define
and the code to set it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-11-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:15 +01:00
Martin Kaiser
e0d4a5e3b5
staging: r8188eu: CurrentCckTxPwrIdx is set but not used
...
CurrentCckTxPwrIdx in struct hal_data_8188e is set but not used.
It can be removed.
The phy_PowerIndexCheck88E function is now empty. Remove it as well.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:15 +01:00
Martin Kaiser
b6ff06063d
staging: r8188eu: CurrentOfdm24GTxPwrIdx is set but not used
...
CurrentOfdm24GTxPwrIdx in struct hal_data_8188e is set but not used.
It can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-9-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
eb32a44393
staging: r8188eu: CurrentBW2024GTxPwrIdx is set but not used
...
CurrentBW2024GTxPwrIdx in struct hal_data_8188e is set but not used.
It can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-8-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
269fae49e8
staging: r8188eu: CurrentBW4024GTxPwrIdx is set but not used
...
CurrentBW4024GTxPwrIdx in struct hal_data_8188e is set but not used.
It can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
bc7fc5fe84
staging: r8188eu: remove obsolete defines and comments
...
Remove some unused phycfg defines and obsolete comments.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
055305b223
staging: r8188eu: remove unused chip type settings
...
Remove some unused defines and macros related to chip type.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
828f2e9d27
staging: r8188eu: ODM_BB_CCK_PD is always set
...
The ODM_BB_CCK_PD flag is always set.
Remove the flag and the check if ODM_BB_CCK_PD is not set.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
dbc04d2730
staging: r8188eu: ODM_BB_FA_CNT is always set
...
The ODM_BB_FA_CNT flag is always set.
Remove the flag and the code to check if ODM_BB_FA_CNT is not set.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Martin Kaiser
d04213433e
staging: r8188eu: ODM_MAC_EDCA_TURBO is always set
...
The ODM_MAC_EDCA_TURBO flag is always set for chips that are supported by
this driver. Remove the flag and the one place where it's checked.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20220108124959.313215-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:18:14 +01:00
Minghao Chi
8765a5bc44
staging: rtl8723bs: remove redundant result variable
...
Return value from ips_netdrv_open() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn >
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn >
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com >
Link: https://lore.kernel.org/r/20220110013240.644190-1-chi.minghao@zte.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:17:45 +01:00
Michael Straube
8c2cffdec7
staging: r8188eu: remove rtw_os_recv_resource_alloc()
...
Merge rtw_os_recv_resource_alloc() into _rtw_init_recv_priv() and
remove rtw_os_recv_resource_alloc().
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220108082736.16788-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:52 +01:00
Michael Straube
ca6246b095
staging: r8188eu: rtw_os_recv_resource_init() does nothing
...
The function rtw_os_recv_resource_init() just returns _SUCCESS and
the return value is not checked by the caller. Remove the function.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220108082736.16788-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:52 +01:00
Michael Straube
da1c0756a2
staging: r8188eu: rtw_os_recv_resource_free() is empty
...
The function rtw_os_recv_resource_free() is empty. Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220108082736.16788-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:52 +01:00
Michael Straube
3a0f2edf54
staging: r8188eu: convert switch to if statement in mgt_dispatcher()
...
The 'switch (GetFrameSubType(pframe))' in mgt_dispatcher() has only
one case that does something different than the default case. Convert
the switch to an if statement to improve readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220108082736.16788-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:52 +01:00
Michael Straube
a5ea39eaa7
staging: r8188eu: rtw_hostapd_mlme_rx() is empty
...
The function rtw_hostapd_mlme_rx() is empty. Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220108082736.16788-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:52 +01:00
Phillip Potter
d601ad5686
staging: r8188eu: convert/remove DBG_88E calls in os_dep/usb_ops_linux.c
...
Convert DBG_88E macro calls in os_dep/usb_ops_linux.c to use netdev_dbg
when they may display useful information, and remove erroneous DBG_88E
calls entirely.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk >
Link: https://lore.kernel.org/r/20220108005550.26264-6-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:19 +01:00
Phillip Potter
198fae4213
staging: r8188eu: convert DBG_88E call in core/rtw_cmd.c
...
Convert the DBG_88E macro call in core/rtw_cmd.c to use netdev_dbg
as its information may be useful to observers, and this gets the
driver closer to the point of being able to remove DBG_88E itself.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk >
Link: https://lore.kernel.org/r/20220108005550.26264-5-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:18 +01:00
Phillip Potter
6397fb278b
staging: r8188eu: remove DBG_88E call from os_dep/osdep_service.c
...
Remove the single DBG_88E macro call from os_dep/osdep_service.c, as it
is unreachable anyway. This gets the driver closer to the eventual
removal of DBG_88E itself.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk >
Link: https://lore.kernel.org/r/20220108005550.26264-4-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:18 +01:00
Phillip Potter
0bfcc8b5c1
staging: r8188eu: convert DBG_88E calls in os_dep/xmit_linux.c
...
Convert three DBG_88E macro calls in core/rtw_ap.c to use netdev_dbg
as their information may be useful to observers, and this gets the
driver closer to the point of being able to remove DBG_88E itself.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk >
Link: https://lore.kernel.org/r/20220108005550.26264-3-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:18 +01:00
Phillip Potter
ea9ac80e2e
staging: r8188eu: convert/remove DBG_88E calls in core/rtw_ap.c
...
Convert DBG_88E macro calls in core/rtw_ap.c to use netdev_dbg when they
may display useful information, and remove erroneous DBG_88E calls
entirely.
This leaves six empty static functions which only had DBG_88E calls,
so just remove them:
update_bcn_fixed_ie
update_bcn_htcap_ie
update_bcn_htinfo_ie
update_bcn_rsn_ie
update_bcn_wpa_ie
update_bcn_wmm_ie
also modifying the if blocks/switch cases that invoke them to no longer do
so. This goes further towards the goal of removing this non-standard
debugging code.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk >
Link: https://lore.kernel.org/r/20220108005550.26264-2-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:15:18 +01:00
Michael Straube
53493c2535
staging: r8188eu: remove HW_VAR_APFM_ON_MAC
...
SetHwReg8188EU() and GetHwReg8188EU() are never called with
HW_VAR_APFM_ON_MAC. Remove that case from both functions.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107215033.12257-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:14:42 +01:00
Michael Straube
dce7cbb4e1
staging: r8188eu: EfuseUsedBytes is set but never used
...
The field EfuseUsedBytes of struct hal_data_8188e is set but never
used. Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107215033.12257-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:14:42 +01:00
Michael Straube
762e47b34b
staging: r8188eu: remove HW_VAR_EFUSE_BYTES from GetHwReg8188EU()
...
GetHwReg8188EU() is never called with HW_VAR_EFUSE_BYTES. Remove that
case from the function.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107215033.12257-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:14:42 +01:00
Michael Straube
f3806385a4
staging: r8188eu: remove HW_VAR_CURRENT_ANTENNA from GetHwReg8188EU()
...
GetHwReg8188EU() is never called with HW_VAR_CURRENT_ANTENNA. Remove
that case from the function.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107215033.12257-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:14:42 +01:00
Michael Straube
08dc8feb14
staging: r8188eu: remove HW_VAR_TXPAUSE
...
SetHwReg8188EU() and GetHwReg8188EU() are never called with
HW_VAR_TXPAUSE. Remove that case from both functions.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107215033.12257-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:14:42 +01:00
Michael Straube
dba29039b6
staging: r8188eu: remove HW_VAR_BASIC_RATE from GetHwReg8188EU()
...
GetHwReg8188EU() is never called with HW_VAR_BASIC_RATE. Remove that
case from the function.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107215033.12257-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:14:42 +01:00
Michael Straube
f19fe1537c
staging: r8188eu: move firmware related macros to rtw_fw.h
...
Move firmware related macros from rtl8188e_hal.h to rtw_fw.h.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107143617.2214-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
9df7cc3a82
staging: r8188eu: add spaces around & operator in IS_FW_HEADER_EXIST
...
Add spaces around & operator in the macro IS_FW_HEADER_EXIST to
improve readability and follow kernel coding style.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107143617.2214-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
106ee4d8c3
staging: r8188eu: rename _pFwHdr in IS_FW_HEADER_EXIST
...
Rename _pFwHdr in the macro IS_FW_HEADER_EXIST to avoid camel case.
_pFwHdr -> _fwhdr
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107143617.2214-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
7235d165d3
staging: r8188eu: move firmware loading code out of the hal layer
...
Move the firmware loading functions from rtl8188e_hal_init.c into the
new file core/rtw_fw.c.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-20-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
dbf1c5e37e
staging: r8188eu: rename pFirmwareBuf and FirmwareLen
...
Rename the variables pFirmwareBuf and FirmwareLen in
rtl8188e_firmware_download() to avoid camel case.
pFirmwareBuf -> fw_data
FirmwareLen -> fw_size
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-19-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
b44dcfb787
staging: r8188eu: rename pFwHdr in rtl8188e_firmware_download()
...
Rename the variable pFwHdr in rtl8188e_firmware_download() to avoid
camel case.
pFwHdr -> fwhdr
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-18-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
9c010d7a72
staging: r8188eu: rename writeFW_retry
...
Rename the variable writeFW_retry in rtl8188e_firmware_download()
to avoid camel case.
writeFW_retry -> write_fw_retry
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-17-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
8a9ee2b4d0
staging: r8188eu: rename FWDL_ChkSum_rpt
...
Rename FWDL_ChkSum_rpt to avoid camel case.
FWDL_ChkSum_rpt -> FWDL_CHKSUM_RPT
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-16-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
fc6730404a
staging: r8188eu: rename rtSatus in rtl8188e_firmware_download()
...
Rename the variable rtStatus in rtl8188e_firmware_download() to avoid
camel case.
rtStatus -> ret
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-15-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
7a0c9c46c4
staging: r8188eu: rename Exit label in rtl8188e_firmware_download()
...
Rename the Exit label in rtl8188e_firmware_download() to avoid camel
case.
Exit -> exit
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-14-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
08c6f78e92
staging: r8188eu: convert two functions from s32 to int
...
Convert the return type of fw_free_to_go() and
rtl8188e_firmware_download() from s32 to the more common int.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-13-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
843e069870
staging: r8188eu: clean up rtw_reset_8051()
...
Rename the local variable u1bTmp in rtw_reset_8051() to avoid camel
case and remove a call to DBG_88E that contains no important
information.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-12-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
f1c140b62f
staging: r8188eu: rename fw related functions to avoid camel case
...
Rename firmware related functions to avoid camel case.
rtl8188e_FirmwareDownload -> rtl8188e_firmware_download
_FWDownloadEnable -> fw_download_enable
_8051Reset88E -> rtw_reset_8051
_FWFreeToGo -> fw_free_to_go
_BlockWrite -> block_write
_PageWrite -> page_write
_WriteFW -> write_fw
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-11-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:44 +01:00
Michael Straube
2441fa93a8
staging: r8188eu: use kmemdup instead of kzalloc and memcpy
...
Use kmemdup instead of kzalloc and memcpy in load_firmware().
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-10-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:43 +01:00
Michael Straube
2f8e84b2d1
staging: r8188eu: rename fields of struct rt_firmware
...
Rename fields of struct rt_firmware to avoid camel case.
szFwBuffer -> data
ulFwLength -> size
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-9-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:43 +01:00
Michael Straube
ca1cb3c278
staging: r8188eu: rename parameter pFirmware of load_firmware()
...
Rename the parameter pFirmware of load_firmware() to avoid camel case.
pFirmware -> rtfw
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:43 +01:00
Michael Straube
4339450145
staging: r8188eu: convert type of return variable in load_firmware()
...
The return type of load_firmware() is int. Change the type of the
return variable from s32 to int to match the function return type.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:43 +01:00
Michael Straube
996d0af0f4
staging: r8188eu: rename rtStatus in load_firmware()
...
Rename the local variable rtStatus in load_firmware() to avoid camel
case.
rtStatus -> ret
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:43 +01:00
Michael Straube
1541c8210a
staging: r8188eu: rename Exit label in load_firmware()
...
Rename Exit label in load_firmware() to avoid camel case.
Exit -> exit
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20220107103620.15648-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-25 16:13:43 +01:00