Jes Sorensen
afa7e480a9
staging: rtl8723au: Move rtw23a_roaming() so we can declare _rtw_roaming() static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:09 -07:00
Jes Sorensen
d944b7218b
staging: rtl8723au: collect_bss_info23a(): Use struct ieee80211_mgmt
...
Somplify code by using struct ieee80211_mgmt to calculate offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:09 -07:00
Jes Sorensen
7ca9ed219b
staging: rtl8723au: Remove unused function rtw_get_timestampe_from_ie23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:09 -07:00
Jes Sorensen
e418361c5b
staging: rtl8723au: Fold _rtw_free_mlme_priv23a() into rtw_free_mlme_priv23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:09 -07:00
Jes Sorensen
56828797ac
staging: rtl8723au: Fold rtw_to_roaming() into the code
...
Simple read variable from a struct function, having it as an external
function is just silly.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:09 -07:00
Jes Sorensen
480c865ed9
staging: rtl8723au: rtw_mlme.c: Clean up mess
...
Clean up spaghetti formatting and avoid NULL initializing variables
where it isn't needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:08 -07:00
Jes Sorensen
684ad6ee72
staging: rtl8723au: Remove dummy function rtw_hostapd_mlme_rx23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:08 -07:00
Jes Sorensen
c8bdc729c2
staging: rtl8723au: Remove another unused prototype
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:08 -07:00
Jes Sorensen
f466c400e7
staging: rtl8723au: Fold some resource allocation abstraction into their callers
...
Fold rtw_os_recvbuf_resource_alloc23a() and
rtw_os_recvbuf_resource_free23a() into the functions calling them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:08 -07:00
Jes Sorensen
09ae6d750c
staging: rtl8723au: Remove unnecessary abstraction rtw_os_recv_resource_alloc23a()
...
No point calling a function to NULL a pointer that was just cleared in
the malloc call.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:08 -07:00
Jes Sorensen
35a5c6f3a3
staging: rtl8723au: Remove unused function rtw_os_read_port23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:08 -07:00
Jes Sorensen
76dc444185
staging: rtl8723au: Clean up namespace clashes with rtl8188eu driver
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:07 -07:00
Jes Sorensen
987bc3fed6
staging: rtl8188eu: os_intfs.c: Mark a couple of variables static
...
Mark these variables local to avoid namespace clash with other RTL
drivers.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:07 -07:00
Jes Sorensen
b809fc44c6
staging: rtl8188eu: usb_intf.c: No point processing an empty table
...
In addition, this would globally disable HT if one device in the
system would mark it unsupported. If any device ended up requiring
this, it should be handled on a per-instance basis.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:07 -07:00
Jes Sorensen
bc55ae446f
staging: rtl8723au: os_intfs.c: Declare a couple of local variables static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:07 -07:00
Jes Sorensen
68e6831e63
staging: rtl8723au: init_channel_set(): Restructure variable names
...
Shorten variable names allowing for fewer broken lines due to the
large number of indents.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:07 -07:00
Jes Sorensen
34df0dd99b
staging: rtl8723au: mgmt_dispatcher23a(): Use struct ieee80211_mgmt
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:07 -07:00
Jes Sorensen
78d2350982
staging: rtl8723au: OnAuth23a(): ieee80211.h-ify
...
Switch to using struct ieee80211_mgmt to obtain offsets. Again a
bizarre +4 offset was applied for the IE scan which doesn't make
sense, since this offset wasn't applied for the auth struct elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:06 -07:00
Jes Sorensen
580e756c60
staging: rtl8723au: OnAuth23aClient23a(): Clean up using struct ieee80211_mgmt
...
Use 80211_mgmt to determine offsets within the received frame. This
also removes a suspicious offset adjustment:
offset = ieee80211_has_protected(hdr->frame_control) ? 4: 0;
which didn't make any sense, since it was only applied to determining
the auth, sequence number, and status, but wasn't applied to the
location of the IEs.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:06 -07:00
Jes Sorensen
6c8207a685
staging: rtl8723au: OnAssocRsp23a() use ieee80211_mgmt to obtain DA
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:06 -07:00
Jes Sorensen
b30f74e0e0
staging: rtl8723au: OnAction23a_back23a(): Use struct ieee8011_mgmt to parse action frames
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:06 -07:00
Jes Sorensen
f5f05715b2
staging: rtl8723au: OnAction23a(): Use struct ieee80211_mgmt instead of hardcoded offsets
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:06 -07:00
Jes Sorensen
0e9596992c
staging: rtl8723au: update_TSF() remove unused argument and move to rtw_mlme_ext.c
...
This is only called from rtw_mlme_ext.c, so move it that and declare
it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:06 -07:00
Jes Sorensen
04fad92a9e
staging: rtl8723au: clean up update_TSF()
...
Clean up and simplify update_TSF() using proper Linux functions and
move it to rtw_mlme_ext.c which is the only user of it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:05 -07:00
Jes Sorensen
9af36808d9
staging: rtl8723au: OnBeacon23a() tidy up code
...
Clean up the excessive if() levels at the end, and use struct
ieee80211_mgmt to calculate pointers passed on to check_assoc_AP23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:05 -07:00
Jes Sorensen
9aac910a12
staging: rtl8723au: rtw_mlme.c: remove commented out debug code
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:05 -07:00
Jes Sorensen
959226ac54
staging: rtl8723au: Remove buggy function _rtw_report_sec_ie()
...
This function was extremely buggy calling kmalloc(GFP_KERNEL) while
holding a spin lock and then potentially overflowing the buffer it had
allocated.
Since the generated output wasn't used for anything, simply rip the
whole thing out.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:05 -07:00
Jes Sorensen
8e64bc584d
staging: rtl8723au: OnProbeReq23a(): is_valid_p2p_probereq is always false
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:05 -07:00
Jes Sorensen
d3c6094950
staging: rtl8723au: OnProbeReq23a(): Use struct ieee80211_mgmt
...
Simplify parsing of probe request frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:04 -07:00
Jes Sorensen
07d2c3b841
staging: rtl8723au: OnAssocReq23a(): use ieee80211_mgmt to calculate offset
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:04 -07:00
Jes Sorensen
43c34be130
staging: rtl8723au: ioctl_cfg80211.c: Use eth_{zero,broadcast},addr()
...
Use kernel provided macros instead of own hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:04 -07:00
Jes Sorensen
29f79e057f
staging: rtl8723au: Remove some unused ieee80211 structs
...
These are duplicated from the kernel headers and not used anymore
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:04 -07:00
Jes Sorensen
30947bbc27
staging: rtl8723au: Remove unused ieee880211_is_empty_essid()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:04 -07:00
Jes Sorensen
5951a5c1b8
staging: rtl8723au: Remove unused dump_wpsie23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:04 -07:00
Jes Sorensen
7e07583247
staging: rtl8723au: Remove struct rtw_ieee802_11_elems and related code
...
This removes the double content tracking of data from IE elements. The
relevant code to validate IEs is moved to rtw_mlme_ext.c as this is
the only place where it is used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:03 -07:00
Jes Sorensen
57ed7bbf7b
staging: rtl8723au: OnAssocReq23a(): Use cfg80211_find_ie() to locate HT caps
...
Use cfg80211 interface to search for HT capabilities.
This was the last user of struct rtw_ieee802_11_elems, which can now
be removed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:03 -07:00
Jes Sorensen
49ae9a5c69
staging: rtl8723au: OnAssocReq23a(): Don't check for presence of BSSID twice
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:03 -07:00
Jes Sorensen
7d6925306c
staging: rtl8723au: OnAssocReq23a(): Simplify parsing crypto info from the IE
...
This reduces the dependency of rtw_ieee802_11_parse_elems23a() which
is only used in this function. Follow-on patches will remove the
remaining dependencies and get rid of the function.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:03 -07:00
Jes Sorensen
ab6fb7a503
staging: rtl8723au: update_bcn_vendor_spec_ie(): Go easy on those brackets
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:03 -07:00
Jes Sorensen
7964eba0d8
staging: rtl8723au: Remove multiple duplicate defines of the WPA OUI
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:03 -07:00
Jes Sorensen
daa5d2f867
staging: rtl8723au: Remove unused for_each_ie() and dump_ies23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:02 -07:00
Jes Sorensen
fcff60e920
staging: rtl8723au: Remove obsolete rtw_get_wpa{2,}_ie23a() functions
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:02 -07:00
Jes Sorensen
9bf29cb940
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Remove unused variable 'pos'
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:02 -07:00
Jes Sorensen
58aedb498f
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Use cfg80211_ API
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:02 -07:00
Jes Sorensen
f88ca60404
staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211 to find WPA info
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:02 -07:00
Jes Sorensen
c37618360e
staging: rtl8723au: rtw_check_bcn_info23a(): Remove excessive brackets
...
Remove excessive brackets and some general cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:01 -07:00
Jes Sorensen
d7f0369827
staging: rtl8723au: rtw_get_cipher_info(): Convert to use cfg80211_* API
...
Use cfg80211_find_ie() and cfg80211_find_vendor_ie() rather than own
hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:01 -07:00
Jes Sorensen
95c4345abf
staging: rtl8723au: Use const * for parsing wpa IEs
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:01 -07:00
Jes Sorensen
731f9da74b
staging: rtl8723au: start_bss_network(): Use cfg80211_find_ie()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:01 -07:00
Jes Sorensen
bf35027425
staging: rtl8723au: update_sta_support_rate23a(): Use cfg80211_find_ie()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-15 11:04:01 -07:00