mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-09 14:56:54 -04:00
Code Issues Packages Projects Releases Wiki Activity
336,509 Commits 1 Branch 929 Tags
8efdc1bf560338b3d40f9eb9985576d35c6eeec7
Commit Graph

336509 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
H Hartley Sweeten
8efdc1bf56 staging: comedi: pcl818: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:19 -08:00
H Hartley Sweeten
b93e56ade2 staging: comedi: pcl816: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pcl816_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:18 -08:00
H Hartley Sweeten
4cd8672ab3 staging: comedi: pcl812: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pcl812_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:18 -08:00
H Hartley Sweeten
d1e27594ed staging: comedi: pcl711: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pcl711_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:18 -08:00
H Hartley Sweeten
aadd0132c5 staging: comedi: ni_tiocmd: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of ni_tio_cmdtest().

Note that cmd->stop_src only has one trigger source so the extra
test is not required.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:18 -08:00
H Hartley Sweeten
616a14d7ad staging: comedi: ni_pcidio: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of ni_pcidio_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:18 -08:00
H Hartley Sweeten
88c793010b staging: comedi: ni_labpc: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of labpc_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:18 -08:00
H Hartley Sweeten
ec3ffe6d42 staging: comedi: ni_atmio16d: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of atmio16d_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:17 -08:00
H Hartley Sweeten
dd254844f1 staging: comedi: ni_at_a2150: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of a2150_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:17 -08:00
H Hartley Sweeten
8c6c5a692d staging: comedi: gsc_hpdi: cleanup step 3 of me4000_ai_do_cmd_test() 
Remove the dev_err() noise and convert the error handling to the
normal form (err |= -EINVAL) used in the do_cmdtest functions.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:17 -08:00
H Hartley Sweeten
bf1b2022ef staging: comedi: gsc_hpdi: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of di_cmd_test().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:17 -08:00
H Hartley Sweeten
39c7bba8cc staging: comedi: dt3000: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of dt3k_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:17 -08:00
H Hartley Sweeten
61e55b88fd staging: comedi: dt282x: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of dt282x_{ai,ao}_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:17 -08:00
H Hartley Sweeten
2345dc8b0c staging: comedi: dt2814: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of dt2814_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:16 -08:00
H Hartley Sweeten
e43ed5fa14 staging: comedi: dmm32at: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of dmm32at_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:16 -08:00
H Hartley Sweeten
35402007dd staging: comedi: das1800: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of das1800_ai_do_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:16 -08:00
H Hartley Sweeten
050b3b1830 staging: comedi: das16m1: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of das16m1_cmd_test().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:16 -08:00
H Hartley Sweeten
a48e1258b4 staging: comedi: das16: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of das16_cmd_test().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:16 -08:00
H Hartley Sweeten
00d9c8cb5f staging: comedi: cb_pcidas: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of cb_pcidas_{ai,ao}_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:05 -08:00
H Hartley Sweeten
7d4adbe4f1 staging: comedi: cb_das16_cs: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of das16cs_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:04 -08:00
H Hartley Sweeten
670c475cf0 staging: comedi: amplc_pci230: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pci230_{ao,ai}_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:04 -08:00
H Hartley Sweeten
0427c4847e staging: comedi: amplc_pci224: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pci224_ao_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:04 -08:00
H Hartley Sweeten
ad23feaa1e staging: comedi: adv_pci1710: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pci171x_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:04 -08:00
H Hartley Sweeten
1b44331348 staging: comedi: adl_pci9118: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pci9118_ai_do_cmd_test().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:04 -08:00
H Hartley Sweeten
430f87dad7 staging: comedi: adl_pci9111: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pci9111_ai_do_cmd_test().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:04 -08:00
H Hartley Sweeten
fa567598f0 staging: comedi: hwdrv_apci3120: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of i_APCI3120_CommandTestAnalogInput().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:03 -08:00
H Hartley Sweeten
df5daff81f staging: comedi: comedi_test: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of waveform_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:03 -08:00
H Hartley Sweeten
50b825ffa3 staging: comedi: das800: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of das800_ai_do_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:03 -08:00
H Hartley Sweeten
c563065bb1 staging: comedi: pcm_common: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of comedi_pcm_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:03 -08:00
H Hartley Sweeten
5f93c88fe7 staging: comedi: ni_65xx: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of ni_65xx_intr_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:03 -08:00
H Hartley Sweeten
effa7a282e staging: comedi: ni_6527: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of ni6527_intr_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:03 -08:00
H Hartley Sweeten
7efbbc37db staging: comedi: amplc_pc236: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of pc236_intr_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:02 -08:00
H Hartley Sweeten
a1d6de5a98 staging: comedi: amplc_dio200: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of dio200_subdev_intr_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:02 -08:00
H Hartley Sweeten
58bed93eeb staging: comedi: addi_apci_1032: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of apci1032_cos_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:02 -08:00
H Hartley Sweeten
2404271050 staging: comedi: comedi_parport: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of parport_intr_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:02 -08:00
H Hartley Sweeten
851eef809c staging: comedi: 8255: use cfc_check_trigger_arg_*() helpers 
Use the new helpers in the step 3 tests of subdev_8255_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:02 -08:00
H Hartley Sweeten
61ca8bac45 staging: comedi: comedi_fc.h: introduce new helpers for do_cmdtest step 3 
Step 3 of the do_cmdtest functions validates the arguments for the
command to be executed. Most of these are simple tests to see if the
argument "is" a value, a "min" value, or a "max" value. Each of these
tests then clamps the argument to the value if it fails the test.

Introduce three new helper functions in comedi_fc.h to handle these
tests and remove the boilerplate code from the drivers.

The new helper functions are:

cfc_check_trigger_arg_is()  - argument must be == the value
cfc_check_trigger_arg_min() - argument must be >= the value
cfc_check_trigger_arg_max() - argument must be <= the value

All of these helpers set the argument to the value and return -EINVAL
if the validation fails.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-14 16:23:01 -08:00
H Hartley Sweeten
1f168dbdf7 staging: comedi: Kconfig: remove VIRT_TO_BUS depends on 
The only addi-data driver that uses virt_to_bus is addi_apci_3120.
Remove the depends on for the other addi-data drivers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:33:54 -08:00
Andy Gross
743815ae1b staging: drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR 
Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a
refill engine.

Signed-off-by: Andy Gross <andy.gross@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:14:59 -08:00
H Hartley Sweeten
be3c5126b5 staging: comedi: addi_apci_1516: update the MODULE_DESCRIPTION 
Change the generic MODULE_DESCRIPTION text to something more
specific for this driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:56 -08:00
H Hartley Sweeten
98071b6773 staging: comedi: addi_apci_1516: update the Kconfig 
This driver does not use virt_to_bus(), remove the depends on for it.

Update the Kconfig entry to list all the boards supported by this
driver. Also, expand the help text a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:56 -08:00
H Hartley Sweeten
3f0732a724 staging: comedi: addi_apci_1516: reword the initialization comments 
The subdevice init does not do any allocation, this was already done
by comedi_alloc_subdevices(). Reword the comments a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:55 -08:00
H Hartley Sweeten
07e957120d staging: comedi: addi_apci_1516: rename has_timer 
The "timer" on these boards is actually a watchdog. Rename the
boardinfo value "has_timer" to "has_wdog".

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:55 -08:00
H Hartley Sweeten
1567ceaa3f staging: comedi: addi_apci_1516: final cleanup of the register map defines 
I finally got hold of the i/o mapping from ADDI-DATA. Cleanup the defines
a bit and add the missing information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:55 -08:00
H Hartley Sweeten
0ff1fa7768 staging: comedi: addi_apci_1516: fix i_APCI1516_StartStopWriteWatchdog() 
This function is used by the watchdog subdevice to "ping" the watchdog.
Rename the CamelCase function to apci1516_wdog_insn_write.

Currently this function does not follow the comed API. INSN_WRITE functions
are supposed to write insn->n values. Also, starting and stopping the
watchdog is handled by the INSN_CONFIG function.

Fix this function so it works like the comedi core expects. Also, since
the watchdog needs to be enabled in order to "ping" it, make sure it is
enabled before writing to it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:55 -08:00
H Hartley Sweeten
158b64973e staging: comedi: addi_apci_1516: fix i_APCI1516_ConfigWatchdog() 
This function is used by the watchdog subdevice to enable/disable and
set the timeout for the watchdog. Rename the CamelCase function to
apci1516_wdog_insn_config.

Currently this function does not follow the comed API. Recode it so
it works like the core expects. data[0] is the configuration id code
(INSN_CONFIG_*) for the configuration instruction. Two instructions
are supported:

INSN_CONFIG_ARM: enables the watchdog and sets the timeout value
INSN_CONFIG_DISARM: disables the watchdog

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:55 -08:00
H Hartley Sweeten
9151b01f3c staging: comedi: addi_apci_1516: fix i_APCI1516_ReadWatchdog() 
This function is used by the watchdog subdevice to read the status of
the watchdog. Rename the CamelCase function to apci1516_wdog_insn_read
and fix the function to return the status value insn->n times like
the comedi core expects.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:55 -08:00
H Hartley Sweeten
5c7c83230c staging: comedi: addi_apci_1516: cleanup the subdevice init 
For aesthetic reasons. add some whitespace to the subdevice init.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:54 -08:00
H Hartley Sweeten
87722a7ab7 staging: comedi: addi_apci_1516: cleanup apci1516_detach() 
This driver uses the comedi auto_config mechanism to attach to
the comedi subsystem. The dev->hw_dev is set by the core so
comedi_to_pci_dev() will always return a valid pcidev. Remove
the unnecessary test.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:54 -08:00
H Hartley Sweeten
9138de6b6b staging: comedi: addi_apci_1516: add defines for the PCI device ids 
The PCI device ids supported by this driver are used multiple places
in the code. To improve maintainability, create #define's for them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2012-11-13 15:12:54 -08:00