Navya Sri Nizamkari
82d28561b7
staging: comedi: Remove if condition.
...
This patch removes a if condition which has a semicolon
after it. As the conditional check is redundant, the comment
before it is also changed. The following
coccinelle script was used to detect the pattern of a
semicolon after if.
@r1@
position p;
@@
if (...);@p
@script:python@
p0 << r1.p;
@@
// Emacs org-mode output
cocci.print_main("", p0)
cocci.print_secs("", p0)
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:32 -08:00
Tina Johnson
324588eccc
staging: lustre: lustre: libcfs: Replaced printk() with pr_err() and pr_cont()
...
The following checkpatch warning was fixed:
Prefer [subsystem eg: netdev]_err([subsystem]dev
with the help of Coccinelle. pr_cont() was used to replace those printk
statements which followed a printk that did not end with a '\n'. The following
semantic patch was used to replace printk() with pr_err():
@a@
expression e;
@@
printk(e,...);
@script:python b@
e << a.e;
y;
@@
import re
match = re.match('KERN_ERR ', e);
if (match == None):
cocci.include_match(False)
else:
m = re.sub('KERN_ERR ', '', e)
coccinelle.y = m;
@c@
expression a.e;
identifier b.y;
@@
- printk(e,
+ pr_err(y,
...);
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:32 -08:00
Tina Johnson
85b7a9de00
staging: lustre: lustre: libcfs: Replaced printk() with pr_err()
...
The following checkpatch warning was fixed:
Prefer [subsystem eg: netdev]_err([subsystem]dev
with the help of Coccinelle. The following semantic patch was used:
@a@
expression e;
@@
printk(e,...);
@script:python b@
e << a.e;
y;
@@
import re
match = re.match('KERN_ERR ', e);
if (match == None):
cocci.include_match(False)
else:
m = re.sub('KERN_ERR ', '', e)
coccinelle.y = m;
@c@
expression a.e;
identifier b.y;
@@
- printk(e,
+ pr_err(y,
...);
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:32 -08:00
Jes Sorensen
fe6e0197ba
staging: rtl8723au: odm.c: Break some lines down to 80 characters
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:32 -08:00
Jes Sorensen
c335da5726
staging: rtl8723au: ODM_Write_DIG23A(): Cosmetic cleanups
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:32 -08:00
Jes Sorensen
b58298eee2
staging: rtl8723au: Clean up odm_RefreshRateAdaptiveMask()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
0305d27d9e
staging: rtl8723au: Clean up FindMinimumRSSI()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
04b7466fa5
staging: rtl8723au: Clean up odm_RSSIMonitorCheck()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
1a5767e882
staging: rtl8723au: ODM_TXPowerTrackingCheck23a(): Remove no-op function
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
dd42f95cf0
staging: rtl8723au: Remove write only bIsCurRDLState
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
bb1ede84df
staging: rtl8723au: Remove unused struct pri_cca
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
761b6031a4
staging: rtl8723au: Remove unused struct odm_fat_t
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:31 -08:00
Jes Sorensen
8bf591e5c1
staging: rtl8723au: Remove unused Funai TV hack
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
8d8a61c4b2
staging: rtl8723au: Remove write-only variable ControlChannel
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
9d693e3a09
staging: rtl8723au: SupportInterface is always set to USB
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
b9c39d293f
staging: rtl8723au: Remove no-op ODM_CMNINFO_PLATFORM
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
8122a8c88e
staging: rtl8723au: odm_dtc(): Remove no-op function
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
8cba07d71d
staging: rtl8723au: Make odm_PHY_SaveAFERegisters() readable
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
ea89e2f6b7
staging: rtl8723au: Remove unused ODM ability flags
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
fec75cd5f1
staging: rtl8723au: ODM_RF_CALIBRATION is never set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
4be419e6d3
staging: rtl8723au: ODM_RF_TX_PWR_TRACK is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:30 -08:00
Jes Sorensen
719d3f6cf0
staging: rtl8723au: ODM_BB_PWR_SAVE is unused
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:29 -08:00
Jes Sorensen
6bdef7a0d4
staging: rtl8723au: ODM_BB_CCK_PD is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:29 -08:00
Jes Sorensen
01c1ec0057
staging: rtl8723au: ODM_BB_RSSI_MONITOR is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:29 -08:00
Jes Sorensen
399ec83079
staging: rtl8723au: ODM_BB_FA_CNT is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:28 -08:00
Jes Sorensen
6920f3b968
staging: rtl8723au: ODM_BB_DYNAMIC_TXPWR isn't used for anything
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:28 -08:00
Jes Sorensen
3d51a602dc
staging: rtl8723au: ODM_BB_DIG is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:28 -08:00
Jes Sorensen
79afea1b30
staging: rtl8723au: ODM_BB_RA_MASK is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:28 -08:00
Jes Sorensen
6520715ed2
staging: rtl8723au: ODM_MAC_EDCA_TURBO is always set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:27 -08:00
Jes Sorensen
4b4431ce04
staging: rtl8723au: Avoid zero initializing variables unnecessarily
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:27 -08:00
Jes Sorensen
daa656b224
staging: rtl8723au: Variable bbtchange is always false
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:27 -08:00
Haneen Mohammed
f737ea50ba
Staging: emxx_udc: Remove custom printk macro ERR
...
This patch removes custom printk macro ERR.
All the calls to this macro were replaced by de_err and pr_err.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:26 -08:00
Haneen Mohammed
886892798c
Staging: emxx_udc: Replace custom printk macro ERR with dev_err or pr_err
...
This patch removes the use of custom printk macros ERR and replace it
with dev_err, or pr_err in the following cases:
- if no appropriate struct device *dev field where found for dev_err.
- or dev could be null eg. "dev_err(udc->dev" not possible inside "if
(udc == null)"
Issue addressed by checkpatch.pl.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:26 -08:00
Haneen Mohammed
d45c4c654d
Staging: emxx_udc: Remove argument test from function
...
This patch removes the test statement for an argument to _nbu2ss_pullup
function, for it can't be null due to previous derefrences.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:26 -08:00
Haneen Mohammed
f6ef6c094e
Staging: emxx_udc: Fix do not add new typedefs and remove volatile
...
This patch fixes the following checkpatch.pl warnings:"do not add new
typedefs" and "Use of volatile is usually wrong".
Remove typedefs keyword and rename identifiers appropriately.
Remove volatile from union usb_regs_access
Update related files.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:26 -08:00
Dilek Uzulmez
fad0d05f7c
Staging: fbtft: Remove unnecessary 'out of memory' message.
...
This patch fixes checkpatch.pl warning in file fb_ssd1351.c
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:26 -08:00
Dilek Uzulmez
6cb624ef71
Staging: fbtft: Remove unnecessary 'out of memory' message.
...
This patch fixes checkpatch.pl warning in file fbtft-core.c
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:25 -08:00
Yeliz Taneroglu
6ba67a5a7b
Staging: fbtft-core: remove unnecessary line continuations
...
This fixes the checkpatch.pl warning:
WARNING: Avoid unnecessary line continuations
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:25 -08:00
Daniele Alessandrelli
dd03eed307
staging: rtl8723au: rtl8723a_hal_init.c: remove unnecessary braces
...
Fix all checkpatch "braces {} are not necessary" warnings for
rtl8723au/hal/rtl8723a_hal_init.c
Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@gmail.com >
Acked-by: Larry Finger <Larry.Finger@lwfinger.net >
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:25 -08:00
Jes Sorensen
19c7b64455
staging: rtl8723au: MAX_AGGR_NUM is not used
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:24 -08:00
Jes Sorensen
929e570ae2
staging: rtl8723au: The RF on an 8723au is always a 6052
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:24 -08:00
Jes Sorensen
277c722cd6
staging: rtl8723au: Remove rf type from struct hal_version
...
This gets rid of yet another duplicated copy of the RF type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:24 -08:00
Jes Sorensen
f1508fe3bb
staging: rtl8723au: Be more consistent in checking for 2 TX paths
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:24 -08:00
Jes Sorensen
162904699a
staging: rtl8723au: No need for two copies of rf_type
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:24 -08:00
Jes Sorensen
9939cf9427
staging: rtl8723au: Firmware always handles adaptive rates
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:23 -08:00
Jes Sorensen
7ea9039d91
staging: rtl8723au: hal_com.h: Remove some unused #defines
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:23 -08:00
Jes Sorensen
49361cafe3
staging: rtl8723au: Remove more unused #defines
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:23 -08:00
Jes Sorensen
164b46666d
staging: rtl8723au: rtl8723a_add_rateatid() simplyfy code
...
No point shifting raid right, just to shift it left again before
re-adding it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:23 -08:00
Jes Sorensen
b1e4d2f623
staging: rtl8723au: rates are always set via the firmware interface
...
The only case where fw_ractrl = false was when the firmware failed to
load, and in that case we are dead in the water anyway.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:23 -08:00
Jes Sorensen
25094468a1
staging: rtl8723au: Use RF_AC instead of hardcoded value for RF register write
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-03-06 09:54:23 -08:00