Carlos Henrique Lima Melara
7d50888090
staging: qlge: Fix WARNING: Missing a blank line after declarations
...
Fixed WARNING: Missing a blank line after declarations in qlge_mpi.c to
the following lines:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:94:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:240:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:258:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:356:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:915:
WARNING: Missing a blank line after declarations
FILE: drivers/staging/qlge/qlge_mpi.c:1099:
Signed-off-by: Carlos Henrique Lima Melara <charlesmelara@outlook.com >
Link: https://lore.kernel.org/r/CP2PR80MB434086A44A1ED5BB662B9D70A8FC0@CP2PR80MB4340.lamprd80.prod.outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Andre Pinto
3394cf0779
staging: rtl8188eu: fix typo s/informations/information
...
Fix checkpatch check: 'informations' may be misspelled - perhaps
'information'? in rtw_mlme_ext.c:1151.
Signed-off-by: Andre Pinto <andrealmeidap1996@gmail.com >
Link: https://lore.kernel.org/r/20200311012638.18889-1-andrealmeidap1996@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Lourdes Pedrajas
d154c0a968
staging: vt6655: power.c: code reformatting for improved readability
...
Improve line grouping for better understanding the course of action and where
every comment belongs to.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/3fada7fe76047ecf06d0345c0ab9216424a126f2.1583848946.git.lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Lourdes Pedrajas
3cd8958935
staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()
...
Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but
this feature it is marked TODO in 2014 and did go untouched since 2015.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/d9b8e434e09cb8885026a71441bf3a6919dba3da.1583848946.git.lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Sergio Paracuellos
5ca61dffc7
staging: mt7621-pci: enable clock bit for each port
...
The clock related code concerns me from the very beginning because
there are some set ups got from legacy driver that are not documented
anywhere. According to the programming guide 0x7c is 'CPE_ROSC_SEL1'
register and 0x80 is 'CPU_CPE_CN'. I do think this set up is not needed
at all and the proper thing to do is just enable the clock bit for each
pcie port. Hence remove useless code and do the right thing which is
setting up the clock bit for each port enabled.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20200310113459.30539-1-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:48 +01:00
Deepak R Varma
05ffb11ca7
staging: comedi: dt282x: remove old unused code
...
There are two #if 0 blocks that have no recent history of any change.
Remove those code blocks for improved readability of the code.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20200310212545.GA8914@deeUbuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:54 +01:00
Kaaira Gupta
c9edd29754
staging: wfx: remove unused structure
...
struct hif_cnf_reset is not used anywhere in wfx. It's parent file
hif_api_cmd.h is imported form some other driver, hence some functions
in it are not used. This is one of them. Hence remove it.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-7-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:54 +01:00
Kaaira Gupta
02a33f8e06
staging: wfx: remove variable declaration
...
int ret is uneccessarily declared and 0 assigned to it. Return o
directly instead.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-6-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
3f716acc27
staging: wfx: data_tx.h: remove space after cast
...
remove extra space after a cast in file data_tx.h
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-5-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
df69646bf2
staging: wfx: dat_tx.c: remove space after a cast
...
remove extra spaces after casts in file data_tx.c
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-4-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
c67dc09fac
staging: wfx: change 1 to bool
...
policies[i].uploaded is a bool. 1 is assigned to it. Change it to bool.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-3-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Kaaira Gupta
98c386c264
staging: wfx: data_rx.c: remove space after cast
...
remove an unesseccary space after a cast in file data_rx.c
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in >
Link: https://lore.kernel.org/r/20200310142509.25632-2-kgupta@es.iitr.ac.in
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:04:53 +01:00
Greg Kroah-Hartman
590a95e418
staging: exfat: remove staging version of exfat filesystem
...
Now that there is a "real" solution for exfat in the vfs tree queued up
to be merged in 5.7-rc1 the "old" exfat code in staging can be removed.
Many thanks to Valdis for doing the work to get this into the tree in
the first place, it was greatly appreciated.
Acked-by: Valdis Kletnieks <valdis.kletnieks@vt.edu >
Cc: Pali Rohár <pali@kernel.org >
Cc: Stephen Rothwell <sfr@canb.auug.org.au >
Cc: Al Viro <viro@ZenIV.linux.org.uk >
Cc: Namjae Jeon <namjae.jeon@samsung.com >
Cc: Sungjong Seo <sj1557.seo@samsung.com >
Cc: Christoph Hellwig <hch@lst.de >
Link: https://lore.kernel.org/r/20200310105421.GA2810679@kroah.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 12:30:34 +01:00
Sergio Paracuellos
9a5e71a68d
staging: mt7621-pci: simplify 'mt7621_pcie_init_virtual_bridges' function
...
Function 'mt7621_pcie_init_virtual_bridges' is a bit mess and can be
refactorized properly in a cleaner way. Introduce new 'pcie_rmw' inline
function helper to do clear and set the correct bits this function needs
to work.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20200308091928.17177-1-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:52:27 +01:00
Zhenzhong Duan
8080b0f537
staging: speakup: Fix a typo error print for softsynthu device
...
When softsynthu device fails the register, "/dev/softsynthu" should be
printed instead of "/dev/softsynth".
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com >
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org >
Cc: William Hubbs <w.d.hubbs@gmail.com >
Cc: Chris Brannon <chris@the-brannons.com >
Cc: Kirk Reiser <kirk@reisers.ca >
Link: https://lore.kernel.org/r/20200305072151.403-1-zhenzhong.duan@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Malcolm Priestley
696089de8e
staging: vt6656: struct vnt_rcb remove unused in_use.
...
The variable merely toggles true to false and is unused.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/130a4078-2502-a381-46c4-b473815e153b@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Malcolm Priestley
d1ec124246
staging: vt6656: Remove vnt_interrupt_buffer in_use flag.
...
mac80211 is the only user of in_use to start it and should
not be true when so.
So internal toggling of this variable is not relevant.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/69585034-4318-4bec-7d9b-f64a167df237@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Sergiu Cuciurean
b26b1391df
staging: wilc1000: spi: Use new structure for SPI transfer delays
...
In a recent change to the SPI subsystem in commit <bebcfd272df6>
("spi: introduce `delay` field for `spi_transfer` +
spi_transfer_delay_exec()"), a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.
The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com >
Link: https://lore.kernel.org/r/20200304074319.22107-1-sergiu.cuciurean@analog.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Sergiu Cuciurean
19a91ec87a
staging: kpc2000: kpc2000_spi: Use new structure for SPI transfer delays
...
In a recent change to the SPI subsystem in commit <bebcfd272df6>
("spi: introduce `delay` field for `spi_transfer` +
spi_transfer_delay_exec()"), a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.
The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com >
Link: https://lore.kernel.org/r/20200304073746.19664-1-sergiu.cuciurean@analog.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:51:20 +01:00
Shreeya Patel
d2ac333d2e
Staging: rtl8188eu: Add space around operator
...
Add space around & operator for improving the code
readability.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Acked-by: Julia Lawall <julia.lawall@inria.fr >
Link: https://lore.kernel.org/r/20200308192152.26403-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:50 +01:00
Lourdes Pedrajas
c12b19af4a
staging: hp: remove commented out code
...
Remove unused code.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Link: https://lore.kernel.org/r/20200308225400.17267-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:49 +01:00
Payal Kshirsagar
1657f11c7c
staging: exfat: alignment should match open parenthesis
...
Align code to match open parenthesis.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309165138.5313-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:49 +01:00
Lourdes Pedrajas
b92a047b2e
staging: exfat: exfat_super.c: remove commented out function
...
Remove function ffsSetAttr() which is unused.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Link: https://lore.kernel.org/r/20200309165801.4827-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:44:49 +01:00
Shreeya Patel
9eafa2b71a
Staging: rtl8723bs: Remove comparison to true
...
Remove comparison to "true" from if statement to
maintain the kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com >
Link: https://lore.kernel.org/r/20200308201703.31709-1-shreeya.patel23498@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:23 +01:00
Payal Kshirsagar
a5e7d27e2d
staging: ks7010: remove line over 80 characters
...
Remove line over 80 characters.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200308123834.3377-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:23 +01:00
Payal Kshirsagar
95f67ef3d2
staging: wfx: remove blank line
...
Blank line is not necessary before a close brace '}', remove it.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com >
Link: https://lore.kernel.org/r/20200309165528.5721-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Payal Kshirsagar
bcfb8b05a9
staging: wfx: alignment should match open parenthesis
...
Align code to open parenthesis.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309164515.4880-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Thomas Gleixner
66d93d7ff9
staging: greybus: Fix the irq API abuse
...
Nothing outside of low level architecture code is supposed to look up
interrupt descriptors and fiddle with them.
Replace the open coded abuse by calling generic_handle_irq().
This still does not explain why and in which context this connection
magic is injecting interrupts in the first place and why this is correct
and safe, but at least the API abuse is gone.
Fixes: 036aad9d02 ("greybus: gpio: add interrupt handling support")
Fixes: 2611ebef83 ("greybus: gpio: don't call irq-flow handler directly")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Acked-by: Johan Hovold <johan@kernel.org >
Link: https://lore.kernel.org/r/87o8t9boqq.fsf@nanos.tec.linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Lourdes Pedrajas
add1a2faba
staging: greybus: i2c.c: remove commented out function
...
Remove function gb_i2c_smbus_xfer() which is unused.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Link: https://lore.kernel.org/r/20200309170643.4947-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Payal Kshirsagar
b642a2f931
staging: qlge: qlge.h: remove excess newlines
...
Blank lines aren't necessary after an open brace '{'.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309162728.4342-4-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Payal Kshirsagar
98624b53ee
staging: qlge: qlge.h: add spaces around operators
...
Add spaces around operators cleanup reported by checkpatch.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309162728.4342-3-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:22 +01:00
Payal Kshirsagar
e148bdb2ed
staging: qlge: qlge.h: remove spaces before tabs and align code
...
Remove white spaces before tabs and align code properly for readability.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309162728.4342-2-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:21 +01:00
Payal Kshirsagar
70ab9945f2
staging: qlge: remove blank line
...
Remove unnecessary multiple blank lines.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200309094036.3957-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:21 +01:00
Payal Kshirsagar
a632b9faec
staging: vt6655: alignment should match open parenthesis
...
Align code to the open parenthesis to fix the alignment issue.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309170927.6171-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:21 +01:00
Payal Kshirsagar
ad3ee73007
staging: vt6656: remove blank line
...
To avoid style issues, remove multiple blank lines.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Acked-by: Julia Lawall <julia.lawall@inria.fr >
Link: https://lore.kernel.org/r/20200309073424.4920-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:21 +01:00
Ajay Singh
0fc6d4e4ce
staging: wilc1000: use flexible-array member instead of zero-length array
...
Use flexible-array member introduced in C99 instead of zero-length
array. Most of zero-length array was already taken care in previous
patch [1]. Now modified few more cases which were not handled earlier.
[1]. https://patchwork.kernel.org/patch/11394197/
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20200302162226.4196-4-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:55:02 +01:00
Ajay Singh
f79a8a85cc
staging: wilc1000: remove unnecessary always true 'if' conditions
...
Remove the unnecessary always true 'if' conditions and simiplifed the
logic as suggested in [1].
[1]. https://lore.kernel.org/linux-wireless/20200302092346.GA24308@kadam/
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20200302162226.4196-3-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:55:02 +01:00
Ajay Singh
efabc44b80
staging: wilc1000: use correct data for memcpy in wilc_hif_pack_sta_param()
...
Use correct data for memcpy in wilc_hif_pack_sta_param(). Its
reported by Smatch static code analyser tool as discussed in [1].
[1]. https://lore.kernel.org/linux-wireless/20200302092346.GA24308@kadam/
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20200302162226.4196-2-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:55:02 +01:00
Oscar Carter
7db73c8c90
staging: vt6656: Remove unnecessary local variables initialization
...
Don't initialize variables that are then set a few lines later.
Signed-off-by: Oscar Carter <oscar.carter@gmx.com >
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk >
Link: https://lore.kernel.org/r/20200301135028.11753-1-oscar.carter@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:54:09 +01:00
Malcolm Priestley
3c505f508f
staging: vt6656: Move vnt_rx_data to usbpipe.c
...
vnt_rx_data is a USB function and vnt_submit_rx_urb_complete is
the only caller therefore removing dpc.c/h files and becoming
static.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/d3937276-5a47-7184-e263-84d9c9cb5c7a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:54:09 +01:00
Malcolm Priestley
10e9a359ce
staging: vt6656: Delete int.c/h file and move functions to usbpipe
...
Move functions vnt_int_process_data and vnt_int_report_rate to
usbpipe.c and vnt_interrupt_data to usbpipe.h
These form part of the USB structure.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/bc21d3d7-81be-4ec1-030e-4e7a45f98238@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:32 +01:00
Malcolm Priestley
05f665dd0f
staging: vt6656: Remove function vnt_int_process_data.
...
call vnt_start_interrupt_urb directly from vnt_start.
Move debug message to vnt_start_interrupt_urb.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/dff3a1d0-4d24-d9ea-2a15-c81fd544bc79@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:32 +01:00
Malcolm Priestley
0fd349fd1d
staging: vt6656: vnt_int_start_interrupt remove spin lock.
...
This formed part of the legacy driver and potentially multi
users.
The driver now has only one user mac80211 remove this lock.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/871a78d4-6d3e-f34b-d0ae-6123803c6faf@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:32 +01:00
Malcolm Priestley
f75bb88fef
staging: vt6656: vnt_vt3184_init remove stack copy to array.
...
use u8 pointer addr directly and remove stack array.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/49f34764-c90c-8c5f-b4f2-a3668b13e519@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:32 +01:00
Malcolm Priestley
c3aee66261
staging: vt6656: use vnt_vt3184_agc array directly
...
vnt_vt3184_agc is always the same regardless of rf type
so use the array directly removing from stack buffer.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/4b455ee4-7ac7-e1ff-4a10-2d99f2e30714@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:32 +01:00
Malcolm Priestley
2812ab8963
staging: vt6656: Remove STATUS enums from TX path
...
Returning standard error code or status variable.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/21bf299b-63e0-9f65-c7db-6e0b72e0f1d8@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:31 +01:00
Malcolm Priestley
3b4922deaf
staging: vt6656: Use mac80211 duration for tx headers
...
mac80211 already provides the correct duration simply
copy it to the tx headers removing the need for driver
to find it with vnt_get_duration_le.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Link: https://lore.kernel.org/r/0cdde611-119b-b223-e8c8-b59fb497a7b9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:31 +01:00
Dan Carpenter
72db61d7d1
staging: kpc2000: prevent underflow in cpld_reconfigure()
...
This function should not allow negative values of "wr_val". If
negatives are allowed then capping the upper bound at 7 is
meaningless. Let's make it unsigned.
Fixes: 7dc7967fc3 ("staging: kpc2000: add initial set of Daktronics drivers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Cc: stable <stable@vger.kernel.org >
Link: https://lore.kernel.org/r/20200224103325.hrxdnaeqsthplu42@kili.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:52:31 +01:00
Tetsuhiro Kohada
580f57c2cf
staging: exfat: remove redundant if statements
...
If statement does not affect results when updating directory entry in
ffsMapCluster().
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp >
Link: https://lore.kernel.org/r/20200302095716.64155-2-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:46:34 +01:00
Tetsuhiro Kohada
3eca76cc2d
staging: exfat: clean up d_entry rebuilding.
...
Clean up d_entry rebuilding in exfat_rename_file() and move_file().
-Replace memcpy of d_entry with structure copy.
-Change to use the value already stored in fid.
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp >
Acked-by: Valdis Kletnieks <valdis.kletnieks@vt.edu >
Link: https://lore.kernel.org/r/20200302095716.64155-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-04 07:46:34 +01:00