Ben Evans
7d2fa4cbf3
staging: lustre: uapi: return error code for ostid_set_id
...
Currently the function ostid_set_id() just logs an error
and just keeps going. This function is also used by user
land tools so having special lustre kernel debugging
code is not desired. So instead just return an error
code and have the calling kernel code print the error
instead.
Signed-off-by: Ben Evans <bevans@cray.com >
Signed-off-by: James Simmons <uja.ornl@yahoo.com >
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401
Reviewed-on: https://review.whamcloud.com/22712
Reviewed-on: https://review.whamcloud.com/24569
Reviewed-by: James Simmons <uja.ornl@yahoo.com >
Reviewed-by: Frank Zago <fzago@cray.com >
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com >
Signed-off-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:36:47 -07:00
James Simmons
3c42fb1234
staging: lustre: uapi: remove unused functions for lustre_fid.h
...
The inline function fid_is_namespace_visible and ost_fid_from_resid
are only used for server code so we can remove it.
Signed-off-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:36:47 -07:00
Ben Evans
22c147fdd9
staging: lustre: uapi: Move functions out of lustre_idl.h
...
Migrate functions set/get_mrc_cr_flags, ldlm_res_eq
ldlm_extent_overlap, ldlm_extent_contain,
ldlm_request_bufsize, and all the PTLRPC dump_*
functions out of lustre_idl.h which is a UAPI header
to the places in the kernel code they are actually used.
Delete unused lmv_mds_md_stripe_count and
agent_req_in_final_state.
Signed-off-by: Ben Evans <bevans@cray.com >
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401
Reviewed-on: http://review.whamcloud.com/21484
Reviewed-by: Frank Zago <fzago@cray.com >
Reviewed-by: James Simmons <uja.ornl@yahoo.com >
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com >
Reviewed-by: John L. Hammond <john.hammond@intel.com >
Signed-off-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:36:46 -07:00
Colin Ian King
f942efe73a
staging: r8822be: fix a couple of spelling mistakes
...
Trivial fixes to spelling mistake in pr_err error messages:
errorr -> error
mismactch -> mismatch
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:36:14 -07:00
Colin Ian King
53b70e5c2e
staging: typec: tcpm: make function tcpm_get_pwr_opmode
...
The function pointer tcpm_get_pwr_opmode is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'tcpm_get_pwr_opmode' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:36:14 -07:00
Srishti Sharma
ac985b6cd9
Staging: fsl-dpaa2: ethernet: dpni.c: Fixed alignment to match open parenthesis.
...
Fixed alignment so that it matched open parenthesis
Signed-off-by: Srishti Sharma <srishtishar@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:33:25 -07:00
Arvind Yadav
ccc5d98ae0
staging: greybus: audio: constify snd_soc_dai_ops structures
...
snd_soc_dai_ops are not supposed to change at runtime. All functions
working with snd_soc_dai_ops provided by <sound/soc-dai.h> work with
const snd_soc_dai_ops. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com >
Acked-by: Mark Greer <mgreer@animalcreek.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:33:19 -07:00
Eames Trinh
4a27e3e09d
Staging: greybus: Fix spelling error in comment
...
Fixed a spelling error.
Signed-off-by: Eames Trinh <eamestrinh@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:33:19 -07:00
Randy Dunlap
0be5dec503
staging: rtlwifi: fix multiple build errors
...
Fix many build errors when NETDEVICES is not enabled.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org >
Cc: Larry Finger <Larry.Finger@lwfinger.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 18:33:19 -07:00
David Kershner
aa5ebdeb5d
staging: unisys: use ATTRIBUTE_GROUPS instead of creating our own
...
Greg noticed that we were creating our own attribute groups, instead of
using the ATTRIBUTE_GROUPS macro, this patch fixes our mistake.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
Sameer Wadgaonkar
b74856b419
staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_destroy
...
The function visorchipset_device_destroy just called remove_visor_device,
we can just combine it with remove_visor_device.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
Sameer Wadgaonkar
51c0f81cca
staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_create
...
The function visorchipset_device_create just called create_visor_device,
we can just combine it with create_visor_device.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
Sameer Wadgaonkar
a7093ba162
staging: unisys: visorbus: Get rid of passthrough function visorchipset_bus_destroy
...
The function visorchipset_bus_destroy just called viosrbus_remove_instance,
we can just combine it with visorbus_remove_instance.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
17d3208c3f
staging: unisys: include: iochannel.h: Add proper copyright statement
...
Adds the proper Unisys copyright statement to the top of iochannel.h.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
f1aa6b81b2
staging: unisys: visorinput: ultrainputreport.h: Adjust comment formatting
...
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
761b02d8f1
staging: unisys: visorhba: Adjust top comment formatting
...
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
dba1a0a3c8
staging: unisys: include: visorbus.h: Remove filename in top comment
...
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
81d3817e85
staging: unisys: visorinput: visorinput.c: Remove filename in top comment
...
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
fa96c883da
staging: unisys: visorbus: visorchannel.c: Remove filename in top comment
...
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:55 -07:00
David Binder
66207a336c
staging: unisys: visorbus: visorbus_main.c: Remove filename in top comment
...
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:54 -07:00
David Binder
6df555c13c
staging: unisys: visorbus: visorchipset.c: Fix SonarQube sprintf findings
...
Fixes two sprintf invocations where we attempt to format an unsigned
integer as a signed integer.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:14:54 -07:00
David Kershner
df47f0ae98
staging: unisys: include: iochannel.h: Update comments for #defines
...
Cleaned up some #defines to make the beginning of the file read easier.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:13:41 -07:00
David Kershner
fdf5b9ac3e
staging: unisys: visorbus: Get rid of passthrough function visorchipset_bus_create
...
The function visorchipset_bus_create just called visorbus_create_instance,
we should just combine it with visorbus_create_instance.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
b253ff5bf8
staging: unisys: reference bus_no and dev_no directly
...
Don't store it in a local variable but reference it from the
visor_device.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
727bb6485e
staging: unisys: don't copy to local variable
...
Do the check with the values in the structure instead of copying them to
local variables.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
f51963f54d
staging: unisys: visorbus: Remove confusing comment in controlvmchannel.
...
Referencing a SegmentIndex doesn't make sense in the Linux drivers, get rid
of the comment.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
f79e1dfdbc
staging: unisys: Move SIOVM guid to visorbus
...
The SIOVM guid is only used by visorchipset. So define it there instead
of a global header file.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
2c1d982076
staging: unisys: Move VNIC GUID to visornic
...
Instead of including it in the global channel.h, move the VNIC GUID to the
visornic module.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
2699f21ab5
staging: unisys: include: remove unnecessary blank line from channel.h
...
Remove unnecessary blank line from channel.h #defines.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
8c3f22c28c
staging: unisys: visorinput: Get rid of unused includes
...
Cleanups caused us to not need to include a bunch of headers, got rid of
them.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
264f19b30b
staging: unisys: include: iochannel needs to include skbuff
...
The iochannel.h header file references ETH_HLEN which is defined in
skbuff. Removed it from visorhba since it was no longer needed.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
351c51e37c
staging: unisys: visorbus: Remove unnecessary includes for visorchipset.c
...
Visorchipset.c was including unnecessary include files, either included by
other headers or not needed at all.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
ab3807d92f
staging: unisys: visorbus: fix include dependency
...
Due to include order, the visorbus_private.h file was missing a required
include header visorbus.h. If visorchipset.c or visorbus_main.c ever were
to change the order of the includes for visobus.h and visorbus_private.h,
the code would fail to compile.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
d8d9556ff1
staging: unisys: include: Remove unneeded includes from visorbus.h
...
A bunch of code churn has caused the following include files to not be
needed by visorbus.h:
linux/poll.h
linux/kernel.h
linux/uuid.h
linux/seq_file.h
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:52 -07:00
David Kershner
97cd8aaa09
staging: unisys: include: Remove unnecessary forward declaration
...
The struct visor_device had a forward declaration that was not needed.
Remove it.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:51 -07:00
David Kershner
a595a7ff8b
staging: unisys: include: Fix up comment style in visorbus.h
...
Visorbus.h had comments that did not have /* on its own line, this patch
makes it uniform.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:51 -07:00
David Kershner
48401ac61f
staging: unisys: include: cleanup channel comment
...
A comment in channel.h was referencing windows guests, in reality the OS
of the guest is agnostic and the comment should reflect that.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:51 -07:00
David Kershner
0b9e41bdc3
staging: unisys: include: Remove unused throttling defines.
...
We no longer send messages directly to the s-Par event log, so we do not
need the throttling defines anymore.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:51 -07:00
David Kershner
a941c5b76a
staging: unisys: include: Remove unused vdiskmgmt commands
...
The vdisk task management commands are no longer used by s-Par, this
patch removes the definitions for them.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 15:12:51 -07:00
David Kershner
d4999465c9
staging: unisys: include: Remove unused #define MAXNUM
...
The MAXNUM #define was not being used, and it shouldn't be used.
Remove it.
Reviewed-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:04 -07:00
Sameer Wadgaonkar
722e73d55f
staging: unisys: visorbus: merging the visorbus_device_pause_response and visorbus_device_resume_response functions into one.
...
The functions viosrbus_device_pause_response() and
viosrbus_device_resume_response() are functionally similar.
Merging these functions into a single function called
visorbus_device_changestate_response().
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:04 -07:00
Sameer Wadgaonkar
76956aa7be
staging: unisys: visorbus: merging the visorbus_*_response functions into one.
...
The functions visorbus_create_response(), visorbus_destroy_response(),
viosrbus_device_create_response(), viosrbus_device_destroy_response()
are all functionally similar. Merging these four functions into a
single function called visorbus_response().
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:04 -07:00
Steven Matthews
55515a30d2
staging: unisys: include: fix improper use of dma_data_direction
...
Replace use of standard Linux dma_data_direction with a Unisys-
specific uis_dma_data_direction and provide a function to convert
from the latter to the former. This is necessary because Unisys
s-Par depends on the exact format of this field in multiple OSs
and languages, and so using the standard version creates an
unnecessary dependency between the kernel and s-Par.
Signed-off-by: Steven Matthews <steven.matthews@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
David Binder
12cbd49043
staging: unisys: visorbus: Remove unnecessary comments
...
Removes comments that do not provide any valuable information.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
David Binder
c8684a9d87
staging: unisys: visorbus: Merge vmcallinterface.h into visorchipset.c
...
The contents of vmcallinterface.h are better placed within
visorchipset.c from an organizational perspective. The values are only
used in that file.
Signed-off-by: David Binder <david.binder@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
Sameer Wadgaonkar
c02c6a0c97
staging: unisys: visornic: visornic_main.c: fix multiline dereference.
...
This patch fixes two checkpatch warnings in the visornic_main.c
file to avoid multiline dereference.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
Sameer Wadgaonkar
5ea5c64b51
staging: unisys: visornic: update the struct visornic_devdata comments
...
Cleaned up the in-line comments in the structure and added a single block
comment for the structure.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: David Binder <david.binder@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
Charles Daniels
e80ffd4b27
staging: unisys: visorbus: fix multi-line function definition
...
Fixed incorrectly styled function definitions in visorbus/visorchipset.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels <cdaniels@fastmail.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: David Binder <david.binder@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
Mark Foresta
eb30ed5881
staging: unisys: visorbus: visorbus_private.h remove filename
...
Remove the filename in the comment at the beginning of the file.
Signed-off-by: Mark Foresta <Mark.Foresta@Unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: David Binder <david.binder@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00
Mark Foresta
6f77a2eef1
staging: unisys: visorbus: Update comment style vbuschannel.h
...
Moved blocked comment on to own line at beginning of struct to follow
standard. Since this is an internal structure, the block comment isn't
actually a kernel-doc so we only start the block with one asterisk.
Signed-off-by: Mark Foresta <Mark.Foresta@Unisys.com >
Signed-off-by: David Kershner <david.kershner@unisys.com >
Reviewed-by: David Binder <david.binder@unisys.com >
Reviewed-by: Tim Sell <timothy.sell@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-08-22 14:56:03 -07:00