Commit Graph

997669 Commits

Author SHA1 Message Date
Marco Cesati
7a151e9c0a Staging: rtl8723bs: remove useless macros
Remove two 'no-op' macros, as well as two related unreferenced macros,
in the staging/rtl8723bs driver.

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210326174145.19427-2-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-28 14:34:47 +02:00
Marco Cesati
f632c61427 Staging: rtl8723bs: remove obsolete comments
Remove some orphan comments in the staging/rtl8723bs driver

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210326174145.19427-1-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-28 14:34:47 +02:00
Fabio Aiuto
2e2b93ac2e staging: rtl8723bs: fix broken indentation
fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines

Fixes: 65f183001f (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210326180632.1859-1-fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-28 14:33:54 +02:00
Edmundo Carmona Antoranz
babb5b8e2b staging: rtl8723bs: hal: remove unused variable in HalBtc8723b1Ant.c
Variable btRssiState in halbtc8723b1ant_ActionWifiConnectedBtAclBusy()
is set but never read. Removing it.

Removing this warning:

drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2093:5: warning: variable ‘btRssiState’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210327001736.180881-3-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-28 14:33:54 +02:00
Edmundo Carmona Antoranz
e3f480cf4b staging: rtl8723bs: sdio_ops: removing unused variable
Inside sd_int_dpc(), variable report is set but it's never read.
Getting rid of it.

Removing this warning:

drivers/staging/rtl8723bs/hal/sdio_ops.c:946:30: warning: variable ‘report’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210327001736.180881-4-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-28 14:33:54 +02:00
Julian Braha
a5bf1a101a drivers: staging: netlogic: fix unmet dependency for PHYLIB
When NETLOGIC_XLR_NET is enabled, and NETDEVICES is
disabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for PHYLIB
  Depends on [n]: NETDEVICES [=n]
  Selected by [y]:
  - NETLOGIC_XLR_NET [=y] && STAGING [=y] && CPU_XLR [=y]

This is because NETLOGIC_XLR_NET selects PHYLIB
without selecting or depending on NETDEVICES,
despite PHYLIB depending on NETDEVICES.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Link: https://lore.kernel.org/r/20210326054533.48751-1-julianbraha@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:06:15 +01:00
Fabio Aiuto
61d6809f9c staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_linux.c
fix the following checkpatch warning:

ERROR: do not use assignment in if condition
2607: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2607:
+	if (0 != (ret = rtw_change_ifname(padapter, new_ifname)))
--
ERROR: do not use assignment in if condition
4239: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4239:
+	if (!(ext = vmalloc(len)))
--
ERROR: do not use assignment in if condition
4253: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4253:
+	if (!(ext_dbg = vmalloc(len))) {

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/98b58790ae7c791d091b301bccf67a70c41ec599.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:05:07 +01:00
Fabio Aiuto
c8ad167ebe staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c
fix the following checkpatch warning:

ERROR: do not use assignment in if condition
1440: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1440:
+		if ((wps_ie = rtw_get_wps_ie(buf, len, NULL, &wps_ielen)))
--
ERROR: do not use assignment in if condition
2465: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2465:
+		if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL)
--
ERROR: do not use assignment in if condition
2937: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2937:
+	if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL) {
--
ERROR: do not use assignment in if condition
3335: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3335:
+	if (!(ndev = wdev_to_ndev(wdev)))

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/cc687c2ff614da3e110addd1c5cd610e3356cbd7.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:05:07 +01:00
Fabio Aiuto
d9af224564 staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c
fix the following checkpatch warning:

ERROR: do not use assignment in if condition
1118: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1118:
+		if ((addr = of_get_property(np, "local-mac-address", &len)) &&

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/8e784a7e1407924724c97398af8e5aeb23460612.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:05:07 +01:00
Marco Cesati
4cf346e506 Staging: rtl8723bs: remove named enums in HalBtc8723b2Ant.h
Remove the following unnecessary enum names in
hal/HalBtc8723b2Ant.h:

	enum bt_info_src_8723b_2ant
	enum bt_8723b_2ant_bt_status
	enum bt_8723b_2ant_coex_algo

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-34-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:03 +01:00
Marco Cesati
7f5771470d Staging: rtl8723bs: remove named enums in odm.h
Remove the following unnecessary enum names or definitions in
hal/odm.h:

	enum ODM_Ability_E		[definition]
	enum odm_ability_e		[name]
	enum odm_interface_e		[name]
	enum odm_ic_type_e		[name]
	enum odm_cut_version_e		[name]
	enum odm_fab_e			[name]
	enum odm_rf_path_e		[definition]
	enum odm_rf_type_e		[name]
	enum odm_mac_phy_mode_e		[definition]
	enum odm_bt_coexist_e		[definition]
	enum odm_operation_mode_e	[definition]
	enum odm_wireless_mode_e	[name]
	enum odm_band_type_e		[name]
	enum odm_sec_chnl_offset_e	[definition]
	enum odm_security_e		[definition]
	enum odm_bw_e			[name]
	enum odm_board_type_e		[definition]
	enum ODM_Package_TYPE_E		[definition]
	enum odm_cca_path_e		[definition]
	enum fat_state_e		[definition]
	enum ant_div_type_e		[name]
	enum rt_status			[definition]
	enum dm_1r_cca_e		[name]
	enum dm_rf_e			[name]
	enum dm_swas_e			[definition]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-33-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:03 +01:00
Marco Cesati
0f5f939ace Staging: rtl8723bs: remove named enums in HalPhyRf.h
Remove the following unnecessary enum definition in
hal/HalPhyRf.h:

	enum spur_cal_method

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-32-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:03 +01:00
Marco Cesati
9d8b1d20e8 Staging: rtl8723bs: remove named enums in odm_DIG.h
Remove the following unnecessary enum definitions in
hal/odm_DIG.h:

	enum dm_dig_op_e
	enum ODM_Pause_CCKPD_TYPE

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-31-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
773d5be790 Staging: rtl8723bs: remove named enums in odm_types.h
Remove the following unnecessary enum definition in
hal/odm_types.h:

	enum rt_spinlock_type

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-30-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
e6b8ccce5a Staging: rtl8723bs: remove named enums in HalBtc8723b1Ant.h
Remove the following unnecessary enum names in
hal/HalBtc8723b1Ant.h:

	enum bt_info_src_8723b_1ant
	enum bt_8723b_1ant_bt_status
	enum bt_8723b_1ant_wifi_status
	enum bt_8723b_1ant_coex_algo

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-29-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
cd9b6a6f95 Staging: rtl8723bs: remove named enums in HalBtcOutSrc.h
Remove the following unnecessary enum names or definitions in
hal/HalBtcOutSrc.h:

	enum btc_powersave_type			[name]
	enum btc_bt_reg_type			[name]
	enum btc_chip_type			[name]
	enum btc_msg_type			[name]
	enum btc_dbg_opcode			[definition]
	enum btc_rssi_state			[name]
	enum btc_wifi_role			[definition]
	enum btc_wifi_bw_mode			[name]
	enum btc_wifi_traffic_dir		[name]
	enum btc_wifi_pnp			[name]
	enum bt_wifi_coex_state			[definition]
	enum btc_get_type			[name]
	enum btc_set_type			[name]
	enum btc_dbg_disp_type			[name]
	enum btc_notify_type_ips		[name]
	enum btc_notify_type_lps		[name]
	enum btc_notify_type_scan		[name]
	enum btc_notify_type_associate		[name]
	enum btc_notify_type_media_status	[name]
	enum btc_notify_type_special_packet	[name]
	enum btc_notify_type_stack_operation	[definition]
	enum btc_antenna_pos			[name]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-28-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
50e9413e56 Staging: rtl8723bs: remove named enums in odm_interface.h
Remove the following unnecessary enum definition in
hal/odm_interface.h:

	enum odm_h2c_cmd

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-27-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
eba66f41fb Staging: rtl8723bs: remove named enums in rtw_efuse.h
Remove the following unnecessary enum name in
include/rtw_efuse.h:

	enum _efuse_def_type

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-26-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
efab7dda7e Staging: rtl8723bs: remove named enums in ieee80211.h
Remove the following unnecessary enum names or definitions in
include/ieee80211.h:

	enum rateid_idx				[name]
	enum ratr_table_mode			[definition]
	enum eap_type				[definition]
	enum mgn_rate				[name]
	enum ieee80211_state			[definition]
	enum rtw_ieee80211_category		[name]
	enum _public_action			[name]
	enum rtw_ieee80211_back_parties		[definition]
	enum rtw_ieee80211_vht_actioncode	[definition]
	enum secondary_ch_offset		[definition]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-25-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
5f1c94a050 Staging: rtl8723bs: remove named enums in hal_com_phycfg.h
Remove the following unnecessary enum names in
include/hal_com_phycfg.h:

	enum rf_tx_num
	enum _regulation_txpwr_lmt

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-24-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
977f51c28c Staging: rtl8723bs: remove named enums in HalPwrSeqCmd.h
Remove the following unnecessary enum name in
include/HalPwrSeqCmd.h:

	enum pwrseq_cmd_delay_unit

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-23-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
5e8aa5d018 Staging: rtl8723bs: remove named enums in rtw_rf.h
Remove the following unnecessary enum names or definitions in
include/rtw_rf.h:

	enum capability				[name]
	enum   _reg_preamble_mode		[name]
	enum _rtl8712_rf_mimo_config_		[definition]
	enum rf90_radio_path			[definition]
	enum vht_data_sc			[name]
	enum protection_mode			[definition]
	enum rt_rf_type_definition		[name]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-22-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
5429b11fa0 Staging: rtl8723bs: remove named enums in rtw_xmit.h
Remove the following unnecessary enum definition in
include/rtw_xmit.h:

	enum txdesc_sc

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-21-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
65724245ce Staging: rtl8723bs: remove named enums in rtw_mlme_ext.h
Remove the following unnecessary enum names or definitions in
include/rtw_mlme_ext.h:

	enum rt_channel_domain		[name]
	enum rt_channel_domain_2g	[name]
	enum rt_channel_domain_5g	[name]
	enum Associated_AP		[definition]
	enum ht_iot_peer_e		[name]
	enum scan_state			[name]
	enum rtw_c2h_event		[name]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-20-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
ecebe41e51 Staging: rtl8723bs: remove named enums in hal_phy.h
Remove the following unnecessary enum names or definitions in
include/hal_phy.h:

	enum rf_type			[name]
	enum antenna_path		[definition]
	enum rf_content			[definition]
	enum BaseBand_Config_Type	[definition]
	enum hw_block			[definition]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-19-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:02 +01:00
Marco Cesati
9c2c652f06 Staging: rtl8723bs: remove named enums in rtl8723b_hal.h
Remove the following unnecessary enum names in
include/rtl8723b_hal.h:

	enum c2h_evt
	enum package_type_e

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-18-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
9666bfa568 Staging: rtl8723bs: remove named enums in wifi.h
Remove the following unnecessary enum names or definitions in
include/wifi.h:

	enum wifi_frame_type		[name]
	enum wifi_frame_subtype		[name]
	enum wifi_reg_domain		[definition]
	enum p2p_proto_wk_id		[definition]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-17-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
38936ed5d1 Staging: rtl8723bs: remove named enums in rtw_wifi_regd.h
Remove the following unnecessary enum definition in
include/rtw_wifi_regd.h:

	enum country_code_type_t

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-16-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
c0c79e9f6d Staging: rtl8723bs: remove named enums in hal_com_h2c.h
Remove the following unnecessary enum definition in
include/hal_com_h2c.h:

	enum h2c_cmd

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-15-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
dd210c1dd3 Staging: rtl8723bs: remove named enums in rtl8723b_cmd.h
Remove the following unnecessary enum name in
include/rtl8723b_cmd.h:

	enum h2c_cmd_8723B

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-14-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
2148216174 Staging: rtl8723bs: remove named enums in rtw_pwrctrl.h
Remove the following unnecessary enum names in
include/rtw_pwrctrl.h:

	enum Power_Mgnt
	enum _PS_BBRegBackup_

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-13-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
67a1a97d64 Staging: rtl8723bs: remove named enums in hal_intf.h
Remove the following unnecessary enum names or definitions in
include/hal_intf.h:

	enum rtl871x_hci_type		[name]
	enum hw_variables		[name]
	enum rt_eeprom_type		[definition]
	enum wowlan_subcode		[definition]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-12-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
0cf217a447 Staging: rtl8723bs: remove named enums in osdep_service.h
Remove the following unnecessary enum definitions in
include/osdep_service.h:

	enum mstat_f
	enum mstat_status

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-11-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
348516fa39 Staging: rtl8723bs: remove named enums in rtw_mp.h
Remove the following unnecessary enum definitions in
include/rtw_mp.h:

	enum mp_mode
	enum mpt_rate_index
	enum power_mode
	enum ofdm_tx_mode
	enum encry_ctrl_state
	enum mpt_txpwr_def

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-10-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
7e9f6dcc03 Staging: rtl8723bs: remove named enums in wlan_bssdef.h
Remove the following unnecessary enum names or definitions in
include/wlan_bssdef.h:

	enum ndis_802_11_wep_status		[name]
	enum ndis_802_11_reload_defaults	[definition]
	enum vrtl_carrier_sense			[name]
	enum vcs_type				[name]
	enum uapsd_max_sp			[name]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-9-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
56b89735f3 Staging: rtl8723bs: remove named enums in rtw_ht.h
Remove the following unnecessary enum names in
include/rtw_ht.h:

	enum aggre_size_e
	enum rt_ht_inf0_capbility
	enum rt_ht_inf1_capbility

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-8-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
145d91b778 Staging: rtl8723bs: remove named enums in drv_types.h
Remove the following unnecessary enum names or definitions in
include/drv_types.h:

	enum _nic_version	[definition]
	enum _iface_type	[name]
	enum adapter_type	[definition]
	enum driver_state	[name]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-7-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
555665d98e Staging: rtl8723bs: remove named enums in rtw_recv.h
Remove the following unnecessary enum name in
include/rtw_recv.h:

	enum rx_packet_type

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-6-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:01 +01:00
Marco Cesati
fc3e6754b1 Staging: rtl8723bs: remove named enums in hal_com.h
Remove the following unnecessary enum definition in
include/hal_com.h:

	enum firmware_source

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-5-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:00 +01:00
Marco Cesati
463cc86e1c Staging: rtl8723bs: remove named enums in rtw_eeprom.h
Remove the following unnecessary enum name
include/rtw_eeprom.h:

	enum rt_customer_id

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-4-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:00 +01:00
Marco Cesati
d5e7c6b387 Staging: rtl8723bs: remove named enums in rtw_cmd.h
Remove the following unnecessary enum names in
include/rtw_cmd.h:

	enum rtw_drvextra_cmd_id
	enum lps_ctrl_type
	enum rfintfs
	enum rtw_h2c_cmd

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-3-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:00 +01:00
Marco Cesati
cc8c7cca30 Staging: rtl8723bs: remove named enums in rtw_mlme.h
Remove the following unnecessary enum names or definitions in
include/rtw_mlme.h:

	enum dot11AuthAlgrthmNum	[name]
	enum  _band			[name]
	enum DriverInterface		[definition]
	enum scan_result_type		[definition]

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-2-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:03:00 +01:00
Bruno Raoult
5005ac4d2f r8192U_wx.c: style: avoid multiple blank lines
fix checkpatch.pl check:

CHECK: Please don't use multiple blank lines
in drivers/staging/rtl8192u/r8192U_wx.c

Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/2c1f2c668d299ce1895ce97dc7fb9a67d3723e63.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:01:16 +01:00
Bruno Raoult
8d8b93ee35 r8192U_wx.c: style: Unnecessary parentheses
fix checkpatch.pl check:

CHECK: Unnecessary parentheses around expr
in drivers/staging/rtl8192u/r8192U_wx.c

Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/f42993e183e1127dcc9fce3f0ed42dd6d795c647.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:01:15 +01:00
Bruno Raoult
b95dd839d7 r8192U_wx.c: style: braces all arms of statement
fix checkpatch.pl check:

CHECK: braces {} should be used on all arms of this statement
in drivers/staging/rtl8192u/r8192U_wx.c

Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/adbbb5243dca7998a31a786eef277bd85068c63a.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:01:15 +01:00
Bruno Raoult
0c98c5e93b r8192U_wx.c: style: spaces preferred around operators
fix checkpatch.pl check:

CHECK: spaces required around that <op>
in drivers/staging/rtl8192u/r8192U_wx.c

Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/e7298c14538ad7a58720585d019a70f637e0cdb1.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:01:15 +01:00
Bruno Raoult
619ee818fa r8192U_wx.c: style: alignment with open parenthesis
fix checkpatch.pl check:

CHECK: Alignment should match open parenthesis
in drivers/staging/rtl8192u/r8192U_wx.c

Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/34f4134241f49d1694cbfb9c2185e3ef54284680.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:01:15 +01:00
Swen Kalski
d70fb89711 Staging: comedi: remove unnecessary else statement
Removal of an unnecessary else in statging/comedi/comedi_buf.c
Add an early Return and removed the unleashed the else condition
for better readability int staging/comedi drivers.

Signed-off-by: Swen Kalski <kalski.swen@gmail.com>
Link: https://lore.kernel.org/r/20210325133520.GA594125@m17r3en
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 15:00:16 +01:00
Wan Jiabing
6f08cc6c2f drivers: staging: rtl8712: _adapter is declared twice
struct _adapter has been declared at 23rd line.
Remove the duplicate.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20210325080050.861273-1-wanjiabing@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 14:59:33 +01:00
Colin Ian King
0933e51a0b staging: rtl8188eu: Fix null pointer dereference on free_netdev call
An unregister_netdev call checks if pnetdev is null, hence a later
call to free_netdev can potentially be passing a null pointer, causing
a null pointer dereference. Avoid this by adding a null pointer check
on pnetdev before calling free_netdev.

Fixes: 1665c8fdff ("staging: rtl8188eu: use netdev routines for private data")
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210324152135.254152-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-26 14:58:57 +01:00