Danila Chernetsov
|
75cb113cd4
|
scsi: megaraid: Fix mega_cmd_done() CMDID_INT_CMDS
When cmdid == CMDID_INT_CMDS, the 'cmds' pointer is NULL but is
dereferenced below.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 0f2bb84d2a ("[SCSI] megaraid: simplify internal command handling")
Signed-off-by: Danila Chernetsov <listdansp@mail.ru>
Link: https://lore.kernel.org/r/20230317175109.18585-1-listdansp@mail.ru
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 20:27:17 -04:00 |
|
Martin K. Petersen
|
62d15dba0a
|
Merge patch series "Constify most SCSI host templates"
Bart Van Assche <bvanassche@acm.org> says:
It helps humans and the compiler if it is made explicit that SCSI host
templates are not modified. Hence this patch series that constifies most
SCSI host templates. Please consider this patch series for the next merge
window.
Link: https://lore.kernel.org/r/20230322195515.1267197-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 20:13:03 -04:00 |
|
Bart Van Assche
|
04d1fa4346
|
scsi: usb: uas: Declare two host templates and host template pointers const
Improve source code documentation by constifying host templates that are
not modified.
Acked-by: Alan Stern <stern@rowland.harvard.edu> (for usb-storage)
Acked-by: Oliver Neukum <oneukum@suse.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oliver Neukum <oneukum@suse.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-81-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:20:00 -04:00 |
|
Bart Van Assche
|
f2e2fe3dec
|
scsi: ufs: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-80-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:20:00 -04:00 |
|
Bart Van Assche
|
8e2ab8cda5
|
scsi: target: tcm-loop: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-79-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:20:00 -04:00 |
|
Bart Van Assche
|
f8adf8e99a
|
scsi: rts5208: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-78-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:20:00 -04:00 |
|
Bart Van Assche
|
65e5447a10
|
scsi: xen-scsifront: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-77-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:20:00 -04:00 |
|
Bart Van Assche
|
a5b78e81c7
|
scsi: wd719x: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-76-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
273ab25195
|
scsi: virtio-scsi: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-75-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
d2c16f8f1e
|
scsi: sym53c8xx: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-74-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
08d6075192
|
scsi: stex: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-73-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
8fb5b37e07
|
scsi: snic: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-72-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
077126d6b9
|
scsi: smartpqi: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-71-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
4517353a04
|
scsi: sgiwd93: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-70-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
7c7a141917
|
scsi: qlogicpti: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-69-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
421c20b766
|
scsi: qla2xxx: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-68-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
796e8f8082
|
scsi: qla1280: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-67-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:59 -04:00 |
|
Bart Van Assche
|
4fe61364e7
|
scsi: ps3rom: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Tested-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-66-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
d23901a8d7
|
scsi: ppa: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-65-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
4e9e0a51aa
|
scsi: pmcraid: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-64-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
8fe69e4abd
|
scsi: pcmcia-pm8001: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-63-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
54aefe23a6
|
scsi: pcmcia-sym53c500: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-62-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
36242912e2
|
scsi: nsp32: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-61-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
914fa37a8a
|
scsi: myrs: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-60-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
8e64d59d1f
|
scsi: myrb: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-59-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
8a098ba4d9
|
scsi: mvumi: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-58-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:58 -04:00 |
|
Bart Van Assche
|
f01feece6b
|
scsi: mvsas: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Reviewed-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-57-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
c9ac4e73b3
|
scsi: mvme147: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-56-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
1785ced8bd
|
scsi: mpt3sas: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-55-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
b85f82f3c9
|
scsi: mpi3mr: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-54-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
0fabb7fbad
|
scsi: mesh: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-53-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
264e222b00
|
scsi: megaraid: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-52-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
5e328664ed
|
scsi: mac53c94: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-51-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
80602aca4f
|
scsi: iscsi: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-50-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
eb60d17a0e
|
scsi: isci: Declare SCSI host template const
Make it explicit that the ISCI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-49-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
4ea4394e71
|
scsi: ipr: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-48-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:57 -04:00 |
|
Bart Van Assche
|
4ba116af0f
|
scsi: initio: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-47-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:56 -04:00 |
|
Bart Van Assche
|
09dce26c4a
|
scsi: imm: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-46-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:56 -04:00 |
|
Bart Van Assche
|
7bced3fc28
|
scsi: ibmvfc: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-45-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:56 -04:00 |
|
Bart Van Assche
|
9194970bec
|
scsi: hptiop: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-44-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:56 -04:00 |
|
Bart Van Assche
|
207761bf1a
|
scsi: hpsa: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-43-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:56 -04:00 |
|
Bart Van Assche
|
e8c0ced993
|
scsi: hisi_sas: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Acked-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-42-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:56 -04:00 |
|
Bart Van Assche
|
ccc54750f9
|
scsi: gvp11: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-41-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
bd5e469a7f
|
scsi: NCR5380: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-40-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
8e6a87aa91
|
scsi: fdomain: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-39-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
be8532d153
|
scsi: qedf: Declare host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-38-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
bf3614bd7e
|
scsi: fnic: Declare host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-37-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
d15515f918
|
scsi: fcoe: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-36-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
3b465a1491
|
scsi: esp_scsi: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-35-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|
Bart Van Assche
|
1f4e77dbcb
|
scsi: esas2r: Declare SCSI host template const
Make it explicit that the SCSI host template is not modified.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230322195515.1267197-34-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
2023-03-24 19:19:22 -04:00 |
|