Jes Sorensen
39dbc446a7
staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
7c0e063675
staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
ec36ce29ca
staging: rtl8723au: Make rtw_is_same_ibss23a() return bool
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
7b2e06a159
staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
ded7a20f82
staging: rtl8723au: OnAuth23a(): Use ether_addr_copy()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
1ae17bf169
staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
46805acb89
staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a()
...
Use _rtw_free_network23() so elements are freed in one place.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
8d7fb1b874
staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:20 -07:00
Jes Sorensen
1bebe75626
staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:19 -07:00
Jes Sorensen
246879640e
staging: rtl8723au: Do not embed struct wlan_bssid_ex in struct survey_event
...
Instead allocate it separately and reference it from survey_event.
This will allow for us to pass it on later without having to copy it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:19 -07:00
Jes Sorensen
7195dc0e1a
staging: rtl8723au: rtw_survey_event_cb23a(): Use the correct types for the received arguments
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:00:19 -07:00
Jes Sorensen
8ab7bdba0d
staging: rtl8723au: Declare rtw_update_scanned_network() static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:54 -07:00
Jes Sorensen
bbf5fdbd56
staging: rtl8723au: rtw_check_bcn_info23a(): Don't search for WPA/WPA2 info twice
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:54 -07:00
Jes Sorensen
17b19396a6
staging: rtl8723au: rtw_check_bcn_info23a(): Don't make a local copy of beacon just to parse it
...
In addition be consistent with return values and parsing them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:54 -07:00
Jes Sorensen
0c45e6170d
staging: rtl8723au: rtw_check_bcn_info23a(): Use ether_addr_equal() to check BSSID
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
51dacaa7ba
staging: rtl8723au: Remove some unused 80211 header parsing macros
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
e0ea5c8e66
staging: rtl8723au: Remove unused #defines WEP_KEY_LEN and MGMT_QUEUE_NUM
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
bf51cb6780
staging: rtl8723au: Remove duplicate defines of IEEE80211_HT_PARAM_CHA_SEC_*
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
2a907fe46b
staging: rtl8723au: Remove obsolete rtw_set_fixed_ie23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
a491548d66
staging: rtl8723au: issue_action_BA23a(): Use struct ieee80211_mgmt to build action frames
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
cc531f6154
staging: rtl8723au: ioctl_cfg80211.c: Use struct ieee80211_mgmt to build mgmt frame
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
2e74d336ed
staging: rtl8723au: Let cfg80211 handle public action management frames
...
The driver shouldn't be dealing with public action management frames.
Let these go directly to the cfg80211 layer which can defer them to
userland if needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
372713a942
staging: rtl8723au: Do not xmit BSS Coexistence management action frames
...
The driver should not be issuing BSS Coexistence management action
frames when scanning. This isn't required by the spec, and if needed,
these should come from wpa_s instead.
Recommended by Johannes Berg.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
85d5120d52
staging: rtl8723au: issue_action_BSSCoexistPacket(): Use struct ieee80211_mgmt
...
This gets rid of the rtw_set_fixed_ie23a() usage here. Note that this
abuses ieee80211_mgmt.u.action.u.chan_switch for now, since the
correct defines are currently missing, and this one matches.
Need to fix up the definitions in ieee80211.h and afterwards fix it up
here.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
7ed61b5b30
staging: rtl8723au: issue_action_spct_ch_switch23a(): Use struct ieee80211_mgmt
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
f89547b651
staging: rtl8723au: _issue_deauth(): Use struct ieee80211_mgmt to build frame
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:53 -07:00
Jes Sorensen
c144c3bbd5
staging: rtl8723au: issue_assocrsp(): Use struct ieee80211_mgmt instead of rtw_set_fixed_ie23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:48 -07:00
Jes Sorensen
88e06f0200
staging: rtl8723au: issue_auth(): Convert to using struct ieee80211_mgmt
...
This reduces the dependency of rtw_set_fixed_ie23a() which is
scheduled to go away.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:48 -07:00
Jes Sorensen
47e5d2f26d
staging: rtl8723au: Make struct htpriv.ampdu_enable a bool
...
Be consistent in parsing it's value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
6a5f657db5
staging: rtl8723au: Be consistent in how htpriv.ht_option is checked
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
6f765c20ca
staging: rtl8723au: Make struct ht_priv.ht_option a bool
...
Match the return type of rtw_restructure_ht_ie23a() accordingly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
c9324c8853
staging: rtl8723au: Remove WMM_ defines
...
Only one is used, and only describes the size of an array defined in a
local function. Use sizeof() in the local function to deobfuscate it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
e1d143b495
staging: rtl8723au: OnAssocRsp23a(): Use cfg80211_* to parse IEs
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
3cdf27730a
staging: rtl8723au: Make WMM_param_handler23a() and HT_caps_handler23a() take a const u8 *
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
0cac3f9ee4
staging: rtl8723au: Declare rtw_get_wpa{2, }_cipher_suite() static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
0b548a5c4d
staging: rtl8723au: Remove obsolete rtw_get_sec_ie23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
77953edfac
staging: rtl8723au: rtw_wlan_util.c: Use cfg80211_* to determine crypto
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:51:47 -07:00
Jes Sorensen
54ddd2266a
staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 13:38:19 -07:00
Jes Sorensen
b277541584
staging: rtl8723au: rtw_update_ht_cap23a(): Use correct mask when determining 40MHz channel location
...
commit 4dc5f8bab2
Author: Jes Sorensen <Jes.Sorensen@redhat.com >
Date: Tue May 27 13:43:12 2014 +0200
staging: rtl8723au: Eliminate struct HT_info_element
Yet another duplicate version of struct ieee80211_ht_operation
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
introduced a bad error, applying the wrong value as the mask when
determining the location of the 40MHz channel, effectively making it
always determining it as not present. This caused hangs and delays
when running in 40MHz channel mode.
This should get it right.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:37:34 -07:00
Jes Sorensen
c2b8047aff
staging: rtl8723au: collect_bss_info23a(): ieee80211_mgmt capab_info is little endian
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:41 -07:00
Jes Sorensen
5b124b1aa2
staging: rtl8723au: collect_bss_info23a(): Collect beacon_interval correct
...
Only retrieve beacon_interval from frames where it is present. This
avoids setting BeaconPeriod to garbage for other frame types.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:41 -07:00
Jes Sorensen
7882ef454c
staging: rtl8723au: Rewrite update_beacon23a_info() tto use cfg80211_find_ie()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
e3916153ea
staging: rtl8723au: Remmove buddy-adapter linking
...
This sort of stuff should be handled by the bonding driver
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
a665bcc244
staging: rtl8723au: rtw_check_bcn_info23a(): Use capability bit define
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
ed08b4de7c
staging: rtl8723au: Don't carry ht_cap_info and ht_param in struct wlan_bcn_info
...
These were just stored to check whether the beacon info had changed
and print a debug message in this case. If we ever need this again, we
can determine this change differently.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
4dc5f8bab2
staging: rtl8723au: Eliminate struct HT_info_element
...
Yet another duplicate version of struct ieee80211_ht_operation
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
6594c965ca
staging: rtl8723au: Use correct struct for WLAN_EID_HT_CAPABILITY
...
WLAN_EID_HT_CAPABILITY carries a struct ieee80211_ht_operation - use
the right struct instead of a self invented one.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
65be27da49
staging: rtl8723au: Use struct ieee80211_ht_cap and associated #defines
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
198e95d548
staging: rtl8723au: Use struct ieee80211_mcs_info to describe MCS information
...
The original RTL code defined the MCS information as a 16 byte array
and blindly applied it's masking over the full array, ignoring the
fact that only the first 10 bytes describe the rx_mask and the rest
are different fields.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00
Jes Sorensen
8b3d9cde7d
staging: rtl8723au: rtw_mlme.c: Remove some tab and parenthesis abuse
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 12:35:40 -07:00