Gary Rookard
1d7ce9861b
staging: rtl8192e: renamed variable AMPDU_Factor
...
Coding style issue, checkpatch Avoid CamelCase,
rename it. AMPDU_Factor -> ampdu_factor
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231206230404.1721-4-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-09 15:06:47 +01:00
Gary Rookard
e97f14e92d
staging: rtl8192e: renamed variable bAMPDUEnable
...
Coding style issue, checkpatch Avoid CamelCase,
rename it. bAMPDUEnable -> ampdu_enable
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231206230404.1721-3-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-09 15:06:47 +01:00
Gary Rookard
cbf028b29d
staging: rtl8192e: renamed variable bAMSDU_Support
...
Coding style issue, checkpatch Avoid CamelCase,
rename it. bAMSDU_Suppport -> amsdu_support
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231206230404.1721-2-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-09 15:06:47 +01:00
Umang Jain
6cb3158903
staging: vc04_services: vchiq_dev: Use %p to log pointer address
...
Solves the following Smatch warnings:
vchiq_release() warn: argument 7 to %lx specifier is cast from pointer
%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231207083837.153843-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-09 15:06:35 +01:00
Umang Jain
93596ac342
staging: vc04_services: vchiq_arm: Use %p to log pointer address
...
Solves the following Smatch warnings:
service_callback() warn: argument 7 to %lx specifier is cast from pointer
service_callback() warn: argument 11 to %lx specifier is cast from pointer
service_callback() warn: argument 12 to %lx specifier is cast from pointer
service_callback() warn: argument 13 to %lx specifier is cast from pointer
%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231207083837.153843-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-09 15:06:35 +01:00
Umang Jain
55e23aa95b
staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg
...
Drop vchiq_log_debug() macro which wraps dev_dbg(). Introduce the usage
of dev_dbg() directly.
Meanwhile at it, drop the usage of __func__ from the logs.
Dynamic debug supports this via the 'f' decorator flag.
Remove the entry from TODO regarding custom logging. VC04 is now
aligned according to the standard kernel logging mechanisms.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231205084157.73819-5-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:39:59 +09:00
Umang Jain
078666d7ee
staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg
...
Drop vchiq_log_trace() macro which wraps dev_dbg(). Introduce the usage
of dev_dbg() directly.
Meanwhile at it, drop the usage of __func__ from the logs.
Dynamic debug supports this via the 'f' decorator flag.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231205084157.73819-4-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:39:48 +09:00
Umang Jain
085bb4131e
staging: vc04_services: Drop vchiq_log_warning() in favour of dev_warn
...
Drop vchiq_log_warning() macro which wraps dev_dbg(). Introduce the usage
of dev_warn() directly.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231205084157.73819-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:39:38 +09:00
Umang Jain
e70f17ed99
staging: vc04_services: Drop vchiq_log_error() in favour of dev_err
...
Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the usage
of dev_err() directly.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231205084157.73819-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:39:19 +09:00
Gary Rookard
d0a665b488
staging: rtl8192e: renamed variable nAMSDU_MaxSize
...
Coding style issue, checkpatch Avoid CamelCase,
rename it nAMSDU_MaxSize -> amsdu_max_size
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231205231623.23070-6-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:38:17 +09:00
Gary Rookard
41c9332231
staging: rtl8192e: renamed variable bRegSuppCCK
...
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegSuppCCK -> reg_supp_cck
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231205231623.23070-5-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:38:17 +09:00
Gary Rookard
c4dc2c60ce
staging: rtl8192e: renamed variable bRegBW40MHz
...
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegBW40MHz -> reg_bw_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231205231623.23070-4-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:38:17 +09:00
Gary Rookard
0e3a515206
staging: rtl8192e: renamed variable bRegShortGI40MHz
...
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegShortGI40MHz -> reg_short_gi_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231205231623.23070-3-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:38:17 +09:00
Gary Rookard
f538d35a78
staging: rtl8192e: renamed variable bRegShortGI20MHz
...
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegShortGI20MHz -> reg_short_gi_20mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231205231623.23070-2-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-07 11:38:17 +09:00
Umang Jain
149261d378
staging: vc04_services: Do not pass NULL to vchiq_log_error()
...
vchiq_add_connected_callback() logs using vchiq_log_error() macro,
but passes NULL instead of a struct device pointer. Fix it.
vchiq_add_connected_callback() is not used anywhere in the vc04_services
as of now. It will be used when we add new drivers(VC shared memory and
bcm2835-isp), hence it kept as it is for now.
Fixes: 1d8915cf88 ("staging: vc04: Convert vchiq_log_error() to use dynamic debug")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231128201926.489269-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-04 08:08:56 +01:00
Umang Jain
f9c4289883
staging: vc04_services: vchiq_core: Log through struct vchiq_instance
...
The handle_to_service() helper can return NULL, so `service` pointer
can indeed be set to NULL. So, do not log through service pointer
(which can cause NULL-deference), instead, use the vchiq_instance
function argument to get access to the struct device.
Fixes: f67af5940d ("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug")
Reviewed-by: Ricardo B. Marliere <ricardo@marliere.net >
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com >
Link: https://lore.kernel.org/r/20231128201845.489237-1-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-04 08:06:59 +01:00
Gary Rookard
ad96610acc
staging: rtl8192e: renamed variable nDataRate
...
Coding style issue, checkpatch Avoid CamelCase,
rename it nDataRate -> data-rate.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231128181727.19504-4-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-04 08:06:49 +01:00
Gary Rookard
213702c8b6
staging: rtl8192e: renamed variable bCurBW40MHz
...
Coding style issue, checkpatch Avoid CamelCase,
rename it bCurBW40MHz -> cur_bw_40mhz.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231128181727.19504-3-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-04 08:06:48 +01:00
Gary Rookard
d9443ac5e3
staging: rtl8192e: renamed variable nMcsRate
...
Coding style issue, checkpatch Avoid CamelCase,
rename it nMcsRate -> mcs_rate.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Link: https://lore.kernel.org/r/20231128181727.19504-2-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-12-04 08:06:46 +01:00
Tree Davies
d488759416
Staging: rtl8192e: Rename variable TsCommonInfo
...
Rename variable TsCommonInfo to ts_common_info to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-16-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
db099efcb2
Staging: rtl8192e: Rename variable pAdmittedBA
...
Rename variable pAdmittedBA to admitted_ba to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-15-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
cc6c66a6d4
Staging: rtl8192e: Rename variable pBaTimeoutVal
...
Rename variable pBaTimeoutVal to ba_timeout_value to fix checkpatch
warning Avoid CamelCase, and make the name consistent with variables
of same name/type.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-14-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
60b280a347
Staging: rtl8192e: Rename variable pBaParamSet
...
Rename variable pBaParamSet to ba_param_set to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-13-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
30b4c01ccc
Staging: rtl8192e: Rename variable DelbaParamSet
...
Rename variable DelbaParamSet to del_ba_param_set to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-12-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
536b207c45
Staging: rtl8192e: Rename variable TsAddBaTimer
...
Rename variable TsAddBaTimer to ts_add_ba_timer to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-11-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
27236dcfed
Staging: rtl8192e: Rename variable TxCurSeq
...
Rename variable TxCurSeq to tx_cur_seq to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-10-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
5732a2aa5f
Staging: rtl8192e: Rename variable pTsCommonInfo
...
Rename variable pTsCommonInfo to ts_common_info to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-9-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
c831d3f629
Staging: rtl8192e: Rename variable pDialogToken
...
Rename variable pDialogToken to dialog_token to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-8-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
11fe57bef5
Staging: rtl8192e: Rename variable TxPendingBARecord
...
Rename variable TxPendingBARecord to tx_pending_ba_record to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-7-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
56c5fa92de
Staging: rtl8192e: Rename variable TxAdmittedBARecord
...
Rename variable TxAdmittedBARecord to tx_admitted_ba_record to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-6-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:20 +00:00
Tree Davies
b35fe92f84
Staging: rtl8192e: Rename variable TSpec
...
Rename variable TSpec to tspec to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-5-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:19 +00:00
Tree Davies
1628dd0f12
Staging: rtl8192e: Rename variable Delba
...
Rename variable Delba to del_ba to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:19 +00:00
Tree Davies
896578ae2c
Staging: rtl8192e: Rename variable BAReq
...
Rename variable BAReq to ba_req to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:19 +00:00
Tree Davies
c2535e954f
Staging: rtl8192e: Rename variable pTxTs
...
Rename variable pTxTs to ts to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net >
Link: https://lore.kernel.org/r/20231127054305.148276-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-27 13:59:19 +00:00
Philipp Hortmann
956ec67187
staging: rtl8192e: Remove function rtl92e_update_rx_pkt_timestamp()
...
mac_time and last_rx_desc_tsf are only used in
rtl92e_update_rx_pkt_timestamp(). Depending on a condition one is equal
to the other or vice versa. But since those are not used anywhere else
the function rtl92e_update_rx_pkt_timestamp() is just dead code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/89a21fa17b32d66e07514bfad5b604d5d4835e25.1700860759.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
6ae22b8c5f
staging: rtl8192e: Remove unused function HTConstructInfoElement()
...
Remove unused function HTConstructInfoElement().
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/ed49162367b03a848895638adcdfe3594d4219b3.1700860759.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
7e0ea2ea43
staging: rtl8192e: Remove unused function rtllib_probe_resp()
...
Remove unused function rtllib_probe_resp().
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/be709ffea087df6f960075a51c0eab89f86ef8b2.1700860759.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
55003c4d6a
staging: rtl8192e: Remove unused function rtllib_get_beacon_()
...
Remove unused function rtllib_get_beacon_().
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/ed825d5fb1946530c310afca1d3f27e46da35f06.1700860759.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
270f40cf35
staging: rtl8192e: Remove unused function rtllib_send_beacon()
...
Remove unused function rtllib_send_beacon().
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/fca983a276ae67dc9cd124e236fe9d210fd997d3.1700860759.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
d7f0b9c251
staging: rtl8192e: Remove unused timer beacon_timer
...
Driver does not support AP Mode therefore no beacons need to be send.
Remove unused timer beacon_timer.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/b16b6b4525ede8e2a218cb39d23f9ef2a3a745a9.1700860759.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
786b6f5764
staging: rtl8192e: Remove unused function rtllib_get_beacon()
...
Remove unused function rtllib_get_beacon().
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/d76eeb7e273f4fcfec4ae8879e56d237363ebde2.1700860758.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Philipp Hortmann
eca8285c01
staging: rtl8192e: Remove unused interrupt for IMR_BcnInt
...
Driver does not support AP Mode therefore no beacons need to be send.
Remove unused interrupt for IMR_BcnInt.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/64a1f672dbe2ed2c6a660fa1044bd058fe3ba91a.1700860758.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:49 +00:00
Gary Rookard
32992c40e2
staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M
...
Renamed from Pascal/CamelCase to Snake case the variable
HTIOTActIsMgntUseCCK6M.
HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20231123144337.13112-6-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:08 +00:00
Gary Rookard
d6171fe96f
staging: rtl8192e: renamed variable HTIOTPeerDetermine
...
Renamed from Pascal/CamelCase to Snake case the variable
HTIOTPeerDetermine.
HTIOTPeerDetermine -> ht_iot_peer_determine
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20231123144337.13112-5-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:08 +00:00
Gary Rookard
ea6df150dd
staging: rtl8192e: renamed variable IsHTHalfNmodeAPs
...
Renamed from Pascal/CamelCase to Snake case the variable
IsHTHalfNmodeAPs.
ISHTHalfNmodeAPs -> is_ht_half_nmode_aps
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20231123144337.13112-4-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:08 +00:00
Gary Rookard
55401b86e0
staging: rtl8192e: renamed variable TXCountToDataRate
...
Renamed from Pascal/CamelCase to Snake case the variable
TXCountToDataRate.
TXCountToDataRate -> tx_count_to_data_rate
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20231123144337.13112-3-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:08 +00:00
Gary Rookard
f0a8eb6083
staging: rtl8192e: renamed variable HTMcsToDataRate
...
Renamed variable from Pascal/CamelCase to Snake case the variable
HTMcsToDataRate.
HTMcsToDataRate -> ht_mcs_to_data_rate
Linux Kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/20231123144337.13112-2-garyrookard@fastmail.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-26 10:27:08 +00:00
Stefan Wahren
b43d958fbc
staging: vchiq_arm: move state dump to debugfs
...
Besides the IOCTL interface the VCHIQ character device also provides
a state dump of the whole VCHIQ driver via read. Moving the state dump
function to debugfs has a lot advantages:
- following changes on state dump doesn't break userspace ABI
- debug doesn't depend on VCHIQ_CDEV
- dump code simplifies a lot and reduce the chance of buffer overflows
Signed-off-by: Stefan Wahren <wahrenst@gmx.net >
Tested-by: "Ricardo B. Marliere" <ricardo@marliere.net >
Link: https://lore.kernel.org/r/20231029124837.119832-4-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-23 13:12:15 +00:00
Stefan Wahren
20b68a673a
staging: vchiq_core: Shorten bulk TX/RX pending dump
...
The calculation for the bulk TX/RX pending is complex and
reaches 99 chars per line. So move the size determination
below the pending calculation and get the rid of the
ternary operator.
Signed-off-by: Stefan Wahren <wahrenst@gmx.net >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Link: https://lore.kernel.org/r/20231029124837.119832-3-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-23 13:12:15 +00:00
Stefan Wahren
9996f0044f
staging: vchiq_core: Make vchiq_dump_service_state static
...
The function vchiq_dump_service_state() is only used by vchiq_dump_state()
within vchiq_core.c. So move the definition of vchiq_dump_state() below
vchiq_dump_service_state() in order to make it static.
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Stefan Wahren <wahrenst@gmx.net >
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Link: https://lore.kernel.org/r/20231029124837.119832-2-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-11-23 13:12:15 +00:00