H Hartley Sweeten
11b7f7dc10
staging: comedi: pcl816: remove commented out outb() macro
...
This macro is commented out, thankfully... Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:23 -08:00
H Hartley Sweeten
d65e5b9d91
staging: comedi: pcl818: convert printk() messages to dev_{level}
...
Convert the remaining printk messsages in this driver to dev_{level}.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
e30b22a9cc
staging: comedi: pcl818: tidy up the irq support in pcl818_attach()
...
Tidy up the code that does the request_irq().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
eeb6f2d3b7
staging: comedi: pcl818: remove board attach noise
...
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
de4ea8e3c1
staging: comedi: pcl818: remove printk function trace messages
...
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
aad6fd1fca
staging: comedi: pcl818: remove commented out printk debug
...
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
bab0e19c4d
staging: comedi: pcm3724: remove commented out printk debug
...
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
3c64306183
staging: comedi: plx9080.h: remove unnecessary printk noise
...
The timeouts will return -ETIMEDOUT. The printks are just added noise.
Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
d1483ea58b
staging: comedi: rtd520: remove commented out printk debug
...
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
ba74f010ac
staging: comedi: mpc624: convert printk messages in mpc624_ai_rinsn()
...
There's no reason for these messages to be KERN_INFO. Convert them to
dev_dbg().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
4a4ed3f96b
staging: comedi: mpc624: remove unnecessary printk noise
...
The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.
It's also not necessary to set data[n[ = 0 when the read timesout.
Remove that also.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
c1ce7f1054
staging: comedi: mpc624: remove unnecessary test
...
It's not necessaary to vaidate insn->n passed to the (*insn_read)
function. The for() loop following it will just be a NOP.
Remove the test as well as the printk noise.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
b1ca6b1d47
staging: comedi: mpc624: remove commented out printk
...
This printk is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
54bb263764
staging: comedi: dt282x: remove commented out printk
...
This printk is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:22 -08:00
H Hartley Sweeten
50dbda4a9e
staging: comedi: dt282x: convert dt282x_ao_inttrig() messages
...
Convert the messages in this function to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
e0bee2de37
staging: comedi: dt282x: convert dt282x_ai_dma_interrupt() messages
...
Convert the messages in this function to dev_{level}().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
01112bf1ef
staging: comedi: dt282x: convert dt282x_ao_dma_interrupt() messages
...
Convert the messages in this function to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
427f35222e
staging: comedi: dt282x: remove disable code that disables the irq
...
The code that would disable the irq after getting a number of D/A errors
is disabled. Just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
d3ea1818f3
staging: comedi: dt282x: remove unnecessary blank line message
...
This blank line message is not needed. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
753b53d9b1
staging: comedi: dt282x: convert printk() in dt282x_attach to a dev_err()
...
Convert this printk message into a dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
ab49581ace
staging: comedi: dt282x: remove attach noise in dt282x_grab_dma()
...
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
06551fda7e
staging: comedi: dt282x: tidy up the irq support in dt282x_attach()
...
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.
Remove the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
Also, only call dt282x_grab_dma() if we have an irq since interrupt support
is needed to support dma.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
5b7b0eb2b2
staging: comedi: dt2815: convert printk's in dt2815_attach()
...
These messages don't appear to be important enough to warrent KERN_INFO
and KERN_WARNING levels. Convert them dev_dbg().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
38fa4c4cfd
staging: comedi: dt2815: convert printk's in dt2815_ao_insn()
...
Convert the printk(KERN_WARNING messages in this function to dev_dbg().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
c5a9595b23
staging: comedi: dt2814: tidy up the irq support in dt2814_attach()
...
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.
Remove the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
323cd3559f
staging: comedi: dt2814: convert a printk(KERN_ERR into a dev_err()
...
Convert this printk message into a dev_dev().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
1cb62c86ef
staging: comedi: dt2814: remove bad printk noise
...
This printk could spew a lot of noise while waiting for the ai conversion
to complete. Just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:21 -08:00
H Hartley Sweeten
f0256161c2
staging: comedi: dt2814: remove unnecessary printk noise
...
The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
d7bfe8e845
staging: comedi: dt2811: remove disabled interrupt support code
...
The interrupt support in this driver is incomplete due to the missing
comedi functions to support async commands.
Since the interrupt code is already disable just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
baa92cc0bf
staging: comedi: dt2811: remove disabled dt2811_adtrig() function
...
This function is not used by the driver. It's also suffering from bitrot
since COMEDI_MDEMAND and COMEDI_MCONTS are not defined anywhere. Just
remove the code.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
f3b672cf44
staging: comedi: dt2801: convert printk() messages to dev_dbg()
...
Convert all the printk() messages in this driver to dev_dbg().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
5fc517cd94
staging: comedi: dt2801: remove commented out printk()
...
This printk is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
cd5afa443a
staging: comedi: dt2801: remove disabled code in dt2801_writedata
...
The code that checks the DT_S_READY status is disabled. Just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
45d351031e
staging: comedi: dmm32at: convert a printk(KERN_ERR to a dev->err()
...
Convert this printk message to a dev_err() message.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
0c2e553241
staging: comedi: dmm32at: tidy up the irq support in dmm32at_attach()
...
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.
Remove the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
49220f916d
staging: comedi: dmm32at: remove commented out printk debug
...
These printk messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
65e2618fd3
staging: comedi: dmm32at: remove unnecessary printk noise
...
A timeout will return -ETIMEDOUT. The printks are just added noise.
Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
7299885076
staging: comedi: das16m1: tidy up the irq support in das16m1_attach()
...
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if an invalid irq is
selected by the user, or the request_irq() fails, the attach does not
fail.
Remove all the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
Tidy up das16m1_irq_bits() a bit. This helper returns the value that needs
to be written to the DAS16M1_INTR_CONTROL register to setup the irq routing.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
b8cd7941a0
staging: comedi: cb_pcimdas: remove unnecessary printk noise
...
The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:20 -08:00
H Hartley Sweeten
279579e40b
staging: comedi: cb_pcimdas: remove commented out irq init code
...
This driver does not have interrupt support. Remove the commented out
code that requests the irq.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
4dfe3df9b3
staging: comedi: c6xdigio: remove commented out function trace messages
...
These commented out messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
c89d6ea388
staging: comedi: c6xdigio: remove commented out subdevice code
...
The code to initialize subdevice[2] is commented out and incomplete.
Just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
e9c76f3f67
staging: comedi: adq12b: remove commented out debug message
...
Remove the commented out message, it would just be added noise.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
84f03cf1d5
staging: comedi: pcl818: convert some printk's to dev_dbg()
...
Convert these messages to dev_dbg() and tidy them up a bit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
5e1503aea7
staging: comedi: pcl816: convert some printk's to dev_dbg()
...
Convert these warning messages to dev_dbg() to minimize the noise.
Also, tidy them up a bit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
5adbc856a7
staging: comedi: pcl812: convert some printk's to dev_dbg()
...
Convert these debug messages to dev_dbg() and tidy them up a bit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
9b35db028f
staging: comedi: dmm32at: remove final attach noise and fix return value
...
The "success" message after an attach is just added noise. Remove it.
The normal return value for "success" is 0.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
96a1f91ae2
staging: comedi: adv_pci1710: convert some printk's to dev_dbg()
...
Convert these debug messages to dev_dbg().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
H Hartley Sweeten
15d2006970
staging: comedi: pcmmio.c: remove kcalloc() failure message
...
An allocation failure will have already displayed a message.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:20:19 -08:00
Aldo Iljazi
909cc6f9fa
Staging: usbip: vhci_hcd.c: removed a space
...
Line 921: Removed the space before the semicolon.
Signed-off-by: Aldo Iljazi <mail@aldo.io >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-12-03 09:15:02 -08:00