Chaehyun Lim
10e5efb7b5
staging: most: rename DIM_InitSync to dim_init_sync
...
This patch renames DIM_InitSync to dim_init_sync to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitSync>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:781:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
f1383176c9
staging: most: rename DIM_InitIsoc to dim_init_isoc
...
This patch renames DIM_InitIsoc to dim_init_isoc to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitIsoc>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:756:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
26303150c3
staging: most: rename DIM_InitAsync to dim_init_async
...
This patch renames DIM_InitAsync to dim_init_async to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitAsync>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:749:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
a3f3e92119
staging: most: rename DIM_InitControl to dim_init_control
...
This patch renames DIM_InitControl to dim_init_control to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitControl>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:742:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
aff1924508
staging: most: rename DIM_NormSyncBufferSize to dim_norm_sync_buffer_size
...
This patch renames DIM_NormSyncBufferSize to dim_norm_sync_buffer_size
to avoid camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_NormSyncBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:734:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
e302ca47b5
staging: most: rename DIM_NormIsocBufferSize to dim_norm_isoc_buffer_size
...
This patch renames DIM_NormIsocBufferSize to dim_norm_isoc_buffer_size
to avoid camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_NormIsocBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:720:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
c64c6073e8
staging: most: rename DIM_NormCtrlAsyncBufferSize to dim_norm_ctrl_async_buffer_size
...
This patch renames DIM_NormCtrlAsyncBufferSize to
dim_norm_ctrl_async_buffer_size to avoid camelcase found by checkpatch
CHECK: Avoid CamelCase: <DIM_NormCtrlAsyncBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:709:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
58889788fc
staging: most: rename DIMCB_IoRead to dimcb_io_read
...
This patch renames DIMCB_IoRead to dimcb_io_read to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIMCB_IoRead>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:157:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
1efc456462
staging: most: rename DIMCB_IoWrite to dimcb_io_write
...
This patch renames DIMCB_IoWrite to dimcb_io_write to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIMCB_IoWrite>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:154:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
de6687313d
staging: most: rename DIMCB_OnError to dimcb_on_error
...
This patch renames DIMCB_OnError to dimcb_on_error to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIMCB_OnError>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:77:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
b724207b41
staging: most: rename DIM_GetLockState to dim_get_lock_state
...
This patch renames DIM_GetLockState to dim_get_lock_state to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_GetLockState>
FILE: drivers/staging/most/hdm-dim2/dim2_hdm.c:131:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
38c3854490
staging: most: rename DIM_DetachBuffers to dim_detach_buffers
...
This patch renames DIM_DetachBuffers to dim_detach_buffers to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_DetachBuffers>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:886:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
50a45b170c
staging: most: rename DIM_Shutdown to dim_shutdown
...
This patch renames DIM_Shutdown to dim_shutdown to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_Shutdown>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:676:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
6417267f17
staging: most: rename DIM_Startup to dim_startup
...
This patch renames DIM_Startup to dim_startup to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_Startup>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:653:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
3c70754250
staging: most: add spaces preferred around that '<<'
...
This patch adds space around '<<' found by checkpatch.
CHECK: spaces preferred around that '<<' (ctx:VxV)
FILE: drivers/staging/most/hdm-dim2/dim2_reg.h:69:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
23242684c1
staging: most: remove blank line after an open brace
...
This patch removes blank line after an open brace found by checkpatch.
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Chaehyun Lim
fabb93f18f
staging: most: remove multiple blank lines
...
This patch removes multiple blank lines found by checkpatch.
CHECK: Please don't use multiple blank lines
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
25e168a4a3
staging: rtl8188eu: goto removed
...
malloc error handling moved into one place.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
4a3bda22fd
staging: rtl8188eu: goto replaced by 'else' branch
...
goto is not needed here.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
d14c07f6ff
staging: rtl8188eu: unused macros removed
...
IS_* and GET_CVID_* macros have not been used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
940f90eae6
staging: rtl8188eu: rarely used macros replaced by their definitions
...
IS_* macros (except one) occur only once.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
08ecab13e1
staging: rtl8188eu: for loop instead of while loop used
...
The range of elements to fill with zeros is determined by using a roundup macro
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
13cab3d422
staging: rtl8188eu: offset renamed to write_address
...
This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
7e91b28a01
staging: rtl8188eu: pu4BytePtr renamed to dword_buffer
...
This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
988c514688
staging: rtl8188eu: buf_ptr renamed to byte_buffer
...
This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
6e84aa6c82
staging: rtl8188eu: unnessesary braces for single statement block removed
...
checkpatch fix:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
429078e1f1
staging: rtl8188eu: unnecessary initialization removed
...
It is superfluous.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
645d2a8f46
staging: rtl8188eu: types of local variables conformed with types of function arguments
...
The array should not change in any case.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
1e7e93ee6d
staging: rtl8188eu: buf_ptr variable completely defined in a single line
...
It is simpler.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
ec60e037c7
staging: rtl8188eu: offset increment placed into for loop header
...
It makes the code little easier.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
f464b3a08c
staging: rtl8188eu: unnecessary branching removed
...
If the 'remain' is zero, the loop is not executed at all.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
8107b147d7
staging: rtl8188eu: unnecessary variable override removed
...
Variable value calculated in the previous loop.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
37d5579095
staging: rtl8188eu: offset variable replaced by its value
...
It is now possible to get rid of re-initializing the offset variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
1c48deffc7
staging: rtl8188eu: initial value placed in the variable
...
Line become shorter.
After the loop offset variable points to the location following insertion.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
d44f58f7c5
staging: rtl8188eu: assigning a value to the variable is replaced by the increment
...
It is made to the initial value could be placed in the offset variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
52863d83f3
staging: rtl8188eu: *(ptr + i) replaced by ptr[i] in _rtl88e_fw_block_write
...
It is better to read.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Abdul Hussain
6d9b0f00ec
Staging: rtl8188eu: fix space prohibited before that ','
...
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Abdul Hussain <hussain.abdul@outlook.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
37efd08231
staging: rtl8188eu: 'infinite' loop removed
...
The body of this loop is executed only once, so it can be removed.
In this loop no keyword 'continue', only 'break' at the end.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
72fb6c5a9d
staging: rtl8188eu: while loop replaced by for loop
...
Here is more suitable for loop.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Ivan Safonov
2b5a10a923
staging: rtl8188eu: do .. while (0) loop replaced by while (...) loop
...
It is a simple and clear representation of this loop.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Rémy Oudompheng
3913c19ae7
staging: rtl8188eu: add missing delay in polling loops.
...
Previously the code could exit with failure too early.
Signed-off-by: Rémy Oudompheng <remyoudompheng@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Rémy Oudompheng
ed73749426
staging: rtl8188eu: jiffies are unsigned long
...
Remove rtw_get_passing_time_ms function and adjust type
of relevant variables.
Signed-off-by: Rémy Oudompheng <remyoudompheng@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
f7ec22b5fa
Staging: lustre: ldlm_pool: Drop unneeded wrapper function
...
Remove the function ldlm_pool_set_limit() and replace its calls with the
function it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
946d6f9577
Staging: lustre: ldlm_pool: Drop wrapper function
...
Remove the function ldlm_pool_get_limit() and replace its calls with the
function it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
7c37abe0e1
Staging: lustre: ldlm_pool: Remove unneeded wrapper function
...
Remove the function ldlm_pl2ns() and replace its calls with the function
it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
7fb6f46b14
Staging: lustre: tracefile: Remove function prototype
...
Remove the prototype of function cfs_trace_free_string_buffer() as it is
no longer needed.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
7cbf673d8b
Staging: lustre: tracefile: Remove wrapper function
...
Remove the function cfs_trace_free_string_buffer() as it can be replaced
with the standard function kfree().
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
e4ce7f7779
Staging: lustre: module: Replace function calls
...
Replace the calls of function cfs_trace_free_string_buffer() with
kfree() as the former function is not required.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Shivani Bhardwaj
c6ef5b91f3
Staging: lustre: dir: Remove wrapper function
...
Remove the function ll_check_page() and replace all its calls with the
function it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
Amitoj Kaur Chawla
ee98e44249
staging: lustre: lnet: klnds: socklnd: Move extern declarations to header
...
This patch moves extern declarations in socklnd_lib.c to the respective
header file, 'socklnd.h'.
This patch also removes extern keyword from function declarations
since functions have the extern specifier by default.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com >
Acked-by: James Simmons <jsimmons@infradead.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00