Michael Straube
03449acb77
staging: rtl8188eu: constify some arrays
...
The values of these arrays in rtw_mlme_ext.c and rtw_wlan_util.c
are never changed, so make them const.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:32:33 +01:00
Michael Straube
0ef9f86b93
staging: rtl8188eu: convert unsigned char arrays to u8
...
Change the type of some arrays from unsigned char to u8.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:32:33 +01:00
Michael Straube
55fc57809a
staging: rtl8188eu: remove redundant declaration in rtw_mlme_ext.c
...
The array REALTEK_96B_IE is already declared in rtw_mlme.h,
so remove the declaration in rtw_mlme_ext.c.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:32:33 +01:00
Michael Straube
4f1a961ae1
staging: rtl8188eu: remove unused arrays WFD_OUI and WMM_INFO_OUI
...
The arrays WFD_OUI and WMM_INFO_OUI are not used anywhere,
so remove them.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:32:33 +01:00
Michael Straube
25c641ec2a
staging: rtl8188eu: remove unnecessary parentheses in rtw_mlme_ext.c
...
Remove unnecessary parentheses, most of them reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:30:29 +01:00
Michael Straube
011844addf
staging: rtl8188eu: remove unnecessary comments in rtw_mlme_ext.c
...
Remove comments from 'endif's where the corresponding 'if' is just
a few lines above to improve readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:30:29 +01:00
Michael Straube
7acaed81ab
staging: rtl8188eu: add blank line after declarations
...
Add a missing blank line after declarations in rtw_mlme_ext.c.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:30:29 +01:00
Michael Straube
f20ac243ff
staging: rtl8188eu: remove blank lines between declarations
...
Remove blank lines between declarations in rtw_mlme_ext.c.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:30:29 +01:00
Michael Straube
83691365f1
staging: rtl8188eu: remove commented declarations in rtw_mlme_ext.c
...
Remove unused/commented declarations.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:30:29 +01:00
Michael Straube
1673616a00
staging: rtl8188eu: replace tabs with spaces in rtw_mlme_ext.c
...
Replace tabs with spaces where appropriate.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:29:29 +01:00
Michael Straube
502b90d4c6
staging: rtl8188eu: cleanup declarations in rtw_mlme_ext.c
...
Replace tabs with spaces and/or remove spaces in declarations.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:29:28 +01:00
YueHaibing
b57f944785
staging: fbtft: fix strncmp() size warning
...
strncmp() stops comparing when either the end of one of the first two
arguments is reached or when 'n' characters have been compared, whichever
comes first.That means that strncmp(s1, s2, n) is equivalent to
strcmp(s1, s2) if n exceeds the length of s1 or the length of s2.
This patch avoids that the following warning is reported by smatch:
drivers/staging/fbtft/fbtft_device.c:1458
fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32)
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:29:28 +01:00
Colin Ian King
a86028f8e3
staging: most: sound: replace snprintf with strscpy
...
Using snprintf without a format specifier is potentially risky if
the string device_name contains format specifiers. Replace this with
the safer and more efficient strscpy.
Cleans up clang warning:
drivers/staging/most/sound/sound.c:673:41: warning: format string is not
a string literal (potentially insecure) [-Wformat-security]
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-19 08:28:22 +01:00
Christian Gromm
d464b7dba1
staging: most: Documentation: add information to driver_usage file
...
This patch updates driver_usage.txt file to reflect the latest changes
that this patch set introduces.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 16:10:20 +01:00
Christian Gromm
e6861b916e
staging: most: sound: remove channel number from ALSA card's long name
...
Adding the channel number to the name of the sound card is wrong,
as the card does not represent a single streaming channel of the
MOST device.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 16:10:20 +01:00
Christian Gromm
6cebb20196
staging: most: sound: use static name for ALSA card
...
This patch uses a static name for the sound card's short name and
long name. Having the card names configurable doesn't make sense
anymore, as the card represents the same physical hardware.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 16:10:20 +01:00
Christian Gromm
4c6375dc1c
staging: most: sound: rename variable
...
Since the channels of a MOST device are now being represented as
individual PCM devices of one sound card, the variable card_name is not
suitable anymore to describe them. Therefore, this patch renames the
variable to device_name.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 16:10:20 +01:00
Christian Gromm
ba99c63181
staging: most: sound: correct label name
...
This patch fixes the lable name that is used to jump to error
handling section of function audio_probe_channel() in case
something went wrong.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 16:10:20 +01:00
Christian Gromm
15600aea27
staging: most: sound: create one sound card w/ multiple PCM devices per MOST device
...
This patch avoids that a sound card is created and registered with ALSA
every time a channel is being linked. Instead the channels are hooked on
the same card, which is registered not until the final link has been added
to the component. The string provided by user space that used to be the
card name becomes the PCM device name. The user space API to add a link is
being expanded by a "create" flag to trigger the registration.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 16:10:20 +01:00
Dominic Braun
2074e8a7d0
staging: vc04_services: Remove VCHIU_QUEUE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:48:35 +01:00
Dominic Braun
2d0a029113
staging: vc04_services: Remove VCHIQ_STATE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:45 +01:00
Dominic Braun
f5a9826986
staging: vc04_services: Remove VCHIQ_SLOT_ZERO_T
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:45 +01:00
Dominic Braun
6f1e4141c7
staging: vc04_services: Remove VCHIQ_SLOT_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:45 +01:00
Dominic Braun
a610360370
staging: vc04_services: Remove VCHIQ_SLOT_INFO_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
c55aedfe60
staging: vc04_services: Remove VCHIQ_SHARED_STATE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
4f0922c87d
staging: vc04_services: Remove VCHIQ_SET_SERVICE_OPTION_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
7926c328d9
staging: vc04_services: Remove VCHIQ_SERVICE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
d3af2bcc6e
staging: vc04_services: Remove VCHIQ_SERVICE_QUOTA_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
0b53ca3127
staging: vc04_services: Remove VCHIQ_SERVICE_PARAMS_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
c18cbdee79
staging: vc04_services: Remove VCHIQ_SERVICE_BASE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:47:44 +01:00
Dominic Braun
87c091aadf
staging: vc04_services: Remove VCHIQ_QUEUE_MESSAGE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:46:22 +01:00
Dominic Braun
4040a7ee53
staging: vc04_services: Remove VCHIQ_QUEUE_BULK_TRANSFER_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:46:22 +01:00
Dominic Braun
e896852528
staging: vc04_services: Remove VCHIQ_HEADER_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:46:22 +01:00
Dominic Braun
3515279e6e
staging: vc04_services: Remove VCHIQ_GET_CONFIG_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:45:12 +01:00
Dominic Braun
392342b77c
staging: vc04_services: Remove VCHIQ_DUMP_MEM_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:34:25 +01:00
Dominic Braun
8ca743a19a
staging: vc04_services: Remove VCHIQ_DEQUEUE_MESSAGE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:34:25 +01:00
Dominic Braun
aa987e5513
staging: vc04_services: Remove VCHIQ_DEBUGFS_NODE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:34:25 +01:00
Dominic Braun
562943286c
staging: vc04_services: Remove VCHIQ_CREATE_SERVICE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:34:25 +01:00
Dominic Braun
8b86744753
staging: vc04_services: Remove VCHIQ_CONFIG_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
e69106e55d
staging: vc04_services: Remove VCHIQ_COMPLETION_DATA_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
bc96a5f0f7
staging: vc04_services: Remove VCHIQ_BULK_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
029a8a1894
staging: vc04_services: Remove VCHIQ_BULK_QUEUE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
cf69fc5216
staging: vc04_services: Remove VCHIQ_AWAIT_COMPLETION_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
e376ef3535
staging: vc04_services: Remove VCHIQ_ARM_STATE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
2be0bef086
staging: vc04_services: Remove VCHI_MSG_VECTOR_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
2a6e3234d6
staging: vc04_services: Remove VCHI_MSG_ITER_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
9d4d3ac473
staging: vc04_services: Remove VCHI_HELD_MSG_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
4dfc415fc2
staging: vc04_services: Remove USER_SERVICE_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
477e5caec4
staging: vc04_services: Remove SERVICE_CREATION_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00
Dominic Braun
4075fa9efc
staging: vc04_services: Remove REMOTE_EVENT_T typedef
...
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun <inf.braun@fau.de >
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-12-17 14:31:47 +01:00