H Hartley Sweeten
00a92c03be
staging: comedi: ni_mio_common: fix the (*insn_write) for the freq_out counter
...
The (*insn_write) functions are supposed to write insn->n data values and
return the number of values written. For this subdevice it only makes sense
to write the last data value.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:53 -07:00
H Hartley Sweeten
e63dabd00b
staging: comedi: ni_mio_common: absorb helpers into ni_freq_out_insn_config()
...
Absorb the helper functions that handle the INSN_CONFIG_SET_CLOCK_SRC and
INSN_CONFIG_GET_CLOCK_SRC comedi instructions.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:53 -07:00
H Hartley Sweeten
e879c315c3
staging: comedi: ni_mio_common: use dev->write_subdev
...
The (*attach) in ni_E_init() sets the dev->write_subdev to the analog
output subdevice. Use that instead of accessing the dev->subdevices
array directly.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
5dce16e51a
staging: comedi: ni_mio_common: use dev->read_subdev
...
The (*attach) in ni_E_init() sets the dev->read_subdev to the analog
input subdevice. Use that instead of accessing the dev->subdevices
array directly.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
2832b1831c
staging: comedi: ni_mio_common: move externally called functions to EOF
...
This source file is included by the ni_atmio, ni_mio_cs, and ni_pcmio
drivers to support the common hardware on National Instruments DAQ-STC
based boards.
The only functions actually used by the external source files are
ni_E_interrupt(), ni_alloc_private(), ni_E_init(), and mio_common_detach().
The rest of the functions in this file are only used locally.
For aesthetics, move all the externally called functions to the end of
the file.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
849590f759
staging: comedi: ni_mio_common: move disabled GPCT functions
...
I have not determined if the code in these functions is actually
usable. For now just move the disabled code closer to the working
gpct functions.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
2ffb247691
staging: comedi: ni_mio_common: remove forward declaration 24
...
Move some functions to remove the need for the remaining forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
624b161f7e
staging: comedi: ni_mio_common: remove forward declaration 23
...
Move ni_set_master_clock() and its helper functions to remove the need
for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
ae43763d34
staging: comedi: ni_mio_common: remove forward declaration 22
...
Move ni_rtsi_insn_config() and its helper functions to remove the need
for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
892885eafa
staging: comedi: ni_mio_common: remove forward declaration 21
...
Move ni_rtsi_init() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
3d129c3e5f
staging: comedi: ni_mio_common: remove forward declaration 20
...
Move ni_ai_insn_read() to remove the need for a forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
c75527fbf6
staging: comedi: ni_mio_common: remove forward declaration 19
...
Move ni_E_interrupt() to remove the need for some forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
2655c8a1d7
staging: comedi: ni_mio_common: remove forward declaration 18
...
Move ni_ai_drain_dma() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
f8f6d91d8e
staging: comedi: ni_mio_common: remove forward declaration 17
...
Move the get_last_sample_*() helpers to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
d2a577c022
staging: comedi: ni_mio_common: remove forward declaration 16
...
Move ni_ai_insn_config() to remove the need for a forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:52 -07:00
H Hartley Sweeten
8511b85823
staging: comedi: ni_mio_common: remove forward declaration 15
...
Move ni_ai_inttrig() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
f8246dfadb
staging: comedi: ni_mio_common: remove forward declaration 14
...
Move shutdown_ai_command() to remove the need for the forward
declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
189e173681
staging: comedi: ni_mio_common: remove forward declaration 13
...
Move ni_serial_insn_config() to remove the need for some forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
fed37a1e70
staging: comedi: ni_mio_common: remove forward declaration 12
...
Remove the need for the forward declaration of ni_cdio_cancel() by
indirectly calling it using the subdevice (*cancel).
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
0792928fd6
staging: comedi: ni_mio_common: remove forward declaration 11
...
Move ni_cdio_cmd() to remove the need for the forward declaration
of ni_cdo_inttrig().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
9a0c81a2be
staging: comedi: ni_mio_common: remove forward declaration 10
...
These forward declarations are not needed.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
12db14163e
staging: comedi: ni_mio_common: remove forward declaration 9
...
Move ni_rtsi_insn_bits() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
24e7c352ba
staging: comedi: ni_mio_common: remove forward declaration 8
...
Move the cs5529 calibration subdevice functions and helpers to remove
the need for the forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
4187a79a84
staging: comedi: ni_mio_common: remove forward declaration 7
...
Move the programmable function inputs subdevice functions and helpers
to remove the need for the forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
c8508a1d7b
staging: comedi: ni_mio_common: remove forward declaration 6
...
Move the ni_gpct_cmd() and ni_gpct_cancel() functions to remove the
need for the forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
62c2bce022
staging: comedi: ni_mio_common: remove forward declaration 5
...
Move the calibration subdevice functions and helpers to remove the need
for the forward declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
9e7cb171de
staging: comedi: ni_mio_common: remove forward declaration 4
...
Move the caldac "packbits" callbacks to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
1e49c5da48
staging: comedi: ni_mio_common: remove forward declaration 3
...
Move the pwm config functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:51 -07:00
H Hartley Sweeten
36adeee19e
staging: comedi: ni_mio_common: remove forward declaration 2
...
Move the eeprom read functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:50 -07:00
H Hartley Sweeten
f5985867ff
staging: comedi: ni_mio_common: remove forward declaration 1
...
Move ni_8255_callback() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com >
Reviewed-by: Ian Abbott <abbotti@mev.co.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:33:50 -07:00
Sachin Kamat
806c4879e0
staging: bcm: Remove redundant casting in Bcmchar.c
...
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:09:49 -07:00
Sachin Kamat
db5767a3f9
staging: rtl8723au: Remove redundant casting in rtw_mlme.c
...
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:09:49 -07:00
Sachin Kamat
248c959152
staging: rtl8723au: Remove redundant casting in rtw_mlme_ext.c
...
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:09:48 -07:00
Alexey Tulia
a06a24d2b7
staging: usbip: fixed a coding-style warning
...
This fixes the following warning:
- WARNING: __constant_cpu_to_le32 should be cpu_to_le32
Signed-off-by: Alexey Tulia <alexey.tulia@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:08:58 -07:00
Geert Uytterhoeven
ee264346fa
staging: rtl8723au: Add compiler check for -Wtype-limits
...
Gcc versions before 4.3 do not support -Wtype-limits:
cc1: error: unrecognized command line option "-Wtype-limits"
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org >
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:08:58 -07:00
Jes Sorensen
7579a7e47d
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Avoid pointless memcpy
...
There is no point copying a buffer, just to scan it and then free it
again.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:07:30 -07:00
Jes Sorensen
3798786626
staging: rtl8723au: Move FillH2CCmd() prototype to rtl8723a_cmd.h where it really belongs
...
As an added bonus, remove the now obsolete rtw_ioctl_set.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:07:30 -07:00
Jes Sorensen
da23732c63
staging: rtl8723au: Quiet unused variable warning when building with CONFIG_8723AU_AP_MODE=n
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:07:30 -07:00
Jes Sorensen
073c9d47c3
staging: rtl8723au: Don't run regular scans in the driver, the stack handles that
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:07:30 -07:00
Jes Sorensen
e9bb5ad46d
staging: rtl8723au: rtw_set_802_11_bssid23a_list_scan(): Use __func__ to print function name
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:07:30 -07:00
Jes Sorensen
27fd731ece
staging: rtl8723au: Move rtw_get_cur_max_rate23a() to ioctl_cfg80211.c
...
This function has only one caller, so move it home and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:07:08 -07:00
Jes Sorensen
023b40d882
staging: rtl8723au: rtw_get_cur_max_rate23a(): We are in N mode if WLAN_EID_HT_CAPABILITY is present
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:05:40 -07:00
Jes Sorensen
8f9558b906
staging: rtl8723au: rtw_get_cur_max_rate23a(): Remove duplicate fwstate checks
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:24 -07:00
Jes Sorensen
e007b4c77c
staging: rtl8723au: Move rtw_do_join23a() to rtw_mlme.c and declare it static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00
Jes Sorensen
e89c05505f
staging: rtl8723au: rtw_do_join23a(): Don't start scanning if network isn't found
...
Don't start running network scans if trying to connect to a network
not in our cache. Let the 802.11 stack do it's job instead.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00
Jes Sorensen
72795e9de7
staging: rtl8723au: rtw_set_ssid(): Use rtw_do_join_network()
...
We already have the wlan_network we wish to join, hence it's pointless
to go back to the scanned_queue and pull it out of there, before
running the join logic.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00
Jes Sorensen
85b3c5e48e
staging: rtl8723au: rtw_select_and_join_from_scanned_queue23a() never returns 2
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00
Jes Sorensen
66ed1bc999
staging: rtl8723au: rtw_surveydone_event_callback23a(): We always set _FW_UNDER_LINKING
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00
Jes Sorensen
e5c4db0959
staging: rtl8723au: to_join will no be true if _FW_LINKED is set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00
Jes Sorensen
3221bb536d
staging: rtl8723au: Remove no-op rtw_get_encrypt_decrypt_from_registrypriv23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-06-18 14:04:23 -07:00