Thorsten Blum
479bec4cb3
pds_fwctl: Replace kzalloc + copy_from_user with memdup_user in pdsfc_fw_rpc
...
Replace kzalloc() followed by copy_from_user() with memdup_user() to
improve and simplify pdsfc_fw_rpc().
Return early if an error occurs and remove the obsolete 'err_out' label.
No functional changes intended.
Link: https://patch.msgid.link/r/20250917150941.168887-1-thorsten.blum@linux.dev
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Reviewed-by: Dave Jiang <dave.jiang@intel.com >
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com >
Tested-by: Brett Creeley <brett.creeley@amd.com >
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com >
2025-09-22 10:33:10 -03:00
Liao Yuanhong
f123430130
pds_fwctl: Remove the use of dev_err_probe()
...
Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].
The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.
[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/
Link: https://patch.msgid.link/r/20250820124011.474224-1-liaoyuanhong@vivo.com
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com >
Reviewed-by: Dave Jiang <dave.jiang@intel.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Brett Creeley <brett.creeley@amd.com >
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com >
2025-08-22 10:14:18 -03:00
Shannon Nelson
fd292c1f10
pds_fwctl: Fix type and endian complaints
...
Fix a number of type and endian complaints from the sparse checker.
Link: https://patch.msgid.link/r/20250402165630.24288-1-shannon.nelson@amd.com
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202504020246.Dfbhxoo9-lkp@intel.com/
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com >
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Reviewed-by: Dave Jiang <dave.jiang@intel.com >
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com >
2025-04-11 20:47:45 -03:00
Brett Creeley
92c66ee829
pds_fwctl: add rpc and query support
...
The pds_fwctl driver doesn't know what RPC operations are available
in the firmware, so also doesn't know what scope they might have. The
userland utility supplies the firmware "endpoint" and "operation" id values
and this driver queries the firmware for endpoints and their available
operations. The operation descriptions include the scope information
which the driver uses for scope testing.
Link: https://patch.msgid.link/r/20250320194412.67983-6-shannon.nelson@amd.com
Reviewed-by: Leon Romanovsky <leonro@nvidia.com >
Signed-off-by: Brett Creeley <brett.creeley@amd.com >
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com >
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com >
2025-03-21 20:57:55 -03:00
Shannon Nelson
4d09dd11d7
pds_fwctl: initial driver framework
...
Initial files for adding a new fwctl driver for the AMD/Pensando PDS
devices. This sets up a simple auxiliary_bus driver that registers
with fwctl subsystem. It expects that a pds_core device has set up
the auxiliary_device pds_core.fwctl
Link: https://patch.msgid.link/r/20250320194412.67983-5-shannon.nelson@amd.com
Reviewed-by: Leon Romanovsky <leonro@nvidia.com >
Reviewed-by: Dave Jiang <dave.jiang@intel.com >
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com >
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com >
2025-03-21 20:57:55 -03:00
