mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 17:01:25 -05:00
spi: cs42l43: Property entry should be a null-terminated array
The software node does not specify a count of property entries, so the
array must be null-terminated.
When unterminated, this can lead to a fault in the downstream cs35l56
amplifier driver, because the node parse walks off the end of the
array into unknown memory.
Fixes: 0ca645ab5b ("spi: cs42l43: Add speaker id support to the bridge configuration")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220371
Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Link: https://patch.msgid.link/20250731160109.1547131-1-simont@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
committed by
Mark Brown
parent
926406a85a
commit
ffcfd071ee
@@ -295,7 +295,7 @@ static struct spi_board_info *cs42l43_create_bridge_amp(struct cs42l43_spi *priv
|
||||
struct spi_board_info *info;
|
||||
|
||||
if (spkid >= 0) {
|
||||
props = devm_kmalloc(priv->dev, sizeof(*props), GFP_KERNEL);
|
||||
props = devm_kcalloc(priv->dev, 2, sizeof(*props), GFP_KERNEL);
|
||||
if (!props)
|
||||
return NULL;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user