mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-02 14:34:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

mfd: cros_ec: Remove zero-size structs

Browse Source 
Empty structure size is different between C and C++.
To prevent clang warning when compiling this include file in C++
programs, remove empty structures.

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Fabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Gwendal Grignou
2019-06-03 11:33:40 -07:00
committed by Lee Jones
parent e849b87487
commit fd3bbf4a47
1 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
include/linux/mfd/cros_ec_commands.h
View File

@@ -1540,10 +1540,14 @@ struct lightbar_program {
struct ec_params_lightbar {
uint8_t cmd; /* Command (see enum lightbar_command) */
union {
struct {
/* no args */
} dump, off, on, init, get_seq, get_params_v0, get_params_v1,
version, get_brightness, get_demo, suspend, resume;
/*
* The following commands have no args:
*
* dump, off, on, init, get_seq, get_params_v0, get_params_v1,
* version, get_brightness, get_demo, suspend, resume
*
* Don't use an empty struct, because C++ hates that.
*/
struct __ec_todo_unpacked {
uint8_t num;
@@ -1597,11 +1601,13 @@ struct ec_response_lightbar {
uint8_t red, green, blue;
} get_rgb;
struct {
/* no return params */
} off, on, init, set_brightness, seq, reg, set_rgb,
demo, set_params_v0, set_params_v1,
set_program, manual_suspend_ctrl, suspend, resume;
/*
* The following commands have no response:
*
* off, on, init, set_brightness, seq, reg, set_rgb,
* set_params_v0, set_params_v1, set_program,
* manual_suspend_ctrl, suspend, resume
*/
};
} __ec_todo_packed;
@@ -3021,9 +3027,7 @@ enum charge_state_params {
struct ec_params_charge_state {
uint8_t cmd; /* enum charge_state_command */
union {
struct {
/* no args */
} get_state;
/* get_state has no args */
struct __ec_todo_unpacked {
uint32_t param; /* enum charge_state_param */
@@ -3049,9 +3053,8 @@ struct ec_response_charge_state {
struct __ec_align4 {
uint32_t value;
} get_param;
struct {
/* no return values */
} set_param;
/* set_param returns no args */
};
} __ec_align4;