mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 04:21:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

btrfs: btrfs_log_dev_io_error() on all bio errors

Browse Source 
As far as I can tell, we never intentionally constrained ourselves to
these status codes, and it is misleading and surprising to lack the
bdev error logging when we get a different error code from the block
layer. This can lead to jumping to a wrong conclusion like "this
system didn't see any bio failures but aborted with EIO".

For example on nvme devices, I observe many failures coming back as
BLK_STS_MEDIUM. It is apparent that the nvme driver returns a variety of
BLK_STS_* status values in nvme_error_status().

So handle the known expected errors and make some noise on the rest
which we expect won't really happen.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anand Jain <asj@kernel.org>
Signed-off-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Boris Burkov
2026-04-06 09:15:15 -07:00
committed by David Sterba
parent 3cd181cc46
commit fc3d532881
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fs/btrfs/bio.c
View File

@@ -4,6 +4,7 @@
* Copyright (C) 2022 Christoph Hellwig.
*/
#include <linux/blk_types.h>
#include <linux/bio.h>
#include "bio.h"
#include "ctree.h"
@@ -350,11 +351,18 @@ static void btrfs_check_read_bio(struct btrfs_bio *bbio, struct btrfs_device *de
static void btrfs_log_dev_io_error(const struct bio *bio, struct btrfs_device *dev)
{
blk_status_t sts = bio->bi_status;
if (!dev || !dev->bdev)
return;
if (bio->bi_status != BLK_STS_IOERR && bio->bi_status != BLK_STS_TARGET)
if (unlikely(sts == BLK_STS_OK))
return;
if (unlikely(sts != BLK_STS_IOERR && sts != BLK_STS_TARGET &&
sts != BLK_STS_MEDIUM && sts != BLK_STS_PROTECTION)) {
btrfs_warn_rl(dev->fs_info, "bdev %s unexpected block io error: %d",
btrfs_dev_name(dev), sts);
return;
}
if (btrfs_op(bio) == BTRFS_MAP_WRITE)
btrfs_dev_stat_inc_and_print(dev, BTRFS_DEV_STAT_WRITE_ERRS);
else if (!(bio->bi_opf & REQ_RAHEAD))