mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-02-27 16:24:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

smb: client: fix warning in cifs_match_super()

Browse Source 
Fix potential dereference of ERR_PTR @tlink as reported by kernel test
robot

  fs/smb/client/connect.c:2775 cifs_match_super() error: 'tlink'
  dereferencing possible ERR_PTR()

Link: https://lore.kernel.org/all/202306170124.CtQqzf0I-lkp@intel.com/
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Paulo Alcantara
2023-06-19 16:52:01 -03:00
committed by Steve French
parent dc765027ed
commit fc1bd51d11
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
fs/smb/client/connect.c
View File

@@ -2767,8 +2767,9 @@ cifs_match_super(struct super_block *sb, void *data)
}
tlink = cifs_get_tlink(cifs_sb_master_tlink(cifs_sb));
if (tlink == NULL) {
/* can not match superblock if tlink were ever null */
if (IS_ERR_OR_NULL(tlink)) {
pr_warn_once("%s: skip super matching due to bad tlink(%p)\n",
__func__, tlink);
spin_unlock(&cifs_tcp_ses_lock);
return 0;
}