mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-09-03 08:52:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

RDMA/rxe: Check PDs for memory window binds

Browse Source 
The IBTA Software Transport Verbs specification requires the QP,
Memory Window and Memory Region for a Bind Memory Window operation
to belong to the same HCA and protection domain.

rxe only checked the QP and MW protection domain for type 2 MWs.
Move the QP/MW PD check to the common bind path and also reject
binding an MW to an MR from a different PD.

Invalid bind requests continue to fail with IB_WC_MW_BIND_ERR.

Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: Zhiwei Zhang <202275009@qq.com>
Link: https://patch.msgid.link/tencent_FD4FB25AA4FFA845E63F5AC36CF4A46CDC0A@qq.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
This commit is contained in:
Zhiwei Zhang
2026-06-26 09:59:20 +08:00
committed by Leon Romanovsky
parent 4dc9c884c0
commit fbbe1d5cd7
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/infiniband/sw/rxe/rxe_mw.c
View File

@@ -72,13 +72,6 @@ static int rxe_check_bind_mw(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
return -EINVAL;
}
/* C10-72 */
if (unlikely(qp->pd != to_rpd(mw->ibmw.pd))) {
rxe_dbg_mw(mw,
"attempt to bind type 2 MW with qp with different PD\n");
return -EINVAL;
}
/* o10-37.2.40 */
if (unlikely(!mr || wqe->wr.wr.mw.length == 0)) {
rxe_dbg_mw(mw,
@@ -87,10 +80,21 @@ static int rxe_check_bind_mw(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
}
}
/* remaining checks only apply to a nonzero MR */
/* C10-72 */
if (unlikely(qp->pd != rxe_mw_pd(mw))) {
rxe_dbg_mw(mw, "attempt to bind MW with qp with different PD\n");
return -EINVAL;
}
if (!mr)
return 0;
/* remaining checks only apply to a nonzero MR */
if (unlikely(qp->pd != mr_pd(mr))) {
rxe_dbg_mw(mw, "attempt to bind MW/QP to MR with different PD\n");
return -EINVAL;
}
if (unlikely(mr->access & IB_ZERO_BASED)) {
rxe_dbg_mw(mw, "attempt to bind MW to zero based MR\n");
return -EINVAL;