mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 10:11:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

maple_tree: add test for rebalance calculation off-by-one

Browse Source 
During the big node removal, an incorrect rebalance step went too far up
the tree causing insufficient nodes.  Test the faulty condition by
recreating the scenario in the userspace testing.

Link: https://lkml.kernel.org/r/20260130205935.2559335-24-Liam.Howlett@oracle.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Cc: Alice Ryhl <aliceryhl@google.com>
Cc: Andrew Ballance <andrewjballance@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christian Kujau <lists@nerdbynature.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Liam R. Howlett
2026-01-30 15:59:28 -05:00
committed by Andrew Morton
parent 971f0db159
commit ebfee00c0b
1 changed files with 125 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

125
tools/testing/radix-tree/maple.c
View File

@@ -35888,6 +35888,127 @@ static __init int build_full_tree(struct maple_tree *mt, unsigned int flags,
return ret;
}
static noinline void __init check_erase_rebalance(struct maple_tree *mt)
{
unsigned long val;
void *enode;
int ret;
MA_STATE(mas, mt, 0, 0);
/*
* During removal of big node, the rebalance started going too high,
* which resulted in too many nodes trying to be used.
*
* Create a rebalance which results in an exactly full parent (0-9) that
* does not need to be rebalanced. This required two full levels,
* followed by an insufficient level which will be rebalanced into two
* nodes, finally leaves that need to be rebalanced into one node.
*
* The bugs tree:
* root 4 Label R
* /\ /\
* 9 X F
* /\ /\ /
* 9 X E
* /\ /\ /\
* 4 8 C D
* /\ /\
* 6 9 A B
* ^ becomes 5 with the write.
*
* Below, the reconstruction leaves the root with 2 entries, the setup
* uses the letter labels above.
*/
ret = build_full_tree(mt, MT_FLAGS_ALLOC_RANGE, 4);
MT_BUG_ON(mt, ret);
/* Cheap expansion to 5 levels */
mtree_store(mt, ULONG_MAX, xa_mk_value(0), GFP_KERNEL);
/* rcu is used to ensure node use */
mt_set_in_rcu(mt);
mas_lock(&mas);
/* Node A had 6 entries */
mas_walk(&mas);
MAS_BUG_ON(&mas, mas_data_end(&mas) < 6);
while (mas_data_end(&mas) > 6) {
mas_erase(&mas);
mas_next(&mas, ULONG_MAX);
}
/* Move to Node B */
enode = (void*) mas.node;
while (mas.node == enode)
mas_next(&mas, ULONG_MAX);
/* Node B had 9 entries */
MAS_BUG_ON(&mas, mas_data_end(&mas) < 9);
while (mas_data_end(&mas) > 9) {
mas_erase(&mas);
mas_next(&mas, ULONG_MAX);
}
/* Move to Node C */
mas_ascend(&mas);
val = mas.max;
/* Adjust entries to be 4 */
while (mas_data_end(&mas) > 4) {
mas_set(&mas, val);
mas_erase(&mas);
mas_prev(&mas, 0);
val = mas.index;
mas_ascend(&mas);
}
/* Move to Node D */
mas_ascend(&mas);
mas.offset = 1;
mas_descend(&mas);
val = mas.max;
/* Adjust entries to be 8 */
while (mas_data_end(&mas) < 8) {
mas_set(&mas, val--);
mas_store_gfp(&mas, &mas, GFP_KERNEL);
mas_ascend(&mas);
}
/* Move to Node E */
mas_ascend(&mas);
val = mas.max;
MAS_BUG_ON(&mas, mas_data_end(&mas) > 9);
/* Adjust Node E to 9 entries */
while (mas_data_end(&mas) < 9) {
mas_set(&mas, val--);
mas_store_gfp(&mas, &mas, GFP_KERNEL);
mas_ascend(&mas);
mas_ascend(&mas);
}
/* Move to Node F */
mas_ascend(&mas);
val = mas.max;
MAS_BUG_ON(&mas, mas_data_end(&mas) > 9);
/* Adjust Node F to 9 entries */
while (mas_data_end(&mas) < 9) {
mas_set(&mas, val--);
mas_store_gfp(&mas, &mas, GFP_KERNEL);
mas_ascend(&mas);
mas_ascend(&mas);
mas_ascend(&mas);
}
/* Test is set up, walk to first entry */
mas_set(&mas, 0);
mas_next(&mas, ULONG_MAX);
/* overwrite the entry to cause a rebalance, which was 1 too few */
mas_set_range(&mas, 0, mas.last);
mas_preallocate(&mas, NULL, GFP_KERNEL);
mas_store_prealloc(&mas, NULL);
mas_unlock(&mas);
}
static noinline void __init check_mtree_dup(struct maple_tree *mt)
{
DEFINE_MTREE(new);
@@ -36249,6 +36370,10 @@ void farmer_tests(void)
check_mtree_dup(&tree);
mtree_destroy(&tree);
mt_init_flags(&tree, MT_FLAGS_ALLOC_RANGE);
check_erase_rebalance(&tree);
mtree_destroy(&tree);
/* RCU testing */
mt_init_flags(&tree, 0);
check_erase_testset(&tree);