mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-30 10:00:03 -04:00
ice: fix FDIR CTRL VSI resource leak in ice_reset_all_vfs()
Resetting all VFs causes resource leak on VFs with FDIR filters
enabled as CTRL VSIs are only invalidated and not freed. Fix by using
ice_vf_ctrl_vsi_release() instead of ice_vf_ctrl_invalidate_vsi() which
aligns behavior with the ice_reset_vf() function.
Reproduction:
echo 1 > /sys/class/net/$pf/device/sriov_numvfs
ethtool -N $vf flow-type ether proto 0x9000 action 0
echo 1 > /sys/class/net/$pf/device/reset
Fixes: da62c5ff9d ("ice: Add support for per VF ctrl VSI enabling")
Signed-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
This commit is contained in:
committed by
Tony Nguyen
parent
56abdaebbf
commit
ebbe8868cf
@@ -801,7 +801,7 @@ void ice_reset_all_vfs(struct ice_pf *pf)
|
||||
* setup only when VF creates its first FDIR rule.
|
||||
*/
|
||||
if (vf->ctrl_vsi_idx != ICE_NO_VSI)
|
||||
ice_vf_ctrl_invalidate_vsi(vf);
|
||||
ice_vf_ctrl_vsi_release(vf);
|
||||
|
||||
ice_vf_pre_vsi_rebuild(vf);
|
||||
if (ice_vf_rebuild_vsi(vf)) {
|
||||
|
||||
Reference in New Issue
Block a user