mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 10:01:39 -05:00
ASoC: soc-core: check ops & auto_selectable_formats in snd_soc_dai_get_fmt() to prevent dereference error
Smatch reported an issue that "ops" could be null (see line 174) where later "ops" is dereferenced to extract the dai fmts, also auto_selectable_formats can also be null. Add a proper null check before accessing both the ptrs to ensure a safe execution. Signed-off-by: HariKrishna Sagala <hariconscious@gmail.com> Link: https://patch.msgid.link/20251030105313.32199-2-hariconscious@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
committed by
Mark Brown
parent
6ef8e042cd
commit
e73b743bfe
@@ -177,8 +177,9 @@ u64 snd_soc_dai_get_fmt(const struct snd_soc_dai *dai, int priority)
|
||||
if (max < until)
|
||||
until = max;
|
||||
|
||||
for (i = 0; i < until; i++)
|
||||
fmt |= ops->auto_selectable_formats[i];
|
||||
if (ops && ops->auto_selectable_formats)
|
||||
for (i = 0; i < until; i++)
|
||||
fmt |= ops->auto_selectable_formats[i];
|
||||
|
||||
return fmt;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user