mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-10 06:49:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

staging: iio: meter: add check on return variables

Browse Source 
adds checks on variables that are used to return values. If
the value is less than zero, this indicates that an error
occurred and hence a message is printed through dev_err.
Checks are made on negative values only since spi_* functions
return negative error codes.

The functions were found using the following script but the
aforementioned modification was what was carried out in the end:
@@
identifier len,f;
@@

-int len;
 ... when != len
     when strict
-len =
+return
        f(...);
-return len;

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Aya Mahfouz
2015-03-03 16:27:37 +02:00
committed by Greg Kroah-Hartman
parent 82d28561b7
commit e384b69a35
1 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/staging/iio/meter/ade7758_core.c
View File

@@ -303,14 +303,15 @@ static int ade7758_reset(struct device *dev)
int ret;
u8 val;
ade7758_spi_read_reg_8(dev,
ADE7758_OPMODE,
&val);
ret = ade7758_spi_read_reg_8(dev, ADE7758_OPMODE, &val);
if (ret < 0) {
dev_err(dev, "Failed to read opmode reg\n");
return ret;
}
val |= 1 << 6; /* Software Chip Reset */
ret = ade7758_spi_write_reg_8(dev,
ADE7758_OPMODE,
val);
ret = ade7758_spi_write_reg_8(dev, ADE7758_OPMODE, val);
if (ret < 0)
dev_err(dev, "Failed to write opmode reg\n");
return ret;
}
@@ -444,14 +445,15 @@ static int ade7758_stop_device(struct device *dev)
int ret;
u8 val;
ade7758_spi_read_reg_8(dev,
ADE7758_OPMODE,
&val);
ret = ade7758_spi_read_reg_8(dev, ADE7758_OPMODE, &val);
if (ret < 0) {
dev_err(dev, "Failed to read opmode reg\n");
return ret;
}
val |= 7 << 3; /* ADE7758 powered down */
ret = ade7758_spi_write_reg_8(dev,
ADE7758_OPMODE,
val);
ret = ade7758_spi_write_reg_8(dev, ADE7758_OPMODE, val);
if (ret < 0)
dev_err(dev, "Failed to write opmode reg\n");
return ret;
}