mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-07-22 05:47:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising

Browse Source 
When configuring the link parameters in forced mode for the AQR-105, the
Extended Next Page bit gets advertised for Multi-Gigabit modes.

This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This
contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as
the Extended Next Page advertising. This bit used to be marked as
reserved, but a proper define for it was added in :

commit e7a62edd34 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")

Let's use it instead of the ADVERTISE_RESV definition, making the code
more self-documenting.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260428125827.238469-1-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Maxime Chevallier
2026-04-28 14:58:27 +02:00
committed by Jakub Kicinski
parent 776059b702
commit e2d217fe3f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/phy/aquantia/aquantia_main.c
View File

@@ -385,15 +385,15 @@ static int aqr105_setup_forced(struct phy_device *phydev)
vend |= MDIO_AN_VEND_PROV_1000BASET_HALF;
break;
case SPEED_2500:
adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
vend |= MDIO_AN_VEND_PROV_2500BASET_FULL;
break;
case SPEED_5000:
adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
vend |= MDIO_AN_VEND_PROV_5000BASET_FULL;
break;
case SPEED_10000:
adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
ctrl10 |= MDIO_AN_10GBT_CTRL_ADV10G;
break;
default: