mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-02-21 23:29:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

staging: gpib: avoid unintended sign extension

Browse Source 
The code was basically like this (assuming size_t can be u64)
    var_u64 |= var_u8 << 24
var_u8 is first promoted to i32 and then the shift is done. Next, it is
promoted to u64 by first signextending to 64 bits. This is very unlikely
what was intended. So now it is first forced to u32.
    var_u64 |= (u32)var_u8 << 24

This was detected by Coverity, CID 1600792.

Fixes: 4c41fe886a ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB driver")
Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
Link: https://lore.kernel.org/r/20241108201207.1194F18DDF5@bout3.ijzerbout.nl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kees Bakker
2024-10-17 21:54:47 +02:00
committed by Greg Kroah-Hartman
parent 7345316422
commit e27cd6791d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/gpib/agilent_82357a/agilent_82357a.c
View File

@@ -664,10 +664,10 @@ static ssize_t agilent_82357a_generic_write(gpib_board_t *board, uint8_t *buffer
kfree(status_data);
return -EIO;
}
*bytes_written = status_data[2];
*bytes_written |= status_data[3] << 8;
*bytes_written |= status_data[4] << 16;
*bytes_written |= status_data[5] << 24;
*bytes_written = (u32)status_data[2];
*bytes_written |= (u32)status_data[3] << 8;
*bytes_written |= (u32)status_data[4] << 16;
*bytes_written |= (u32)status_data[5] << 24;
kfree(status_data);
return 0;