mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-31 14:04:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

RDMA/hfi1: Align probe error unwinding with device removal

Browse Source 
init_one() defers handling errors from hfi1_init() and
hfi1_register_ib_device() to a combined block. This allows IB registration
to run after device initialization has failed. Cleanup then depends on two
unrelated error values.

The late probe failure path also differs from the common teardown in
remove_one(), even though both release the same initialized hardware and
driver resources. Maintaining separate sequences obscures ownership and
allows the paths to drift whenever initialization changes.

Unwind at each failing stage and keep late probe teardown ordered like
remove_one(), so partial initialization releases exactly the resources it
owns and normal removal remains the reference cleanup flow.

Link: https://patch.msgid.link/20260708-clean-init-one-hfi1-v1-13-b9e9641268a5@nvidia.com
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
This commit is contained in:
Leon Romanovsky
2026-07-13 07:41:25 -04:00
parent bb18740b30
commit e26c48cf23
1 changed files with 16 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
drivers/infiniband/hw/hfi1/init.c
View File

@@ -1549,18 +1549,14 @@ static void postinit_cleanup(struct hfi1_devdata *dd)
hfi1_dev_affinity_clean_up(dd);
hfi1_pcie_ddcleanup(dd);
hfi1_pcie_cleanup(dd->pcidev);
cleanup_device_data(dd);
hfi1_free_devdata(dd);
}
static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
int ret = 0, pidx, initfail;
int ret;
struct hfi1_devdata *dd;
struct hfi1_pportdata *ppd;
/* First, lock the non-writable module parameters */
HFI1_CAP_LOCK();
@@ -1627,34 +1623,19 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
goto destroy_workqueues; /* error already printed */
/* do the generic initialization */
initfail = hfi1_init(dd, 0);
ret = hfi1_init(dd, 0);
if (ret)
goto free_rx;
ret = hfi1_register_ib_device(dd);
if (ret)
goto free_rx;
/*
* Now ready for use. this should be cleared whenever we
* detect a reset, or initiate one.
*/
if (!initfail && !ret)
dd->flags |= HFI1_INITTED;
if (initfail || ret) {
msix_clean_up_interrupts(dd);
stop_timers(dd);
for (pidx = 0; pidx < dd->num_pports; ++pidx) {
hfi1_quiet_serdes(dd->pport + pidx);
ppd = dd->pport + pidx;
destroy_workqueue(ppd->hfi1_wq);
destroy_workqueue(ppd->link_wq);
}
if (!ret)
hfi1_unregister_ib_device(dd);
hfi1_free_rx(dd);
postinit_cleanup(dd);
if (initfail)
ret = initfail;
return ret; /* everything already cleaned */
}
dd->flags |= HFI1_INITTED;
ret = hfi1_device_create(dd);
if (ret)
@@ -1666,6 +1647,12 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return 0;
free_rx:
hfi1_free_rx(dd);
shutdown_device(dd);
stop_timers(dd);
postinit_cleanup(dd);
destroy_workqueues:
destroy_workqueues(dd);
free_devdata:
@@ -1711,11 +1698,11 @@ static void remove_one(struct pci_dev *pdev)
* clear dma engines, etc.
*/
shutdown_device(dd);
destroy_workqueues(dd);
stop_timers(dd);
postinit_cleanup(dd);
destroy_workqueues(dd);
hfi1_free_devdata(dd);
hfi1_pcie_cleanup(pdev);
}
static void shutdown_one(struct pci_dev *pdev)